Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Sun, 1 Oct 2023 16:27:30 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Michal Hocko <mhocko@suse.com>, Nhat Pham <nphamcs@gmail.com>,
        akpm@linux-foundation.org, riel@surriel.com,
        roman.gushchin@linux.dev, shakeelb@google.com,
        muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com,
        shuah@kernel.org, yosryahmed@google.com, linux-mm@kvack.org,
        kernel-team@meta.com, linux-kernel@vger.kernel.org,
        cgroups@vger.kernel.org
Subject: Re: [PATCH 0/2] hugetlb memcg accounting
Message-ID: <20231001232730.GA11194@monkey>
References: <20230926194949.2637078-1-nphamcs@gmail.com>
 <ZRQQMABiVIcXXcrg@dhcp22.suse.cz>
 <20230927184738.GC365513@cmpxchg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230927184738.GC365513@cmpxchg.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fhmxk9jxxNAZl7NvrO9S2tTUIu8cCpyxp7ZEENN92xdy7UX9oqBMEziSWoym?=
 =?us-ascii?Q?1aqkJ8Rse8q/ajsYRVfMIfT9B6WQoQlv1MOycYc7Xx6mNvZX6vnTavvcoKJz?=
 =?us-ascii?Q?x4+YGC7Tbwj5P5Uxvh81QCGrtOXVIHchUtSMKkdNRvv4h92bZyj729LXP+Cj?=
 =?us-ascii?Q?MyVhZfiUtyGfVQTwzSdNMqMy0QYsqptvy4lY8HXNLnbiA3VCDzucWQPJ1Lsl?=
 =?us-ascii?Q?yih1QwEV/XPoKip/SFMLnw6huy9ebLdjULQi0oti5hwWgUCrrNcLvbaib353?=
 =?us-ascii?Q?uLkocPaYmvRSrS0/dwNxtKObvT2rjLrbhhGJRzHXTsHEO5jw6SLKd5FYv872?=
 =?us-ascii?Q?sZ9bFv9q4GkhtO94avru4a1CWox03oNYmnD6E9odVEipKrjTyfOcV7p743zp?=
 =?us-ascii?Q?e/nbQ4TqbETyGPp0i50CfJTV1IDIxtu6murVyLAkBrVjDVO30Dz1o95PBYwJ?=
 =?us-ascii?Q?y/ijEWnl1IhXRhkhkoB51b2WRo8U+Gk2kay3rLiSlSYCGUGCKBM/VEkABBPl?=
 =?us-ascii?Q?zRqEkbPzAF3Vd5PMFa+6sEDFRakeV/y2vwp/pv5SEC2C3W5A8gcfUUWibwty?=
 =?us-ascii?Q?3uVia6UUkFTVtaNaL52rqKbL+f+WM37c2dNSWSzGxh+Xaf/dEzJ1PiNapcS9?=
 =?us-ascii?Q?zFGLFxjEmg4uA70Z4R8cKxBm9pJXhg9cBMeNQLY5ppSfBT0CEheGRGuTQGIX?=
 =?us-ascii?Q?DENGLcGyl+3NDX3qNY+XQYz6ykUc9h+XiWjr7aEGrhzgoNIGbzzSHj6lwdUK?=
 =?us-ascii?Q?JEAu23EunU85VzL5a6V8X4b0IHzOU4fI1aen18yDa63rRZ+hP3BBvz2+Bwp7?=
 =?us-ascii?Q?xGGo++qX91YHhiRdktae1e4X905kqK7QhLSv2vZcExUdduG0uGXWFvqvq/oq?=
 =?us-ascii?Q?zzhmV3kl/Tj51yW2D/5Z6vjnku9sxhoJ90wADYNLlJH5FbGNpxgBLXZei78h?=
 =?us-ascii?Q?MI12nonmzlJdb9GzI4K0dPalXqU+5aSq6rl4Ac/YXeTqtWG9ktr3vUqs7qyf?=
 =?us-ascii?Q?PurACNc/z8ERkZmr/d+0WLW2a0vRd6ZnpxM2qdJ/eQ62KdSO2DXyHIRCA+pV?=
 =?us-ascii?Q?jsOVkMdjvnrAcxZv0GE6nqPCdAHZCXctnZyKMcn428qakyrrJ3WIbp5fGxDS?=
 =?us-ascii?Q?pIQNmVvPkx7w2mJ6yWbmk/53YM/fuVt4FDfn8gt7hRkpYwG12aK3Iyct96Fm?=
 =?us-ascii?Q?x1IuG6tz0EjEfcbEkrS/l0QbUx7nhzR3x0XKmyZLpmhquei1JHgOyKrzqd9K?=
 =?us-ascii?Q?jTIdghVXu3UqZSYD5A+xgC2kfNAeDvqt336EQNeZVbegaPi7yi5oG4OZJY+n?=
 =?us-ascii?Q?+3PynlZE3p3Ks7qEMxNXo03o3WVGIKxg2fBU9M73uwDwbjR42rMxAxlOeD4n?=
 =?us-ascii?Q?lMXEbpVo/i9g/gY+oIXbdilnfpR6i/7t1OIRST++TT/DI55Y5nKBFZZqx2Cv?=
 =?us-ascii?Q?vkIQB9wYLbzuCl6mmTm0Fbmx8Oj1KB4bIN1iBTFsz0c4fycPhUxdYbVVn53X?=
 =?us-ascii?Q?jnKlNfQQjb35Ln+otlmQHivofOTdVypv95AOnE1nMaOCWKLkhTuQAnRCBFMd?=
 =?us-ascii?Q?KMY8exqWWQQhOcvQyCXM5HRFrsAE843DRIlhCmBk?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?xYguQwKkIcSVgPcDsFWqev97uygRm6CITSggG1HUx6hvn0HqrbE/Kwmsa1Bv?=
 =?us-ascii?Q?mp6IgWdgFT4Gwe35t+x2bcSYZrG9ZsiIfEpYX2W8M1sbJWXiZ5RkiInUBuVE?=
 =?us-ascii?Q?TxLVd/VrTeDg7Zx7wZTyNXMtOBb79rGGQvQhR6VYSCLTf72JwX9f3PgR83wB?=
 =?us-ascii?Q?fZNI272uMRUARWSUJIlLsCI742CDQHwDWbKCaEDhsozlJHZQFEZUq5Yaxz5R?=
 =?us-ascii?Q?PPijtvDfcK0FOVNI57ux5KKquIFBoRKLcf8V5pLY7mPQQfnT0JAUF+1dIR3j?=
 =?us-ascii?Q?Orb0Owyb6EJz1I2xG65Xm3ckE0oTD+IPF0xSy/6qwy+z6XdM3QJHU8fotQW2?=
 =?us-ascii?Q?539P66fUp2og48C9T3v/XTFvnHdUsMLgo94Sh5KtwY7/Al9NJ4RCKT5CkwsZ?=
 =?us-ascii?Q?WJr3wyQnXxL/Tda+g0uzoPfGnoHUZPHyztWJova00VpnzZalHyxTDLDe1JOR?=
 =?us-ascii?Q?sLtlOY0X3aY2aVe4UjRJqZe8nSfAnSCRrD9+/d7G+cCzMDEI2sg3oTabhfy1?=
 =?us-ascii?Q?OF1AKioj7t86kRmeFDZoOSigbWDQglD9oxEdPFP/QLIjcm8zxhsjQ+qfXK80?=
 =?us-ascii?Q?fV6m+t8HtcSrQblNVwddTeLODL5pAufy1kbbFV0ywjDgShZ/qe3agSPmUYT0?=
 =?us-ascii?Q?r5XT7A9LyDIrwB1X38nCgZWPBRRoXttV13r6ghop+hqde/jdxF77G8Bc5iAb?=
 =?us-ascii?Q?e0T3LM5+LP1FOyuiVBPwUOgkh8LpSzUXDjZZMeRw3CdNa2ssZead30bPzaBy?=
 =?us-ascii?Q?RbD0iQSz14Q5t35ZqVYBBoxzPebv8CV/glecFcmmMaE4qgYI0i/9ukasCW59?=
 =?us-ascii?Q?2Dm6dWYCnFwRYthNrKwDdtqz0CsDKknGu8Pmr5bFzr1EVQKsVkb4bCnJamfM?=
 =?us-ascii?Q?46xesLB9ii9gmypFb1qS06BDjLXmyM8kvwR/7oN1DfFWlCMN5nOFJOSq1uMb?=
 =?us-ascii?Q?/oJ+5ROp7w6TckpXUiNjoaQcwKUlr5bqDGzcegjkmOlSKxZ9cqk/TaRshv8v?=
 =?us-ascii?Q?+OnGaiMLpx+S6yPTEIrhhFXtZFl/jB+LHj1jcXTMLoIBikfonLsdBkHYDpNy?=
 =?us-ascii?Q?MK0bGx6eO21daFtNqAnppLbkVFEhXxizoYvfR1+SRP0i6vsv590=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67396643-35f7-41db-db06-08dbc2d5fd99
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 23:27:34.5865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g180/pVcD/Nq9Et86F+JCIGy+80jjRLJXy7wvVxRnDllWb+ygwTuR2Wpbn73KlGBamVH9sErUCZgoEtrFSd9Aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5062
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-01_21,2023-09-28_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 mlxlogscore=706 bulkscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310010188
X-Proofpoint-GUID: cHiiP0DFMg_Hq3l_cXFHczg298Ddybq7
X-Proofpoint-ORIG-GUID: cHiiP0DFMg_Hq3l_cXFHczg298Ddybq7
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 01 Oct 2023 16:34:16 -0700 (PDT)

On 09/27/23 14:47, Johannes Weiner wrote:
> On Wed, Sep 27, 2023 at 01:21:20PM +0200, Michal Hocko wrote:
> > On Tue 26-09-23 12:49:47, Nhat Pham wrote:
> 
> So that if you use 80% hugetlb, the other memory is forced to stay in
> the remaining 20%, or it OOMs; and that if you don't use hugetlb, the
> group is still allowed to use the full 100% of its host memory
> allowance, without requiring some outside agent continuously
> monitoring and adjusting the container limits.

Jumping in late here as I was traveling last week.  In addition, I want
to state my limited cgroup knowledge up front.

I was thinking of your scenario above a little differently.  Suppose a
group is up and running at almost 100% memory usage.  However, the majority
of that memory is reclaimable.  Now, someone wants to allocate a 2M hugetlb
page.  There is not 2MB free, but we could easily reclaim 2MB to make room
for the hugetlb page.  I may be missing something, but I do not see how that
is going to happen.  It seems like we would really want that behavior.
-- 
Mike Kravetz