Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <a610eab7-4651-27e0-7283-b7ac4ea34cf3@suse.cz>
Date:   Mon, 2 Oct 2023 08:39:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not
 uptodate case
To:     Christoph Hellwig <hch@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Joe Perches <joe@perches.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>
References: <20230930231029.88196-1-lstoakes@gmail.com>
 <ZRpiiq/pUB6hGTl/@infradead.org>
Content-Language: en-US
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <ZRpiiq/pUB6hGTl/@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/2/23 08:26, Christoph Hellwig wrote:
>> +		 * If the invalidate lock is not held, the folio was in cache and
>> +		 * uptodate and now it is not. Strange but possible since we
> 
> Please don't spill block comments ôver the 80 charater limit, that makes
> them impossible to read nicely.

Joe, can we revert the default to 80 to avoid everyone having to alias
--max-line-length=80 locally?