Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1182009rdb; Mon, 2 Oct 2023 01:21:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3tHKhzoIw8trzDklo2vfq2ISR7ng4vW7hcECr0S1WjrbjY7e267DnQi17LoBBD56Fl7KU X-Received: by 2002:a17:902:dacd:b0:1c4:4f01:d18f with SMTP id q13-20020a170902dacd00b001c44f01d18fmr12163308plx.14.1696234908754; Mon, 02 Oct 2023 01:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696234908; cv=none; d=google.com; s=arc-20160816; b=XkmxkQXv0YpMazBqFc8M0CZIni5Hwmv9POLlE2EEZaVwNbUyQP5ROAFAnmtSwc1Ivn 2GI6ALc7Eu0jgMUxQTLJ4uy1DIu4mDCjG/ZZu/KPY+jA+4ARZ32WkrS9WuHjgB0ZWGFa AubLoH0kZNXQdqzdSizEWFN/7vSAwzTy6SeKxcHlNQSVNicYhUajITRS+XxYM0AEka86 mKaMuPbpSzyMQ/1iYBzPeDyNZ0cLTE1XwdO8eAkq5V7dEUbOlaQbHE0Gd+Ex8NAufSly mCNbBlKQgc0RDXSzuBceDsUSQESUq8vUsA4UJvn8wiaF/eciA4GWEU156I64yAnVTMvI g7ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g+PPt0PZHmo02mh9GogQC8Pu3uCPDQcILPNZPjjYZfY=; fh=vQaOpf0FA71x5qpzmxxvZJuCZweMkniYbQv6KGZvVtg=; b=SCvxpDrY9NrJ5PngG5m1ulIEAp6VXQlJ02cnxL4Ti8K0kgnOGm2Pnx2u42CsRENPv5 z0qhUNtZ13Z/VqzKYPL62pbjoxo4r76p5VwLf5znF/C1m3QXWkosUOULy/kVQi42zIDS vLi++oJXxSTRfgVsDoTuol6oHLTywTtcf6GqG8iH/99XgsPEjkQUAGfLfe2XXRJQxUyl mAXwXuI0r8md2YXybX3RB5YDLBDWP0t6P46vWPryz/c4kqkSQiGqTDaXsd2MspzYf+jw FOEJGLMfFBLBL7WHLOeMLAkAlezDel74kZAHoP79v8YFk8E2v0P6dHxoVLh7HV8gh5Vy ViOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QZLNWR45; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id l11-20020a170903120b00b001c3845d008csi27354050plh.424.2023.10.02.01.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 01:21:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QZLNWR45; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 5A4B4809F384; Sun, 1 Oct 2023 23:26:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235489AbjJBG0X (ORCPT + 99 others); Mon, 2 Oct 2023 02:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235457AbjJBG0X (ORCPT ); Mon, 2 Oct 2023 02:26:23 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BB36AB for ; Sun, 1 Oct 2023 23:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=g+PPt0PZHmo02mh9GogQC8Pu3uCPDQcILPNZPjjYZfY=; b=QZLNWR45DDwYvykpS/pQrIHlYn mj7UEVifF3CRoZh+GTU2halUtIsz0RFEYT8v08k3nXOiAEWb6eosJrR1EIt5esZpyfH03W+aD7sHu WeS0dyqm4vNW9nsi2spY+r5jRN5dQHM5iuiR2vEBTmJMFJYaFeMvoNQmL4kLh/YNkdPuGlWi3S0EB DTN+eYNP47lN9MhrB4yfAdYk1lU5gCLLQCmsg4BywY4x7HTAAl4R39FTy26gEJEAABVl/iRaSVRKC OeK1gV7NWkwfAA9bwLzfuGLQLAAbvuoOaQHOVIVukzvG/PGFcAi39Szi8XC+ZyFz/dyraN94lxKqU 9NTJEROw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qnCNm-00C1a2-3B; Mon, 02 Oct 2023 06:26:18 +0000 Date: Sun, 1 Oct 2023 23:26:18 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Jan Kara Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case Message-ID: References: <20230930231029.88196-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230930231029.88196-1-lstoakes@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 01 Oct 2023 23:26:35 -0700 (PDT) > + * If the invalidate lock is not held, the folio was in cache and > + * uptodate and now it is not. Strange but possible since we Please don't spill block comments ?ver the 80 charater limit, that makes them impossible to read nicely.