Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <6fb3fa0fe3e53d6e31c8ab6f96a9549da1d659f0.camel@perches.com>
Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not
 uptodate case
From:   Joe Perches <joe@perches.com>
To:     Vlastimil Babka <vbabka@suse.cz>,
        Christoph Hellwig <hch@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>
Date:   Mon, 02 Oct 2023 02:43:41 -0700
In-Reply-To: <a610eab7-4651-27e0-7283-b7ac4ea34cf3@suse.cz>
References: <20230930231029.88196-1-lstoakes@gmail.com>
         <ZRpiiq/pUB6hGTl/@infradead.org>
         <a610eab7-4651-27e0-7283-b7ac4ea34cf3@suse.cz>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-10-02 at 08:39 +0200, Vlastimil Babka wrote:
> On 10/2/23 08:26, Christoph Hellwig wrote:
> > > +		 * If the invalidate lock is not held, the folio was in cache and
> > > +		 * uptodate and now it is not. Strange but possible since we
> > 
> > Please don't spill block comments ?ver the 80 charater limit, that makes
> > them impossible to read nicely.
> 
> Joe, can we revert the default to 80 to avoid everyone having to alias
> --max-line-length=80 locally?

Given the current --max-line-length default is 100,
and that was Linus' preference, I think not.

https://lore.kernel.org/lkml/CAHk-=wj3iGQqjpvc+gf6+C29Jo4COj6OQQFzdY0h5qvYKTdCow@mail.gmail.com/

and

https://lore.kernel.org/lkml/CAHk-=wjR0H3+2ba0UUWwoYzYBH0GX9yTf5dj2MZyo0xvyzvJnA@mail.gmail.com/