Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231001-vf610-gpio-v5-0-8d873a8f224a@nxp.com> <20231001-vf610-gpio-v5-4-8d873a8f224a@nxp.com>
In-Reply-To: <20231001-vf610-gpio-v5-4-8d873a8f224a@nxp.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 2 Oct 2023 11:04:27 +0200
Message-ID: <CAMRc=MdXkFBWMuyr8sbetyP2sJX2QG6Ce=Tsb7RVMguvGdC3TA@mail.gmail.com>
Subject: Re: [PATCH v5 4/7] gpio: vf610: add i.MX8ULP of_device_id entry
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Stefan Agner <stefan@agner.ch>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Marco Felsch <m.felsch@pengutronix.de>,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Peng Fan <peng.fan@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 1, 2023 at 10:23=E2=80=AFAM Peng Fan (OSS) <peng.fan@oss.nxp.co=
m> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> i.MX8ULP/93 GPIO supports similar feature as i.MX7ULP GPIO, but i.MX8ULP =
is
> actually not hardware compatible with i.MX7ULP. i.MX8ULP only has one
> register base, not two bases. i.MX8ULP and i.MX93 actually has two
> interrupts for each gpio controller, one for Trustzone non-secure world,
> one for secure world.
>
> Although the Linux Kernel driver gpio-vf610.c could work with
> fsl,imx7ulp-gpio compatible, it is based on some tricks did in device tre=
e
> with some offset added to base address.
>
> Add a new of_device_id entry for i.MX8ULP. But to make the driver could
> also support old bindings, check the compatible string first, before
> check the device data.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/gpio/gpio-vf610.c | 47 ++++++++++++++++++++++++++++++++++++++++-=
------
>  1 file changed, 40 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index dbc7ba0ee72c..8e12706c0b22 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -25,6 +25,7 @@
>  struct fsl_gpio_soc_data {
>         /* SoCs has a Port Data Direction Register (PDDR) */
>         bool have_paddr;
> +       bool have_dual_base;
>  };
>
>  struct vf610_gpio_port {
> @@ -60,13 +61,26 @@ struct vf610_gpio_port {
>  #define PORT_INT_EITHER_EDGE   0xb
>  #define PORT_INT_LOGIC_ONE     0xc
>
> +#define IMX8ULP_GPIO_BASE_OFF  0x40
> +#define IMX8ULP_BASE_OFF       0x80
> +
> +static const struct fsl_gpio_soc_data vf610_data =3D {
> +       .have_dual_base =3D true,
> +};
> +
>  static const struct fsl_gpio_soc_data imx_data =3D {
>         .have_paddr =3D true,
> +       .have_dual_base =3D true,
> +};
> +
> +static const struct fsl_gpio_soc_data imx8ulp_data =3D {
> +       .have_paddr =3D true,
>  };
>
>  static const struct of_device_id vf610_gpio_dt_ids[] =3D {
> -       { .compatible =3D "fsl,vf610-gpio",       .data =3D NULL, },
> +       { .compatible =3D "fsl,vf610-gpio",       .data =3D &vf610_data }=
,
>         { .compatible =3D "fsl,imx7ulp-gpio",     .data =3D &imx_data, },
> +       { .compatible =3D "fsl,imx8ulp-gpio",     .data =3D &imx8ulp_data=
, },
>         { /* sentinel */ }
>  };
>
> @@ -263,19 +277,38 @@ static int vf610_gpio_probe(struct platform_device =
*pdev)
>         struct gpio_irq_chip *girq;
>         int i;
>         int ret;
> +       bool dual_base;
>
>         port =3D devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
>         if (!port)
>                 return -ENOMEM;
>
>         port->sdata =3D of_device_get_match_data(dev);
> -       port->base =3D devm_platform_ioremap_resource(pdev, 0);
> -       if (IS_ERR(port->base))
> -               return PTR_ERR(port->base);
>
> -       port->gpio_base =3D devm_platform_ioremap_resource(pdev, 1);
> -       if (IS_ERR(port->gpio_base))
> -               return PTR_ERR(port->gpio_base);
> +       dual_base =3D port->sdata->have_dual_base;
> +
> +       /* support old compatible strings */
> +       if (device_is_compatible(dev, "fsl,imx7ulp-gpio") &&
> +           (device_is_compatible(dev, "fsl,imx93-gpio") ||

Why not just add this compatible to vf610_gpio_dt_ids?

Bart

> +           (device_is_compatible(dev, "fsl,imx8ulp-gpio"))))
> +               dual_base =3D true;
> +
> +       if (dual_base) {
> +               port->base =3D devm_platform_ioremap_resource(pdev, 0);
> +               if (IS_ERR(port->base))
> +                       return PTR_ERR(port->base);
> +
> +               port->gpio_base =3D devm_platform_ioremap_resource(pdev, =
1);
> +               if (IS_ERR(port->gpio_base))
> +                       return PTR_ERR(port->gpio_base);
> +       } else {
> +               port->base =3D devm_platform_ioremap_resource(pdev, 0);
> +               if (IS_ERR(port->base))
> +                       return PTR_ERR(port->base);
> +
> +               port->gpio_base =3D port->base + IMX8ULP_GPIO_BASE_OFF;
> +               port->base =3D port->base + IMX8ULP_BASE_OFF;
> +       }
>
>         port->irq =3D platform_get_irq(pdev, 0);
>         if (port->irq < 0)
>
> --
> 2.37.1
>