Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1229863rdb; Mon, 2 Oct 2023 03:24:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjgjeA0I1bQQkyFnaIAZvpwkeZd7fWs1XQTKyAHWkw3cFqQWvoNZ7gQYUjYPNB4L1mQe0f X-Received: by 2002:a17:90b:3e8b:b0:26b:5461:8dd5 with SMTP id rj11-20020a17090b3e8b00b0026b54618dd5mr7645078pjb.42.1696242294750; Mon, 02 Oct 2023 03:24:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696242294; cv=none; d=google.com; s=arc-20160816; b=GXs2FEyS/XpFcTOeP1YSDqbgLW+JpfVNlBb28MAB5Is8rSCGAIelSKj+3IMRQ0dCoH crOl86a3rRf0ZGWu0uOwU+/c2ZAtdGfnbiKpfwXJLM/4ut6f+SGmz6SIUUIorVvgEC6f mAnRfJm6qH1kv2oC+jFE7HBySImydQ0yMLNn8sO3M+fv7Uk5vpzLuS0M025mxWmJShW0 g4Ua6tqgsN1V9c7D+EpY8M31yLYSoCNfdPdhA13bT7JLIK7wDCuR8/MTMWVNYMM2sTNK PXfVCLLKt6uxZnfS1tBkDmWt3SustMURLvDH6A+BnlknS8Mt8k3A53v1v7yghsLAyzzx nWrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gli/JT5QxIyyR/f1rdtAbW0iLqLfU5usMUc1tdgF/FA=; fh=dPFT4Nd0Wb7ip8cuDikNehB8tDMfQ2acPXza9aRvzy4=; b=iV/6Kv3Pjdp7/+FSUBUcFzSs0xoch3nx14Eqa8GSGdc9h+B1+gneXGPH9V+MNEJExJ CFtY4GIN8MYr6oOe6Ns2GX8QVtWGK9fFEDmj9gBTaPidJ/4R1cmlcgkzWhMRBvZafDgz ystbmxOtS3kbx67c4Ijoe97smlCFwhPny9W0bjJyRyuGaBMIgsmg+z/rgaxUAvLAlCLs e07GUDfUGCzNegTTAt642PxkWnZy6L+UerBnxQf1pDIoXErMf2BG0ECwRAqncdQaYM00 fdUo3bWJMQCwihxTB5DS575bvFxp/BiUvcrtwvkL9hGcEzjrWCbVb6uNxNKEYsNKUy3c djSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id e23-20020a63db17000000b00578d026e2eesi25727003pgg.283.2023.10.02.03.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 03:24:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id DB4AB807616A; Mon, 2 Oct 2023 03:17:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236372AbjJBKRB (ORCPT + 99 others); Mon, 2 Oct 2023 06:17:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236414AbjJBKQ6 (ORCPT ); Mon, 2 Oct 2023 06:16:58 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3182D197 for ; Mon, 2 Oct 2023 03:16:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90F01C433CA; Mon, 2 Oct 2023 10:16:50 +0000 (UTC) Date: Mon, 2 Oct 2023 11:16:48 +0100 From: Catalin Marinas To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann Subject: Re: [PATCH 4/4] mm/gup: adapt get_user_page_vma_remote() to never return NULL Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 03:17:14 -0700 (PDT) On Sun, Oct 01, 2023 at 05:00:05PM +0100, Lorenzo Stoakes wrote: > get_user_pages_remote() will never return 0 except in the case of > FOLL_NOWAIT being specified, which we explicitly disallow. > > This simplifies error handling for the caller and avoids the awkwardness of > dealing with both errors and failing to pin. Failing to pin here is an > error. > > Suggested-by: Arnd Bergmann > Signed-off-by: Lorenzo Stoakes > --- > arch/arm64/kernel/mte.c | 4 ++-- For arm64: Acked-by: Catalin Marinas