Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        =?iso-8859-1?Q?Andr=E9_Apitzsch?= <git@apitzsch.eu>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error
Thread-Topic: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error
Thread-Index: AQHZ9IHazMX7YhLcF0uqntJC6sFjerA2PGKAgAAB24CAAADD4IAABRIAgAAATqCAAASGQA==
Date:   Mon, 2 Oct 2023 10:16:05 +0000
Message-ID: <OS0PR01MB5922DB512AA15526C138351986C5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20231001-ak_magnetometer-v1-1-09bf3b8798a3@apitzsch.eu>
 <20231002102745.0000540b@Huawei.com> <ZRqOn8tnJqvU22ex@smile.fi.intel.com>
 <OS0PR01MB5922C468BEF67BC2A19F87D286C5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
 <ZRqThAuMogtcMtHI@smile.fi.intel.com>
 <OS0PR01MB5922036435F7B4E2DB83B9F386C5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
In-Reply-To: <OS0PR01MB5922036435F7B4E2DB83B9F386C5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?qXhNFG/SyI/9nOXTb5lCJlj4LsGandnbrFh64hGnEXvFYDbdmZDA7BteaC?=
 =?iso-8859-1?Q?dY/5qlYWH090TLX8d+Ftw7S91De4Oqg/ktnI/AR6qTK2rJ6OZJv2qFr+I0?=
 =?iso-8859-1?Q?WzZVlsU70ZDbaAvKDn29JGrTsmN1E96KePD4wXELCk9FIiUF8+CDzpYbgF?=
 =?iso-8859-1?Q?Qx2QAWsQ4ZlL84z4rBXOTj1BZqy6GnLJZzpFojYtd70mwieNy9RRraWv9L?=
 =?iso-8859-1?Q?Z67hAuSAVZYE4CIoGB1V9wKEV3JeTQxATqNhToqQ14fQPcH5cbTisICn0D?=
 =?iso-8859-1?Q?KOIYLOzHm0uOl9QV4FsK+qmyJ49hmPkhcATLNkbP15aQeZXRtQ3me0G5S1?=
 =?iso-8859-1?Q?/8GBAL/lweMjNIrc/E8haT+AMQuwbS0vHRjnb+0IHvEKbYmu/Jl7fMxPLF?=
 =?iso-8859-1?Q?IXAv255ikvucX9LGtbqcrH9P2d2woR4wGMpbKBAhuj3dG1gS/riM6UqrIU?=
 =?iso-8859-1?Q?cHteC5tFKg9jaWXQ4cqOOvJTEJ8QHTcUHbSDHy5cuv5f+Xbmyd7k72EdKa?=
 =?iso-8859-1?Q?/VJsupTFO1RasI94d5+p41QygFG0tkxiGFLVqdXLGq8wy/Fc/ljG4YDWqJ?=
 =?iso-8859-1?Q?GsWzCcbCRny3xdGw2eit6m+AzORrrZu4OndISeY/sry/zg5KW5nN5Era28?=
 =?iso-8859-1?Q?0XjCf5N1nkT126pfstsh7rMRE3LFx+KNYdbgWDqIISjMjL7kJxQa3BzzNt?=
 =?iso-8859-1?Q?Ll7ifgYVBFlPZBHohSm7JiP/L8XbiHQnxbM1vK8NbsWIMHZwJed/wZi8FU?=
 =?iso-8859-1?Q?oWvDkogfL+iFtGpUxX2hUgBK5VVevFYnx+sLUpRnesUZHhBWH5xcMkZlWR?=
 =?iso-8859-1?Q?fF/xdZl1fmTl8guSo9nJQu2cqLJ9G/k3dduZ7XvEiE+OaSyEZudQA7LA3K?=
 =?iso-8859-1?Q?FEV/tgd1EyC8THvmS+Jmfbyq1AMLNf9sCYJlxYjBefCR8jdGA5XoSMuVQb?=
 =?iso-8859-1?Q?f0RjZJthNQqXVEpLQMgjRYOTppQv8iWmuZA1c75UTEnT8rn9EEg+5s9Gky?=
 =?iso-8859-1?Q?72DpsO8A59IZC6CZr0h/LY2ZBAZmQFjcEIXb3eGPrMd8MnHQOZ5gO12yBR?=
 =?iso-8859-1?Q?HqR3pqfPWVYT0/b1ON1YvmvKQYntdXJspA7zS/o5w5VPsJtDN1mMQFbR43?=
 =?iso-8859-1?Q?qXgxVfB2Gwxn0LrGL2XZm1iZgU8z5gN0r8z/l5+IByw2SaSP+woBP7C/GC?=
 =?iso-8859-1?Q?I1Yy2hVcFts6TpzqFZFS3sEcOsfaaHW4HXb/XKLyr5O7JJVHccoijogZ9W?=
 =?iso-8859-1?Q?9xrofH+fINrwWkjiT5noPgwWz1n7x9s7OF44+4fgirm35wGN8JC8RFNUhV?=
 =?iso-8859-1?Q?U5Zf93XVjhnNPOV8NIWpMS54e42eAg/07LNiqTbwPQgvlFqcuo3yZR8zw2?=
 =?iso-8859-1?Q?Txfyf+VlwS3pt90KHoH1X3JqzumFaeCSBNSDT8zmXikL+nWYIiTgz5QOFG?=
 =?iso-8859-1?Q?k0lU6tIu9NIGEUtYByhxuyPViSdAX5f0CeBZ1Kv5lcmYFqSY2wggQSsllK?=
 =?iso-8859-1?Q?JF+UGPmHgTFuFI5tHoT3pgTmGhII5EChgKNNCdeWGymMElRrz5VpR69YDC?=
 =?iso-8859-1?Q?1QRxdr8OGJsfpD0/o0Mf1ixlYNsv5gFiLxtpQg5P90iOy0YzgjlglQdkzl?=
 =?iso-8859-1?Q?JViywaOklrrWzVQpC+r/Iur1PFVTl285leiPnvNAU15or6xXmjlkodXw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1470ee63-66ab-4ffe-a763-08dbc330966c
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 10:16:05.2188
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: d2Qltf448n+UCR4+3DQfMEjz9FEofug1KjRNzIsieNoL3ilHsM00ld/W49rgj2+vcmdV3DmeF3jgXA8MwuuQFVq7ud4bW6MCv62uCivTlqw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB9886
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 03:16:27 -0700 (PDT)


> -----Original Message-----
> From: Biju Das
> Sent: Monday, October 2, 2023 10:57 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>; Andr=E9 Apitzsch
> <git@apitzsch.eu>; Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clause=
n
> <lars@metafoo.de>; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.or=
g
> Subject: RE: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device'
> error
>=20
> > Subject: Re: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device'
> > error
> >
> > On Mon, Oct 02, 2023 at 09:38:17AM +0000, Biju Das wrote:
> > > > On Mon, Oct 02, 2023 at 10:27:45AM +0100, Jonathan Cameron wrote:
> > > > > On Sun, 1 Oct 2023 18:09:56 +0200 Andr=E9 Apitzsch
> > > > > <git@apitzsch.eu> wrote:
> > > >
> > > > > > Fixes: 4f9ea93afde1 ("iio: magnetometer: ak8975: Convert
> > > > > > enum->pointer for data in the match tables")
> > > >
> > > > ^^^ (1)
> >
> > ...
> >
> > > > > So we need the spacer until someone converts this driver to use
> > > > > pointers instead for both of and ACPI tables.
> > > >
> > > > Isn't it done by (1) which is in your tree?
> > >
> > > How (1) can trigger 'Unexpected device' error??
> > > It returns match_data, and match_data has correct device type.
> >
> > How? The enum starts from 0 with a AKXXXX and ak_def_array starts from
> > 0 indexing, it's classical off-by-one, you got the driver data for a
> > wrong chip.
>=20
> Got it. I was about to reply. It just needs mapping as Andre did here.

Or split this array into device specific individual variable
to avoid any mapping.

Cheers,
Biju