Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20230911094443.14040-1-brgl@bgdev.pl> <cd4df23c-cc02-6723-e36d-34ca03409e6e@nvidia.com>
In-Reply-To: <cd4df23c-cc02-6723-e36d-34ca03409e6e@nvidia.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 2 Oct 2023 10:33:02 +0200
Message-ID: <CAMRc=MeWXapho1bsX9Si5uSx7MWVhpT2cqrv5S+qPo51Ko=Vtg@mail.gmail.com>
Subject: Re: [PATCH] hte: tegra194: improve the GPIO-related comment
To:     Dipen Patel <dipenp@nvidia.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        timestamp@lists.linux.dev, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 29, 2023 at 11:38=E2=80=AFPM Dipen Patel <dipenp@nvidia.com> wr=
ote:
>
> On 9/11/23 2:44 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Using any of the GPIO interfaces using the global numberspace is
> > deprecated. Make it clear in the comment.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > This was part of a wider series but since this is independent, I'm send=
ing
> > it separately.
> >
> >  drivers/hte/hte-tegra194.c | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> > index 6fe6897047ac..9fd3c00ff695 100644
> > --- a/drivers/hte/hte-tegra194.c
> > +++ b/drivers/hte/hte-tegra194.c
> > @@ -407,12 +407,15 @@ static int tegra_hte_line_xlate(struct hte_chip *=
gc,
> >               return -EINVAL;
> >
> >       /*
> > +      * GPIO consumers can access GPIOs in two ways:
> >        *
> > -      * There are two paths GPIO consumers can take as follows:
> > -      * 1) The consumer (gpiolib-cdev for example) which uses GPIO glo=
bal
> > -      * number which gets assigned run time.
> > -      * 2) The consumer passing GPIO from the DT which is assigned
> > -      * statically for example by using TEGRA194_AON_GPIO gpio DT bind=
ing.
> > +      * 1) Using the global GPIO numberspace.
> > +      *
> > +      * This is the old, now DEPRECATED method and should not be used =
in
> > +      * new code. TODO: Check if tegra is even concerned by this.
> This use case is to do namespace mapping from gpio subsystem to hte. Few =
doubts:
> 1. What does deprecate mean here? Does gpio subsys not use global space a=
nymore?

It does but we don't want to expose this to external users in any way
anymore (and haven't to for years). This is what deprecated means.
Users should deal with opaque GPIO descriptors not global GPIO
numberspace.

> 2. If yes, what GPIO number is set when it comes from gpiolib-cdev, as ba=
sed on that I may have to
> reflect in the mapping, tegra194_aon_gpio_map for example.

Why DO you have to use a GPIO number though? If HTE needs just a
number from some HTE numberspace (which in itself may be unnecessary)
then why not just keep a local IDA for it? Do you have to know the
GPIOs internal numbering scheme to make it work?

Bart

> > +      *
> > +      * 2) Using GPIO descriptors that can be assigned to consumer dev=
ices
> > +      * using device-tree, ACPI or lookup tables.
> >        *
> >        * The code below addresses both the consumer use cases and maps =
into
> >        * HTE/GTE namespace.
>