Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <d3a8b9b0-b24c-a002-e77d-56380ee785a5@oracle.com>
Date:   Mon, 2 Oct 2023 10:51:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 03/21] fs/bdev: Add atomic write support info to statx
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>,
        Eric Biggers <ebiggers@kernel.org>
Cc:     axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org,
        chandan.babu@oracle.com, dchinner@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-api@vger.kernel.org,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20230929102726.2985188-1-john.g.garry@oracle.com>
 <20230929102726.2985188-4-john.g.garry@oracle.com>
 <20230929224922.GB11839@google.com>
 <b9c266d2-d5d6-4294-9a95-764641e295b4@acm.org>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <b9c266d2-d5d6-4294-9a95-764641e295b4@acm.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVluRG1WclJyMFpKc0VTZ2kySHBZVk4zcnVpUDQrWDdCeGVjVHhuR3Vvem9Z?=
 =?utf-8?B?TGE4djZhOVdVNHNSOVBjYXpnSmFDbjFrcWg2eCt0Z3VyQXV0QzErOGhCeWJM?=
 =?utf-8?B?Qnhrd0FTaTRWT2Y0MklTUnZzeWlMcGFJTHJsVUg5UW4rVDJFS0tRMlNoTDg0?=
 =?utf-8?B?VDJhckFHLzVRT3ArUzVBamFKY01uUFN1SWwrbDM3MVIvcHFPOE5DZ1lSWk55?=
 =?utf-8?B?SHBiT3hrR29ialEySTFDUm5SM3hQaGZ6VmttNnRaZkZGaDhzdDNQeXlwejdr?=
 =?utf-8?B?SXhQYzVoTzQ2YnFrTHJwM3RRWUxuSXRsd2xBa00ydG9GdHBXeHQ1Sm1KMGdD?=
 =?utf-8?B?UWRmOFhHYmJpTFByRHR4c013NGZkeFpuclkrSEx1clp6L2lJNUcwb0VzUGZo?=
 =?utf-8?B?eWdaZDhKMk83cjVQTDFDS2NvZHpKY3VRTUZpUVBsOGVKdTdUV01SK0lKNjY4?=
 =?utf-8?B?THpXSUtlRnhUUllSTEEwWlQ1RkpxcVU5Q05DYktnK0lBOUdpakxVbWttQXBC?=
 =?utf-8?B?ZzZaVEFCMVJCZVM1NTZGVm9GWWh0MDBKS2MwNVlDWU5TbGdGZ3pGZ2s2elZJ?=
 =?utf-8?B?VTdOUTczRFgzMllTOUw4YVJjVWdONnJFMDdFREdRbmJ6QzFYbThzNVNweE1T?=
 =?utf-8?B?RU1uWW14Nnd6bDBPZ3c0V2tIOThlbURyRHNVaTlNcmRwUC8weDFxNGUvNjZy?=
 =?utf-8?B?VzA0MDdxSzhzNkZqV2ZITU12SzRyKzRjL2NxSExKaWNzWXhueWZLQ0lEN0Jt?=
 =?utf-8?B?NnQ3NFVVdzFtOGNZUDFOZ0Q3WTVOSUZmRmFqZW5pTkI3OGg4dncwU1RRdWVk?=
 =?utf-8?B?UE9jRytKNTFQaXdOaGRDbXE3MTAySk1MSXZldlRpbXhTc05FZEhUVDNndTQz?=
 =?utf-8?B?ZUh5UjBlV1dNNy9tWlBUSWRSajZ2MEVJZmZSSWRxYjJEMUlGcVBPRVJjcTNn?=
 =?utf-8?B?Sml4TFBjQXBZcVZuc0xlMm1rK1pVajczR0ZaY0lNVUY2aGtjaGVXMUNsOUZy?=
 =?utf-8?B?WjdiK29EZXBFMlZzTVN2NEJENXg2T3A3QW0rbjBLUkgxVUIyQWp3YTg3aGJS?=
 =?utf-8?B?cUYxM0Q0akFyTGszNXlpbUt2d1ZOODAyZ1FpbXZZRTVEeDd1TUFZWHpvRU9S?=
 =?utf-8?B?WlZCR3llSkMwUDZzcW1kVFJrMUFkOXlrT1hoM1o2NWhMbm91OTh4OEJNeFBk?=
 =?utf-8?B?MDd6Tm1DQ3RtNmpTT1dMQzJqSGVUcDBZbGI3VGRGWUtlekQ3NUw3VkFhKzhw?=
 =?utf-8?B?M2VvcW5CRW16WDF3UVNyVVZvcDE4VmswaHJLZmNkOFFEbS9rVFkxS2tSN2pR?=
 =?utf-8?B?MjR3OVFqVUtJSzNnTFR5Z3Y1dTIrVVRwWlFpUWlmaWNVbWFoT1ZRcG9oTmRy?=
 =?utf-8?B?RVE4Z3A5UU9JWVl6RHhhdGptRjZTandDZGgvZG1jaWg3TkRIL1dvUitkWWpO?=
 =?utf-8?B?K0JHTnNkck5TcmZ0TnZmaDlSOWdnZTVYWnVXMjU4NEZqd2ZYWFliaTFTUzBL?=
 =?utf-8?B?enZVZFpYbDhwL1pZMk1XK05SZ1pweTBUNURuU05UVStNdDdwckF5L1hkbzUr?=
 =?utf-8?B?QjA3TkJ2TGVWai9ULy9KZEFKYnpJQXlBQjRhRW9SOHltcGs2SjhWaXZvUkRo?=
 =?utf-8?B?R1NWNHZITzNWaXEzUDJhcnh1eWM0NTVqZWorY3BWYi9MMlVWK1lWWWhaK0cy?=
 =?utf-8?B?SUZHKzBZRXZQUnBDQkF2MzYrUFNBS0cyWUNqVTE0enhXb1FtSHRqQmZYTWZq?=
 =?utf-8?B?Mmg3QWtJdS93U2xoMXFKbzU1Z1FrSmgzbWwweXhXamFGUWxiNlZyVkVMU0Nx?=
 =?utf-8?B?TThiNmQ1ZUFMdmNnSk9zMnd5SEtqZFY2SWRjMDZiVHB1bVhEOXJRaUYzMWxQ?=
 =?utf-8?B?Y25xS2ZLMkoxMUZYRnJIUE5aZHBKdkNSR3RlMW5wUVBvZEJjUkl1SGV0dFdZ?=
 =?utf-8?B?T0dFZENnREpzb3VPSDFhSkluWDJhdXZvcGRQTjlTVHN6QzZYWWIyUmM0eDRr?=
 =?utf-8?B?Znk0NWNkbUNUNFBnZUhjMTRlcDhDSXNZR1doTXpUeGY0TFo4T2MzSkVWeklS?=
 =?utf-8?B?Nzd2aXZpUmkydFEwRTQrUU9zYSt3Q1MrZ1AzM2ErMW42c29tR3pUSTlwL2FM?=
 =?utf-8?Q?9ZR2XeTn3knHr5RRFDs4svvpI?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bE15dXdMVzVoU3c1eGpCQzhpeE1YZktUdElZUWZmYUJqNWRieHkzWTFPZ2xq?=
 =?utf-8?B?enFETm5ML1FwVjkwMWtFa2xvSWZpbVhoVXNrTmtKbXlPTWMrT1N5emVFVS9O?=
 =?utf-8?B?YWZkSjJCQUFBOU94bm9rMFQ5TGRUbDNyYkdnbEEwY1l3dHZKaUNkelQ2ZUNh?=
 =?utf-8?B?MGZlUFgzakVJdGg2V1YwZFdMeXJRV0l4bHR0dnQ4M2pjNlFVL3kxVUdKeVhk?=
 =?utf-8?B?MjRiem5NNnRHNktMTTN1OGdWK0NoZG15dk9mdGprdlpub2xZM1dla0RtK0kv?=
 =?utf-8?B?WDlTSytyRFN0Wjg4UEVsZFRlTWFmVGt2Z295a1NWZStRMERxM3k2bHhLYnly?=
 =?utf-8?B?WG92VzVzS2prQkNMOUFVcE1CaVc2RktLN2duaCs4YlRWZGlzWElSQk53VDBQ?=
 =?utf-8?B?cHptR244U001bmZIZVgwMEZjVW1QZkVnUEF2MG13NnM4WUFZTDVpSmV1QkR5?=
 =?utf-8?B?S3BPdktsa1RJTzluSUUrTFIrNXJyY3liYVB4d3ZGNTdYRVFTR2xGdWNHSkpn?=
 =?utf-8?B?aGhYTnNKQUozOWhUTHc1UEpxdVExRDhSb1Y0Q0lSNWhjMW43Q2N6Q0hSR1Vu?=
 =?utf-8?B?bW5rY2t6eXI3S2dyWnJsOTFYeEwxeXpWZTk0TmNuMDRjMXZBem9yNlNRaHpJ?=
 =?utf-8?B?dm12ZUdoYVJxTFlYOGg5ZzFnOU5JWDdDTHlra0FOdisvRE53N1BJSGxXRGJl?=
 =?utf-8?B?aVRaY1N0SVRpSndYRUY3NE56TGhDNDdSWE02RDliZGkyZkxpa3k1dEF4ZWJj?=
 =?utf-8?B?ZGNibEZiYjZFeHh5VjhFTytwa2ppUlVRa3g3SlhQcktwME10S2V3WDdESmo0?=
 =?utf-8?B?RjdhRGJ4WWg2RVBQcGRaR3RCZ1F6ZUgxMDVZSW0vVDZCVW8yd01XUE82MTgy?=
 =?utf-8?B?T3dyeHJSb1E1WkJ1T3JPQU5nT3R1SHVXVUlWVnEwbnpxS0VVL2NaYVR0YTVE?=
 =?utf-8?B?SmFXMUJlZXFENGJYdllKcXVEM2NlMGRlN2ZmZFhIc1l0dHN6N0ZzOVNBWE9D?=
 =?utf-8?B?dlBCZ1M5QnpNcTVwZHNjSVB3V290RTBMNHJCVjJIRmZBbFA3ZFAxNEdHTHF3?=
 =?utf-8?B?dm9majZEMmllWCt2aEtmRDVqZnFtTmFYWk5zUXRFdmVISzlHSEh6M0dxeTMy?=
 =?utf-8?B?TFFma3FndTk5VjFXSjhyZnpURmp6YzhMYXZKTWFsK0QybVFiU0FwZVQxYkdX?=
 =?utf-8?B?VnVhZWc0ayt6OXVxcW1jRFZrN0xvcE41ejR5dW9QeUgrcXNzVmVtTVJwbVNB?=
 =?utf-8?B?eW93YzNCbUV5OGhJcEdQL0I2Zm80dERXdFR5STNSN2YxYUFURnRUcGo3aWZR?=
 =?utf-8?B?SEw1ek5jN25LQ1BGYnRnWnZndk92QkpDK3htVy9MN3JJanJWZ1NqdWVOY0FN?=
 =?utf-8?B?dWk3TlB6R3lNTFVweFNWTlNBd25mdXdQU0xzOWtWWVdPTGtSZkc1WFlMUkI4?=
 =?utf-8?B?Q2ZUelZIQ0tPSHRWSzYvNGZrdHlDODdraVYycEhUaEhHZVltQnp0T1h1bGEr?=
 =?utf-8?Q?VP/KFA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cc33479-68a5-49f3-ccaf-08dbc32d2e6e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 09:51:42.5804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F9yLnI5HdSQ1Q+X5rp5aMBSm0/dHLgYWGnYegHETYerQdxK0y1RTcSxMKj+rgboMQuJDPZkhPIlrpjstGhHrEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6855
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-02_03,2023-09-28_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310020072
X-Proofpoint-GUID: gobsr6150qKNK-asCfwGgfnMvqbRxr0f
X-Proofpoint-ORIG-GUID: gobsr6150qKNK-asCfwGgfnMvqbRxr0f
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:52:22 -0700 (PDT)

On 01/10/2023 14:23, Bart Van Assche wrote:
> On 9/29/23 15:49, Eric Biggers wrote:
>> On Fri, Sep 29, 2023 at 10:27:08AM +0000, John Garry wrote:
>>> diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
>>> index 7cab2c65d3d7..c99d7cac2aa6 100644
>>> --- a/include/uapi/linux/stat.h
>>> +++ b/include/uapi/linux/stat.h
>>> @@ -127,7 +127,10 @@ struct statx {
>>>       __u32    stx_dio_mem_align;    /* Memory buffer alignment for 
>>> direct I/O */
>>>       __u32    stx_dio_offset_align;    /* File offset alignment for 
>>> direct I/O */
>>>       /* 0xa0 */
>>> -    __u64    __spare3[12];    /* Spare space for future expansion */
>>> +    __u32    stx_atomic_write_unit_max;
>>> +    __u32    stx_atomic_write_unit_min;
>>
>> Maybe min first and then max?  That seems a bit more natural, and a 
>> lot of the
>> code you've written handle them in that order.

ok, I think it's fine to reorder

>>
>>> +#define STATX_ATTR_WRITE_ATOMIC        0x00400000 /* File supports 
>>> atomic write operations */
>>
>> How would this differ from stx_atomic_write_unit_min != 0?

Yeah, I suppose that we can just not set this for the case of 
stx_atomic_write_unit_min == 0.

> 
> Is it even possible that stx_atomic_write_unit_min == 0? My understanding
> is that all Linux filesystems rely on the assumption that writing a single
> logical block either succeeds or does not happen, even if a power failure
> occurs between writing and reading a logical block.
> 

Maybe they do rely on this, but is it particularly interesting?

BTW, I would not like to provide assurances that every storage media 
produced writes logical blocks atomically.

Thanks,
John