Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <a65a8eb8-8889-051b-f46b-b797ed91e0b0@redhat.com>
Date:   Mon, 2 Oct 2023 13:15:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] mm/gup: Clean up errors in gup.c
Content-Language: en-US
To:     KaiLong Wang <wangkailong@jari.cn>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <1748b504.8b0.18ad9d487ae.Coremail.wangkailong@jari.cn>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <1748b504.8b0.18ad9d487ae.Coremail.wangkailong@jari.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28.09.23 05:28, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: else should follow close brace '}'
> 
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
>   mm/gup.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 2f8a2d89fde1..aed327450250 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1480,8 +1480,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
>   			return -EAGAIN;
>   		must_unlock = true;
>   		*locked = 1;
> -	}
> -	else
> +	} else
>   		mmap_assert_locked(mm);
>   
>   	if (flags & FOLL_PIN)

Please see Documentation/process/coding-style.rst "3) Placing Braces and 
Spaces"

-- 
Cheers,

David / dhildenb