Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1285775rdb; Mon, 2 Oct 2023 05:18:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEE5Y+j5mNfOKQofh3ZSbXoWy8wFZQ0peO9eVXUzQHDnG0s4ugtv2RqgqH+Ui6AzKgOfnQ9 X-Received: by 2002:a17:90b:3143:b0:279:7963:cdf2 with SMTP id ip3-20020a17090b314300b002797963cdf2mr1887531pjb.0.1696249085313; Mon, 02 Oct 2023 05:18:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696249085; cv=none; d=google.com; s=arc-20160816; b=wxWcZBQ64gbM5Fq6Rzxa8mXgw08aWAao4X3v5FsijGBocvL0OpayNWIYf/ZsFc7ikv EL2i0myvQ9/sxy1ByzIhPZjdlARmII9xsaNCrHqfYYYG8rQkm1jlarrqikp7GXLMaUJN /wiqVW5dS/IkOPuSwg2FFTfDJkbv+ATEBCf6loiKUoEfDczMVHGxooQl8R8QHTP4AEcR 6vCUVMmWCtH9iI8h3bilDB1YTzgV/ql4IomOwK1WlB0QT5FUmdVI3Sw5LpASSdZoPy86 xH595itvLIoDLl93c1hSCnUdqHO9qFRooZW36x6Pyqwc3Q6niWHFCggWpn8T1igfggod 5x2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=htFAGJ9TrXMR/6/2q1/h4WxAnShxZaDMp5wIYbLnUIE=; fh=0zBAjxShfumhVJgCQ7/PrZqZq2D8mhtAJK1GC38L6Jc=; b=XZT7uT90dDVDdJLThXOazuG54tKFGmYYJ9ULn118jKngdqm5rBcAE975qmPqkF7a1X 4LTbs3xfxwe6ONSSNFj2syBLZWtrJkRS3u0TLUxXOYnEOpFh/nAOQO5agdb/joB7NfnR ABf0lLh4QGr/rJEW9j9ZXSVCHFlG7tLhW5fWRZhg58QG3tffswLZ4UhEKZ+MikJDY684 WWlLgzVMg65b5m/TlCxKOjUYqsKMR4YbzblJNSjckzhKax5akHzE/VPo1utN/DyoQsBd bJKiQfvg80D3igvMf7q0w18z4VqLCDkDIAgecawIdHoCL2EVvNHGPAVyU9xpSBlckx7q b2oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aliqrT7h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ha18-20020a17090af3d200b00278f2f6b412si7289490pjb.164.2023.10.02.05.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 05:18:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aliqrT7h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8667F805E435; Mon, 2 Oct 2023 02:49:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236232AbjJBJsa (ORCPT + 99 others); Mon, 2 Oct 2023 05:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236129AbjJBJs1 (ORCPT ); Mon, 2 Oct 2023 05:48:27 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 383B2A7; Mon, 2 Oct 2023 02:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240105; x=1727776105; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IZ04flaM+gh3eNQmfe1Szfitj8qEmKU9aHqincz+DA8=; b=aliqrT7hEAkrWoMbcLeZvuqY/WHOimajtWIr2xigj1XvKioxC67PmtDm /RQULfVmX6rtwHo3aXOJXzWQMizKNLQPAkZAQR5XigMvAbuFcvvCoQ3o0 Ds/hr44vB0LA7ScIvfWkxlpKbF2GFa6Vo2YSRqWHPAffgEt+U1d+pxBRq 87yaC29rknLWzuxCfZbgT6sFtryHHdIt3c8n3ZYxRkT1ssUkoopVWEdKp v4GiAlJDQ04PREmP2r9tazVi37SCToJP/bzhjbnjs0mezkE4v0eWowZrC btwREw/dnOMT119L5Mrn/bLsQzdD88kCz4ciMeGRyMgOlkkC35YBJzlIF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="413523698" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="413523698" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="874301805" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="874301805" Received: from aanantha-mobl.gar.corp.intel.com (HELO localhost) ([10.251.221.191]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:21 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Shuah Khan , Reinette Chatre , =?UTF-8?q?Maciej=20Wiecz=C3=B3r-Retman?= , Shaopeng Tan Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v4 0/7] selftests/resctrl: Fixes to failing tests Date: Mon, 2 Oct 2023 12:48:06 +0300 Message-Id: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:49:07 -0700 (PDT) Fix four issues with resctrl selftests. The signal handling fix became necessary after the mount/umount fixes and the uninitialized member bug was discovered during the review. The other two came up when I ran resctrl selftests across the server fleet in our lab to validate the upcoming CAT test rewrite (the rewrite is not part of this series). These are developed and should apply cleanly at least on top the benchmark cleanup series (might apply cleanly also w/o the benchmark series, I didn't test). v4: - Use func(void) for functions taking no arguments - Correct Fixes tag formatting v3: - Add fix to uninitialized sa_flags - Handle ksft_exit_fail_msg() in per test functions - Make signal handler register fails to also exit - Improve changelogs v2: - Include patch to move _GNU_SOURCE to Makefile to allow normal #include placement - Rework the signal register/unregister into patch to use helpers - Fixed incorrect function parameter description - Use return !!res to avoid confusing implicit boolean conversion - Improve MBA/MBM success bound patch's changelog - Tweak Cc: stable dependencies (make it a chain). Ilpo Järvinen (7): selftests/resctrl: Fix uninitialized .sa_flags selftests/resctrl: Extend signal handler coverage to unmount on receiving signal selftests/resctrl: Remove duplicate feature check from CMT test selftests/resctrl: Move _GNU_SOURCE define into Makefile selftests/resctrl: Refactor feature check to use resource and feature name selftests/resctrl: Fix feature checks selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/cat_test.c | 8 -- tools/testing/selftests/resctrl/cmt_test.c | 3 - tools/testing/selftests/resctrl/mba_test.c | 2 +- tools/testing/selftests/resctrl/mbm_test.c | 2 +- tools/testing/selftests/resctrl/resctrl.h | 7 +- .../testing/selftests/resctrl/resctrl_tests.c | 82 ++++++++++++------- tools/testing/selftests/resctrl/resctrl_val.c | 26 +++--- tools/testing/selftests/resctrl/resctrlfs.c | 69 ++++++---------- 9 files changed, 97 insertions(+), 104 deletions(-) -- 2.30.2