Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1317731rdb; Mon, 2 Oct 2023 06:13:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVNFZOlmrjTiTjsCqbWKOeQDwxUh3ydRVJ4dPMYO9/PUJbDw9uZY5Xf5Dzpbae+ym2+Oyt X-Received: by 2002:a05:6a00:139c:b0:68b:e29c:b69 with SMTP id t28-20020a056a00139c00b0068be29c0b69mr18225750pfg.9.1696252414150; Mon, 02 Oct 2023 06:13:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696252414; cv=none; d=google.com; s=arc-20160816; b=wjntoi/9H+dCLpTDoQPe+ji1u+WTjTMcPxtF/WXXHU6kD50ZglpsNyRGDICvj+cMl8 +Tp10agyK59OM320i6+6txSzwDjQEDi1F6yd5i3IK0bXCnKNVilwxMyqcqex+xcFYh5w xI8Ly+yHqU8cf3Wr+LvlE+HBWeHIk4LDqkTj+oiGvw/7DuJIWWCpb08+iLk7u47ZVuLZ g8ID7ENNg4KdnjDXwkVd73HLvSFIIFM5OytBVUumtlnVbYVrl9Ll1CuqWJhBVe5R3dXo LFwpFUJYDfVNH2cKP7SYU1dnwqngYQthRc7gCeS2sZ0W9IIVK7qD6NFkNupxCGZxKDPL GWpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=yQY2i+vSoxbuYAF7vQ9wW6HahcEbMKsvXUOSPTlVVRU=; fh=tlnZ2yo4nyt3FQRlUKgabQx/g+3AGOPWb5gZFhtzrjo=; b=Hzntir3plMhSK/1mn+uKaAQ5LGIJJKaZ20RZL8ssvg+Fx/rnxqJzEQ2WitDLI5rO2N 9aKqvRtwjXK9QVBn4XECR6bqQAgdMY8aaDqrODv+qoEoe7PlsvNffw0rFooHgktNpei7 pilzlWwIpblT987/01ZSkjiY3X0FKJjCB23n8+0DX3uhJuZz/CqjfN52UYsVoj/tucey 1fC6pSajRixMdPfoX0C7yqzkpk4JQUby2g5Ox3G/7PJYmNxyNTmycnRtp6yeafjr0wOj 2ly7rtrG7EhADQafrxM1gzZMcGiQEPF7tznvSbc6ldMaT4LVds78IE+4P2m0RKOyJxqL DK3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IY5UKajN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id s20-20020a656454000000b00578db71451fsi26660520pgv.501.2023.10.02.06.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 06:13:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IY5UKajN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id AECCD803D5AD; Mon, 2 Oct 2023 01:59:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235953AbjJBI7U (ORCPT + 99 others); Mon, 2 Oct 2023 04:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235950AbjJBI7T (ORCPT ); Mon, 2 Oct 2023 04:59:19 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 544F4E9 for ; Mon, 2 Oct 2023 01:59:14 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-59f6492b415so37132557b3.0 for ; Mon, 02 Oct 2023 01:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696237153; x=1696841953; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yQY2i+vSoxbuYAF7vQ9wW6HahcEbMKsvXUOSPTlVVRU=; b=IY5UKajNFvwmmEPjpibdfnt0QLYRQiMwvTxFJ2vIDWUJjWV4ZLE4mcTWGKnlQ65IgK y8o8MMaItd1KfF8tV2Nm7qjHKathxhHul4MrT3FlluCHXwNY0JAtN5GdjgiEf2kVq+Op qXHN4JMMIuJgLMqGvd7LioqDNIOxA+2zqXUF1YWlB7B1OnOzn5+fAk0BOQQgQKy/SEYj qICzC1jxH6TlEPxrsZKaySloQ/qnBuS5jICxQwiiF9Wkoanj98q59tfGxcLagsFLTNrq 0SQlBbI2h3ljqehAVPtqKALYZaLIW4A/Aw7K5b0TMdeGtqN2ev+LE9x/5xVlX8P4HKA3 3Q3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696237153; x=1696841953; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yQY2i+vSoxbuYAF7vQ9wW6HahcEbMKsvXUOSPTlVVRU=; b=TpIaKpfflzhN90kJ9ujKExUp9Z3s2VB+J8hNxs+bmGMoUwZgv0y2Z9glnJTgmWI4r4 wiZ7k2pL8leN6KeF3N/9DYeq+Rc30NZVenBiQWmEzDQ2LARPjaAb/NSMWQgCqnUse2p0 1bz9n6gRa0yOjf0ESLDOvLs1jZzZuh0kCrAGR9YLuw2j2vZrUdjYfFPrsEOG/MB1Al2H QUDvnSUXiX0F4+fooiuf7cM5fqyMaPAsCzZoO5XycAkh6XNNXJaPSXmtTjbKWwQtfkuL IqAYAeYCgBeT91E+PzojO5E7zsd7pCIR31OgHIaRpt6jHRfMzNImHmxQACxkUInLtASK 51vw== X-Gm-Message-State: AOJu0YwGhWBsrd6uIQdqsWe+eGsX5ho4FU/N5QXChEJPinH8DUuQ1gqJ g6tCol8zcMmMocRLaGiE0rMN7YZN2X7bdkFT0RVOnQ== X-Received: by 2002:a81:4e52:0:b0:59f:6440:7eff with SMTP id c79-20020a814e52000000b0059f64407effmr11888090ywb.15.1696237153462; Mon, 02 Oct 2023 01:59:13 -0700 (PDT) MIME-Version: 1.0 References: <20231001-pxa-gpio-v4-0-0f3b975e6ed5@skole.hr> <20231001-pxa-gpio-v4-6-0f3b975e6ed5@skole.hr> In-Reply-To: <20231001-pxa-gpio-v4-6-0f3b975e6ed5@skole.hr> From: Linus Walleij Date: Mon, 2 Oct 2023 10:59:02 +0200 Message-ID: Subject: Re: [PATCH RFC v4 6/6] input: ads7846: Move wait_for_sync() logic to driver To: =?UTF-8?Q?Duje_Mihanovi=C4=87?= Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Alan Stern , Greg Kroah-Hartman , Bartosz Golaszewski , Andy Shevchenko , Dmitry Torokhov , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 01:59:54 -0700 (PDT) On Sun, Oct 1, 2023 at 4:13=E2=80=AFPM Duje Mihanovi=C4=87 wrote: > If this code is left in the board file, the sync GPIO would have to be > separated into another lookup table during conversion to the GPIO > descriptor API (which is also done in this patch). > > The only user of this code (Sharp Spitz) is also converted in this > patch. > > Signed-off-by: Duje Mihanovi=C4=87 Looking good! With Andy's nits fixed: Reviewed-by: Linus Walleij Yours, Linus Walleij