Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <048d9715-9cb2-4bc0-b8b0-5e30a0db54c7@leemhuis.info>
Date:   Mon, 2 Oct 2023 16:13:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
Content-Language: en-US, de-DE
To:     Mario Limonciello <mario.limonciello@amd.com>,
        Mark Brown <broonie@kernel.org>,
        Linux regressions mailing list <regressions@lists.linux.dev>
Cc:     Sven Frotscher <sven.frotscher@gmail.com>, git@augustwikerfors.se,
        alsa-devel@alsa-project.org, lgirdwood@gmail.com,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Takashi Iwai <tiwai@suse.com>
References: <20230927223758.18870-1-sven.frotscher@gmail.com>
 <46560887-0b6e-42ac-96c3-b4dbc1d7cb61@leemhuis.info>
 <4fa7d39d-dc34-4550-97fa-2b089f364cca@sirena.org.uk>
 <0a3feafc-b843-420a-9b04-c835f8210c1a@amd.com>
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@leemhuis.info>
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
In-Reply-To: <0a3feafc-b843-420a-9b04-c835f8210c1a@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 02.10.23 15:47, Mario Limonciello wrote:
> On 10/2/2023 06:52, Mark Brown wrote:
>> On Mon, Oct 02, 2023 at 11:32:48AM +0200, Linux regression tracking
>> (Thorsten Leemhuis) wrote:
>>
>>> Makes me wonder: How many more such quirk entries will be needed? Will
>>> we have all machines listed soon, or do we expect that future Lenovo
>>> hardware will need entries as well? If it's the latter: are quirks
>>> really the right solution here, or do they just hide some bug or then
>>> need for code that automatically handles things?
>>
>> x86 firmware descriptions are terrible, it's just an endless procession
>> of quirks.  The model for ACPI is not to describe key information in the
>> kernel and instead on Windows load device specific information from
>> separately supplied tables.  On Linux that translates into these endless
>> quirks, on Windows it's platform specific drivers for otherwise generic
>> audio hardware.
> 
> I knew there was a TON of "82" prefix systems from Lenovo so it was an
> educated guess that all of them needed DMIC support.  This was incorrect
> because one of them didn't have DMIC and that caused a no mic support
> problem on that system.
> 
> So in the case of this seemingly endless list of systems being added to
> enable DMIC support Mark is right, Windows does it differently.

Now I understand things better, many thx. But please allow me one more
question from the cheap seats:

Seems before c008323fe361 things worked for a lot of systems for about
one year thx to 2232b2dd8cd4 (which added the wide "82" prefix quirk).
We then made that one machine work with c008323fe361, but broke a lot of
others with it that now need to be fixed with additional quirks; that
"TON of 82 prefix systems" sounds like we might not be close to the end
of that journey.

So can't we just do it the other way around and assume DMIC support on
Lenovo 82* machines, except on those where we know it to cause trouble?

Again: you are the experts here. If you are positive that we soon got
all machines covered where c008323fe361 causes a regression, then I
guess it's best to continue the patch we're on.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.