Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1401197rdb; Mon, 2 Oct 2023 08:28:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqq5eHCn7BY1EwXjjN1cs6/oc+ZSoWb7RJM7SIorO/ygfkcuaTYdt8Oxrz9Ly90MkatjTP X-Received: by 2002:a05:6870:d0c1:b0:1d6:567b:79aa with SMTP id k1-20020a056870d0c100b001d6567b79aamr14093085oaa.56.1696260482558; Mon, 02 Oct 2023 08:28:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696260482; cv=none; d=google.com; s=arc-20160816; b=gmpldcJ36/RRTyG6IAweZNzQl3LxDK2lnx+00UcQRQpa4UYObz7Areo/b082yUsRrL d5HuatfmG7wz8mi30hiDZrFS2orUbepJY+PX67zImb0X3QU18/22PPDEJas28xbI39H8 g2B0y/F4UMjk0RVWB3C49ASgX7XzOW6azaFHV65NH+vcWiMR31CwZeF3a2pjKhY4+5aq IDnVk+pmuSg7EFSM9AIjPdHCQ3EDaps5HH4W5E4t+0Zy7nzzD5DkBAAzFLf6SJ3QtTvV oaE4T6HEOQWhLkh0shP0p0G06stIhUFZEyKsMuhgmKNRHocvuaDIOoBYROndZlhzAvlJ hDiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=IqY0tTLGIJQ18zFwX414ENz+V0Kp0t8ulGXGMZq6XWs=; fh=mLGqrISY6uD/gwcNS0tD3RxULtxRkN1IzX72HeVkz8I=; b=GnW/122nlSVnFuOCKMdumIfFQ+xq1sUVFytCOLKP/BYRC78Oo+4OiWgYJ0YYbLmkVt lpYpmgib/AwOt0m487qhdwJIJ1jasA7ZKIdJCmlUj69mPoVOHNklLGCAAnkYqNRKBYcr LSxr/FbE7/QbPMZ1wSig4WE/OipIgEqiTO0yrl2CVUIaMP7cfOaWIwf5KE665Zl4AiL7 hB1oiWf1jse1QVHc6qfkdGiDcykO58bgft6cNyLBnuM117ix0TMXgKg02SRnUnAiaEPw 8Kk5kxMKYQrgyh1oaMIQC35XIqKAlOsT/SnXxHr8Qtnmn5djF8vIxqgWVB+FXOMT/udC UCCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z190-20020a6333c7000000b00565e9c3a308si13543714pgz.788.2023.10.02.08.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 08:28:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 875FF80BC531; Mon, 2 Oct 2023 08:04:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237937AbjJBPDz (ORCPT + 99 others); Mon, 2 Oct 2023 11:03:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237940AbjJBPDx (ORCPT ); Mon, 2 Oct 2023 11:03:53 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D731C139; Mon, 2 Oct 2023 08:03:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 119F9C15; Mon, 2 Oct 2023 08:04:22 -0700 (PDT) Received: from [10.57.1.112] (unknown [10.57.1.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C75D93F762; Mon, 2 Oct 2023 08:03:41 -0700 (PDT) Message-ID: <0f3ac22f-59c9-6e04-c824-dd486c20bf37@arm.com> Date: Mon, 2 Oct 2023 16:03:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/7] coresight: tmc-etr: Add support to use reserved trace memory Content-Language: en-US To: Linu Cherian Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, sgoutham@marvell.com, gcherian@marvell.com, Anil Kumar Reddy , suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org References: <20230929133754.857678-1-lcherian@marvell.com> <20230929133754.857678-3-lcherian@marvell.com> From: James Clark In-Reply-To: <20230929133754.857678-3-lcherian@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 02 Oct 2023 08:04:10 -0700 (PDT) On 29/09/2023 14:37, Linu Cherian wrote: > Add support to use reserved memory for coresight ETR trace buffer. > > Introduce a new ETR buffer mode called ETR_MODE_RESRV, which > becomes available when ETR device tree node is supplied with a valid > reserved memory region. > > ETR_MODE_RESRV can be selected only by explicit user request. > > $ echo resrv >/sys/bus/coresight/devices/tmc_etr/buf_mode_preferred > > Signed-off-by: Anil Kumar Reddy > Signed-off-by: Linu Cherian > --- > .../hwtracing/coresight/coresight-tmc-core.c | 51 +++++++++++ > .../hwtracing/coresight/coresight-tmc-etr.c | 87 ++++++++++++++++++- > drivers/hwtracing/coresight/coresight-tmc.h | 24 +++++ > 3 files changed, 161 insertions(+), 1 deletion(-) [...] > > +static void tmc_get_reserved_region(struct device *parent) > +{ > + struct tmc_drvdata *drvdata = dev_get_drvdata(parent); > + struct device_node *node; > + struct resource res; > + int rc; > + > + node = tmc_get_region_byname(parent->of_node, "tracedata-mem"); Is this a typo? The DT commit says the region is called "trace-mem". And "metadata-mem" for the other region, but that one matches the other call to tmc_get_region_byname() added in the later commit. > + if (IS_ERR_OR_NULL(node)) { > + dev_dbg(parent, "No reserved trace buffer specified\n"); > + goto out; > + } > +