Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1415319rdb; Mon, 2 Oct 2023 08:52:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcckrHRijO2561+U3CIomCXn8WkQrBOI34X4CP+m/BKS/bzW5RbXWBx9dm2j1TiSOTGJ7D X-Received: by 2002:a05:6a00:a1f:b0:68e:3bc8:17d1 with SMTP id p31-20020a056a000a1f00b0068e3bc817d1mr12576273pfh.29.1696261960367; Mon, 02 Oct 2023 08:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696261960; cv=none; d=google.com; s=arc-20160816; b=KpCyFVKZ98n3et/gC6bo5jZKl/m2sN9u/V34giUBYh/wUpiT96QDybKCcsX7hdaeLI c9ysFHsuBzAeFpsTWtHFoSKswJRVUDC1UiYiNiRHKyt23Ky4MzldMzgUJiFYLPFoayxG nPNZF8o6gRmEkPlExZTwplC6/l3wXPFztyMNPWXa50Glh8zTiZkHXCRD+xbZXr7p+Ica J3ygHxh6jTviUhiXrf3M3BGGChoNQ4I4A5z3hPkcP6sR1Kw6woiFD+q3MiyEJR0y6bRJ cIxed+UFN8KucmOUR8wXKytn0K1SJ6u4UsvPyBdjqGlVH8UkEawTZndRoQ0uWKFDECkM qPCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=uJ0a0wNMOXJ/wn0GPhC54YTgs4tNe5cP6aYLiYXKba8=; fh=+hamb1I22Dnk1nyX5jCFBcKeTi2uW/LpZg//LVwWdtw=; b=ELBuhqDKy+qQnP2kSp/IRBITgZ2UIuecJsU9un2ohWMsAClljiFHJQb3sBY0h1iuOh cjYVdLqXqWFCTg2Twwf8u4J1kwd6m7PNEaMt11zn+QsEan8p6lbqibTkE5J54NYt7/fX W7+P1CHz6qAWc9FeEHM6LgF97PwLXTTGFS1j66Jd20hMTPvFnj1/MQjI9laomiUrGzKf Vf+5CQRxC/mKi330lBBEmkbVxv1JrumMHz1a1Ux5bDYhuCJ0zaroSwWRhqMZ7vEc/Cn/ qE6GY3s1xkgJlHbQ85BuDYCkf0lI0bB4VNN9L/6TNHwB1r1VWa7HOKx7gwVLWAmuBxvW J52A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=iaaC3T9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id p20-20020a056a000b5400b00690bd178205si28770396pfo.215.2023.10.02.08.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 08:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=iaaC3T9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 83B4580ACB43; Mon, 2 Oct 2023 03:49:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236552AbjJBKtD (ORCPT + 99 others); Mon, 2 Oct 2023 06:49:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236547AbjJBKtC (ORCPT ); Mon, 2 Oct 2023 06:49:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 404DDAB; Mon, 2 Oct 2023 03:48:59 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6D6AC6607243; Mon, 2 Oct 2023 11:48:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1696243738; bh=7FCl16Mw64i/EfJ6OQlYS83PjShxYQyaVY0iisClkvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iaaC3T9MOdFWNSdt8GwXYT3PmeNwtdCQBBoj5cz7A3PFEyv6F1VIK6culpzUe0MkY gzLD0lPwDmSotUujazj0MwoM9+rTJYbEXKYW3KKB1V6PRQm4xElNUCsalQGLOpG2Qa wR3fhOvQikkkXUNHMf/ug8Zz2v/yNb9QcWiLW4bWT1auKzZXJamWTIHEqUKOKKZB1/ r8fRqvlTLdh5ydNeDwr0naOpXO7rF1MMVIHTUNhsyvXZEcCo45cTCeAr7adLKesTl5 U6a3TbF1v90MyBnmuKQvNgmYE4mONST5hJyu3brRkEWCKAQiJHzYSaE2gEymlXhZ5Z /3B+BDyVA2rug== Message-ID: <633d4544-e215-2742-a4c0-81698607e830@collabora.com> Date: Mon, 2 Oct 2023 12:48:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] media: mediatek: vcodec: Handle encoder vsi NULL pointer case Content-Language: en-US To: Irui Wang , Hans Verkuil , Mauro Carvalho Chehab , Matthias Brugger , nicolas.dufresne@collabora.com, Yunfei Dong Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Maoguang Meng References: <20230926101909.15030-1-irui.wang@mediatek.com> <20230926101909.15030-2-irui.wang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230926101909.15030-2-irui.wang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 03:49:07 -0700 (PDT) Il 26/09/23 12:19, Irui Wang ha scritto: > There will be a kernel null pointer exception if 'vsi' is NULL, check > 'vsi' is not NULL before assign it to encoder instance. > > Signed-off-by: Irui Wang Reviewed-by: AngeloGioacchino Del Regno