Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 2 Oct 2023 17:24:11 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
cc:     Hans de Goede <hdegoede@redhat.com>, markgross@kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        platform-driver-x86@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] platform/x86: ISST : Check major minor version
In-Reply-To: <daa44585c4a57b8823cb260d9ec9bd3f59f410c6.camel@linux.intel.com>
Message-ID: <4098d4a2-f672-3c72-5ddd-b397e2ed1465@linux.intel.com>
References: <20230925194338.966639-1-srinivas.pandruvada@linux.intel.com>  <20230925194338.966639-3-srinivas.pandruvada@linux.intel.com>  <f82fcfc9-eb41-56cb-93e1-abf9cf7413@linux.intel.com>  <72a2766bc7bb4f9d6b3d5f2ff114f0af1b6646a4.camel@linux.intel.com>
  <45625e9e-997b-eba1-413a-43a7d835feb@linux.intel.com> <daa44585c4a57b8823cb260d9ec9bd3f59f410c6.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1525224698-1696256654=:2459"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1525224698-1696256654=:2459
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 2 Oct 2023, srinivas pandruvada wrote:

> On Mon, 2023-10-02 at 16:49 +0300, Ilpo Järvinen wrote:
> > On Sat, 30 Sep 2023, srinivas pandruvada wrote:
> > 
> > > On Fri, 2023-09-29 at 17:28 +0300, Ilpo Järvinen wrote:
> > > > On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:
> > > > 
> > > > > Parse major and minor version number from the version field. If
> > > > > there
> > > > > is a mismatch for major version, exit from further processing
> > > > > for
> > > > > that
> > > > > domain.
> > > > > 
> > > > > If there is mismatch in minor version, driver continue to
> > > > > process
> > > > > with
> > > > > an error message.
> > > > 
> > > > This sentence sounds odd.
> > > What is the suggestion here?
> > 
> > These things sound wrong: It should be "continues"
> OK
> 
> >  but I also find "to 
> > process" odd when lacking what it processes.
> 
> Further processing means, whatever this driver is supposed to do. You
> don't want to fully explain again what this driver is doing.

Well, whatever. I'm not a native anyway so I cannot really be the defining 
authority how the language gets used so feel free to leave "to process" 
as is.

-- 
 i.

--8323329-1525224698-1696256654=:2459--