Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <9606020e-c322-fb6a-a6ca-96ade7aecf17@intel.com>
Date:   Mon, 2 Oct 2023 10:00:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 02/24] x86/resctrl: kfree() rmid_ptrs from
 rdtgroup_exit()
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-3-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-3-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlViOUJLTUl2RyttVjZidUVQNlpZREd4b0N6VDF1UTlSQUppQS9ha3pjNnk1?=
 =?utf-8?B?RFUwOVhNQ3A0NGFaSVplRW9VN3NHZ2ROdkluNXJ5cUlMOHFOV0R1eGVpeTcw?=
 =?utf-8?B?Y0dJQy9IdjFVVVczNXFSNER2K3pTemFuL0ZLaUFvQmIwVVBSYU1XOEZYS0V3?=
 =?utf-8?B?d1pFR0FGMWhCUVg5cUpPZlVsSWFQQ3FEdFV4UGVPQ3gxNXRxYnNwTTVaKzA0?=
 =?utf-8?B?SFRtSllRL1ZCRTAvM09WSit4TDc3aUIwM2RxMWlPRkxuWUZBMjJBSVdic25N?=
 =?utf-8?B?R1dETk9yV25NeDRoNUExc0loZzAzM1ViOWo5OWxiTlBxdk1EVDlKZHNEbC9r?=
 =?utf-8?B?NUJnWXE1eXhIMTVzSlM1dG8zK0tyT0xXMVoyQzYxcU02RkxHYWJIMU9iMDIw?=
 =?utf-8?B?c0dVSUlQZ3paVjNnU2NpNTIxVGk5cFBXS0UvdzVTNVAyczRveHZxTUVtSTRw?=
 =?utf-8?B?eno5eUlyUE5SL0JkRi9VYXBkUkZoUExqbkNmekRnb3k4aVltWGw3QkpMcWE5?=
 =?utf-8?B?SXBMMlJKV0NYdUhONFpDUjM3elBKRUFLdjQxendocnBWS3hpSlAzQ2Q3YlFN?=
 =?utf-8?B?c2lLL2lPL1Q0amh6L2d1YlgvWXloR3RqNmN3RURjTjdZVHR4ZjFKSnU5SUNQ?=
 =?utf-8?B?VFVsbVpSYmtjSGRENVF5KzVueHJENndBbHV0WXpwTEljdFdvTlUwZlJqSUxv?=
 =?utf-8?B?S09DS0dFMWFmOTVseWtpcUx4T0hCTFZ6MGJjMmlmT1RMUC8rQmdCN05sa0Fw?=
 =?utf-8?B?WWwzYkVic1hIaFJQVUwwS0xJclcvbVk2Szl0bk1SSlFyYmFsdVdYbkpISjdr?=
 =?utf-8?B?MDRmWmI2TTdacHBobUVGNGFqRU1vTk9kaDFydVhkdTRwU3UvNVRxWXlIWnRX?=
 =?utf-8?B?ZFBnZVlIMHV3ZlArMUw3cHJDUVJXT3d6d3dUZ0FIK0JDakRuZ0JFTkRSa2lT?=
 =?utf-8?B?dlgzQThaMXVxallMVjRCV0hLTGd5TG1zL1FYR1h0bmpFa3EyL0hBUy8ya0c1?=
 =?utf-8?B?SGVzbE0zMndlL1p2elYrSTFBK3VZeEo4cTBjWU4xT1prOVk1VE0rV3g3NExS?=
 =?utf-8?B?ajNqUE9oNVYrcXN2R3RSNmprZ1FkRHFEdkt4TnNHS3E0YTFZaFlLaUdzZVl6?=
 =?utf-8?B?STlaU0xiK3YvQU5RekFGWDZud015bGdMTDdzRnVhUko1N3Q4T2RzMXJwU0pI?=
 =?utf-8?B?WUhTZ2JHSlBSNTZVa1JXNUVYdEJxRFordlJpOFFMZ3JhN05vZVc1SVlsc3VN?=
 =?utf-8?B?eHQzUEV3MTBmWCtKMHZVVEV0MWdDRHV2R3F4NTZRZXA2emJTUTFrdm5Bc1Z6?=
 =?utf-8?B?VU11Mlc0UjNXU0E1dFRKbXR6Q1IwRHF0QzYzeXhjRHVVNDJwN3NYblJCRk8w?=
 =?utf-8?B?Tm5sTGNoa1Jib3FlWHVwZXBxb1M4WE02Szd1TVdGRjFCSk9XQlpSSjk2OHdM?=
 =?utf-8?B?bm1tVkxiTHE3U2FYTnNwQ0NCd0M4YUR6cVdtU081UHQ4TnVZSFdqRWliRmZF?=
 =?utf-8?B?OGVnNjBtNFdhTGxwZm9vekV5MTdRSGhRVHVjMnlrZWhpMHRBcmFOSGxZM2JM?=
 =?utf-8?B?NWpCTjMvNXdIRzQzVFBPS1A0WXgxOXhLbDQxUVB3Yzh3b2dCK1kra0NGclQ4?=
 =?utf-8?B?RC9kWllhR3BzdG43UEN4czJTSXdySWVicWEwSzVXWklWcFBObldVK1ZLWXVz?=
 =?utf-8?B?Z1ZJUG5nN2FtUm9CcmpDM01zNEpYRFVidEc2akdIb3F4Y1h6dGZvQ3BZeUxu?=
 =?utf-8?B?RzhQaFBFVkRSdEtld3RkaWNrRWdRb2EwVzZZSjFRdnUzQTk3ak9iTmhqR2N3?=
 =?utf-8?B?dGFpSnZETUtnYytjTUFGM2lmTG5lK242bmN0WTJlMGIvaUYrMGxkenR1VGQ0?=
 =?utf-8?B?Y0NHVysvWStzUkFJbnNmeVhUQVp4SnkxejNUL3VFZVk2WDh1RGo5clNrcXV5?=
 =?utf-8?B?S0IxRlRPeTN6NWJFTGkxZEdjZDkzb2FTdnJwYWRXUUxpNUhTaDNWRmVKNEtP?=
 =?utf-8?B?dE8wM1loay9Ka0NhUGdja0lwNXFDZmR2YnpQQ3JrbnRrTGowV1NqQTI5eGFQ?=
 =?utf-8?B?YW1aUkZpSXFqTzNVZkhiL25GZ215VGx2ZWJjSkJjRjV3UWt5SEdxdmhmbUZM?=
 =?utf-8?B?dmNxbi9Yc3NJRm5JdDVnYnlOUzdvL2JZTHNzUlh1Q21Ra1U5Qy9WM1lxSWQy?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f96788c4-06a1-4f57-bddc-08dbc3690d62
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 17:00:16.8587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LXzPbBrdSCp4hw8iwHtP3KDbuSW+T0tKrTVJetYWP/uwCWqEvJy912PBpQ4n/o2hiL4A5L7T1QAN78ihU1/alv2NoY479ybc62B71pqU+90=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6141
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 10:00:37 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 725344048f85..a2158c266e41 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -3867,6 +3867,11 @@ int __init rdtgroup_init(void)
>  
>  void __exit rdtgroup_exit(void)
>  {
> +	struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
> +
> +	if (r->mon_capable)
> +		resctrl_exit_mon_l3_config(r);
> +
>  	debugfs_remove_recursive(debugfs_resctrl);
>  	unregister_filesystem(&rdt_fs_type);
>  	sysfs_remove_mount_point(fs_kobj, "resctrl");

You did not respond to me when I requested that this be done differently [1].
Without a response letting me know the faults of my proposal or following the
recommendation I conclude that my feedback was ignored. 

Reinette 

[1] https://lore.kernel.org/lkml/1ccd6be5-1dbd-c4a5-659f-ae20761dcce7@intel.com/