Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        =?iso-8859-1?Q?Andr=E9_Apitzsch?= <git@apitzsch.eu>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error
Thread-Topic: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error
Thread-Index: AQHZ9IHazMX7YhLcF0uqntJC6sFjerA2PGKAgAAB24CAAADD4IAABRIAgAAATqA=
Date:   Mon, 2 Oct 2023 09:57:09 +0000
Message-ID: <OS0PR01MB5922036435F7B4E2DB83B9F386C5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20231001-ak_magnetometer-v1-1-09bf3b8798a3@apitzsch.eu>
 <20231002102745.0000540b@Huawei.com> <ZRqOn8tnJqvU22ex@smile.fi.intel.com>
 <OS0PR01MB5922C468BEF67BC2A19F87D286C5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
 <ZRqThAuMogtcMtHI@smile.fi.intel.com>
In-Reply-To: <ZRqThAuMogtcMtHI@smile.fi.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?EoXuCkTI0lKDVHeJ351dYsmGqFgxIX9MO6nVSMYYlt036Z/AcLA6tFJNai?=
 =?iso-8859-1?Q?FPL3lRkU/GhtasbsZWAcHizEHbGBZNTvPxLwtaJMm3Ko3L1kK5BJG8ZOTR?=
 =?iso-8859-1?Q?66PbyTW5rxJAv7mm28RXuVLlnPwtqjGD+pGVHuXGrE+4sBmadMM7BRdgvF?=
 =?iso-8859-1?Q?0sbbJywKCjqpaqhNeuCkiBN/zUFOqE/Eza+wMQ1eB2t134wRL8Brwp/XEd?=
 =?iso-8859-1?Q?wq9PmqmRsP8rURYsA0RA286F5jqi796M+mNFZbLgEDzfp3xKDaleuy19i1?=
 =?iso-8859-1?Q?l+mz/bONohRQACGHkiasiMqmui1i6z5DVUywTNmG3zLl2KgmRhGCqSYv40?=
 =?iso-8859-1?Q?fkzXUb5CE3X63SbBHnnrEpAPZ+88HY3RRCOTG0gLuAazALGj2ec+z3kyh9?=
 =?iso-8859-1?Q?4+MCXDG2I2XcHAWfaTKBBo+oRxV3ihbHiAkMm0s/xI+J9NFRv4VP7eGqLT?=
 =?iso-8859-1?Q?dUwH4OyrsrbO63+/kzgBh5dvQ6k0ikRUwXga4tMqe8sVdUCmTjLp8FZ+hr?=
 =?iso-8859-1?Q?O7Yq6weMTylZoWotytn6zOmq5LkDuGU61wpzcONYSrD5Up/r2FslZBo1cX?=
 =?iso-8859-1?Q?eCTqUdDLHjan1UzLdvPgu4S3ulc9ixZdLFTY+MU7/g1ADWRHxeNIq8mWGQ?=
 =?iso-8859-1?Q?FVYy7Teehh5gCMvbUBB5D7E9giitCiROCssUSSJg3lWnbDO4uQtcFqXuZt?=
 =?iso-8859-1?Q?BsrZFXYHBTbJ+OvewI9DPbBPp96T81xeT/2+ONr2y92vKLUAoqZ+cHvfLK?=
 =?iso-8859-1?Q?y5ticlEkQfbcZzAgGE8Rya58nBlmKBUFFVm1BUq18HdwYMTRjEBzhhds4R?=
 =?iso-8859-1?Q?cH4S+L0Mi9DbEmxq9HXImHMZzwLmQC+TJhBTj0zevAyzc6oLyW2Eq1zXW+?=
 =?iso-8859-1?Q?PfW1Do3SdEzBc2reJ1sNS4yE83gif7aQamBkILYO7jLMdMlKUnglr0I5zq?=
 =?iso-8859-1?Q?YatiZwLU6PVxWdGsyIbB5nGnKxd/uZHvgJlFHyI7W38XLFctayRrRPWfk5?=
 =?iso-8859-1?Q?UFHm3dVTOjC/aW5EFf6x6VXTKd7poVY2BFzGnRMTSb6aXu5kEz9LGzQwIJ?=
 =?iso-8859-1?Q?5aOLpn1i/qrFwGm+dlLrKbXJEfl6xbNRDVyg5rsvN9gz1k9iQqBM7huQA2?=
 =?iso-8859-1?Q?RZ7vI1lmXICjWSHBna8UxS5tYFaAUxkl/NMKygU1tzVYDHjvAKOjA0mPmX?=
 =?iso-8859-1?Q?ftJeeZGf8AhSYhYiHFxOqN89K9wPeIM+E9h+l1HKdqxvJKYQHvs13Ew85a?=
 =?iso-8859-1?Q?/yKA1DdyFyTf23jFcEW72N0chmxcJMTRxx4kbVeH6sShrhEAI9XZnjFm1g?=
 =?iso-8859-1?Q?wxJx05gFx0hQk6MovbyQpWqyt37veqyCdZKzD8KNlycCNvxsTolM5luL29?=
 =?iso-8859-1?Q?0TjzdxP4WjQxTuvtEFqnTTC82UOHFoUD5zunARNFXMGZVfKGccrqiqc5/T?=
 =?iso-8859-1?Q?XXLqv5zEIBw3LHpizD5rbtZRNClK6Qw4Aqds2J6W/g3AwQzHmhL5lHxkyf?=
 =?iso-8859-1?Q?RGs5ETMUQ7QdvoxCsGGBBGmD7ufp7uecl695YmRdgudy2r22vcUYvG8NGV?=
 =?iso-8859-1?Q?3/5c98bEzUAIGOExi79XARmI7POfSLn4KeA2FPUbPftKDavEH5+1Ine4/3?=
 =?iso-8859-1?Q?UoeE9LHc5sg1yPW2Q8jEddT0L+UmpzR/P8J8wd7hqsFvz0PkscD/ebBw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb882810-7b19-4dd3-b9e3-08dbc32df139
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 09:57:09.0542
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8Ol04CL0V4T5uEkVlrwk15ngCJQnd972uH/ODnKUGbrlmxxjcG3ibtA5LN+PiQBmwpqyEOJmxiq2zl+FUVhwAFfMqqKMYsPt3kov3Dr3oYY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9483
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:57:22 -0700 (PDT)

> Subject: Re: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device'
> error
>=20
> On Mon, Oct 02, 2023 at 09:38:17AM +0000, Biju Das wrote:
> > > On Mon, Oct 02, 2023 at 10:27:45AM +0100, Jonathan Cameron wrote:
> > > > On Sun, 1 Oct 2023 18:09:56 +0200
> > > > Andr=E9 Apitzsch <git@apitzsch.eu> wrote:
> > >
> > > > > Fixes: 4f9ea93afde1 ("iio: magnetometer: ak8975: Convert
> > > > > enum->pointer for data in the match tables")
> > >
> > > ^^^ (1)
>=20
> ...
>=20
> > > > So we need the spacer until someone converts this driver to use
> > > > pointers instead for both of and ACPI tables.
> > >
> > > Isn't it done by (1) which is in your tree?
> >
> > How (1) can trigger 'Unexpected device' error??
> > It returns match_data, and match_data has correct device type.
>=20
> How? The enum starts from 0 with a AKXXXX and ak_def_array starts from 0
> indexing, it's classical off-by-one, you got the driver data for a wrong
> chip.

Got it. I was about to reply. It just needs mapping as Andre did here.

Cheers,
Biju