Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1493157rdb; Mon, 2 Oct 2023 11:08:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNp9MTuWMH22Tss/K6I9UMnB/hylAwMtFZh1H838gA7E21UKFMQECsFd8oEvbHOPUcZ8Yp X-Received: by 2002:a05:6358:885:b0:142:f1d5:ef89 with SMTP id m5-20020a056358088500b00142f1d5ef89mr13370182rwj.5.1696270107799; Mon, 02 Oct 2023 11:08:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696270107; cv=none; d=google.com; s=arc-20160816; b=Fc7+ovxK1Jl7ya4jQxnAvoz7a4ZHjM6tnk3oFB2njghAPQSQJrPwWBwciZWhWiendu 3rulk50EOv1oCEdIIB+NyjLUSh9m395Guu9PNAC7JHE9IMdzGWnk5KhDy7M5bNRLDDud olOFQKfYiTGz6z1SVO06vMtfXbWMH5GuA8G+EjPqhLaGpT28zaIMAdt3dGd+dsv4NLMB jbyEFu6mSIr5UvGW09Djqs2mUCp+nIPlrxRRy7TGbF7XKPI7FhvzW4u8kEhBOuQvpsiB o7UVzNw5RaGozSA4em+3y2zxw4KOsf61cUmBAcU6dP68LNnFjIzgOwzPKAd4n/lASBDJ gN/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=H61TTlLnRLvbJVmdtxHoL38piKqaVD31VADHskFNRV0=; fh=+hamb1I22Dnk1nyX5jCFBcKeTi2uW/LpZg//LVwWdtw=; b=GRCbWaM10DEoaHSU/s/RhN2EV/VriA3g9mf8V3G8KhKX8YbexExIIWpCdXuEV3P26s UVOR1AmACozIif2djPubVtzvHx7QWImwwyOR7P/9Ced4tNdyGEfeiXYpeYqequZU8N1w MnFRZXj2Tn/gCj43oH6DB3JN8ZApqHkJUPD/YcR7ICgrhjVOd/BpEv4KHRkI5Dm2BPzD gJ4edd6UGwfRXQoIOUI+HJDzK1HKMnHwCepajCbrLVKbakXujlAsI7/8q6emzUc88JPy 1xQnj7pYRxaoElc8E93HWVMR1WAHtbcxguCAoyF6cPe0BrHTstnutVU+F+h/KRScJP0B fkgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=c2UwnXYA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id o8-20020a056a001bc800b0068a3c575900si26366981pfw.84.2023.10.02.11.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 11:08:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=c2UwnXYA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id D6812802B17B; Mon, 2 Oct 2023 04:34:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236690AbjJBLeL (ORCPT + 99 others); Mon, 2 Oct 2023 07:34:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236599AbjJBLeJ (ORCPT ); Mon, 2 Oct 2023 07:34:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99062BF; Mon, 2 Oct 2023 04:34:06 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 68B1F66071CC; Mon, 2 Oct 2023 12:34:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1696246445; bh=9t/jOl0Thy1T1dExt2YlwpxckJSmjnulYz343ekqiOU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=c2UwnXYA6v1PGmWdlFewrB37q0sywfNvyFg/94NAuO8wbPvLH88UGuTUTvoP0V834 7iRcR/wpx1DwUXyaST2eBbGrr/9mZOs8nHeLqt37i8mI3aMQL4ILhnukzUtVXaWAVe pI8FCG73fK29CrveqlNc8AVBT04GLz0gjHEj9SU/7txpy1rHU0Ljq41bsB+PInh3+8 OUBuVwUlm8ZZu+VoxRgChPQuPeOPtcvv+FRd93B/3uKyFFNzs/zVIbGFgnFyLYWSqS oIjGAVYoHCCAyh/NWulz/WO8fNRytQRf9jBAmt8YhM+VU7mBzbB1/g0CMVgkJK5KUu No3ozYeZGszNg== Message-ID: <7e6fb959-9e0e-ad08-c33a-92cc86eec2d0@collabora.com> Date: Mon, 2 Oct 2023 13:34:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] media: mediatek: vcodec: Handle encoder vsi NULL pointer case Content-Language: en-US From: AngeloGioacchino Del Regno To: Irui Wang , Hans Verkuil , Mauro Carvalho Chehab , Matthias Brugger , nicolas.dufresne@collabora.com, Yunfei Dong Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Maoguang Meng References: <20230926101909.15030-1-irui.wang@mediatek.com> <20230926101909.15030-2-irui.wang@mediatek.com> <633d4544-e215-2742-a4c0-81698607e830@collabora.com> In-Reply-To: <633d4544-e215-2742-a4c0-81698607e830@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 04:34:22 -0700 (PDT) Il 02/10/23 12:48, AngeloGioacchino Del Regno ha scritto: > Il 26/09/23 12:19, Irui Wang ha scritto: >> There will be a kernel null pointer exception if 'vsi' is NULL, check >> 'vsi' is not NULL before assign it to encoder instance. >> >> Signed-off-by: Irui Wang > > Reviewed-by: AngeloGioacchino Del Regno > Sorry I just noticed that there's no Fixes tag. This commit needs a Fixes tag, please add one and send a v2.