Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20230929091206.13955-1-lhenriques@suse.de>
In-Reply-To: <20230929091206.13955-1-lhenriques@suse.de>
From:   Ilya Dryomov <idryomov@gmail.com>
Date:   Mon, 2 Oct 2023 13:02:36 +0200
Message-ID: <CAOi1vP92B4E4Mt+8ALD00V-QhYBi9hLeLCR1jrBrKb493V6HXA@mail.gmail.com>
Subject: Re: [PATCH] ceph: remove unnecessary IS_ERR() check in ceph_fname_to_usr()
To:     Luis Henriques <lhenriques@suse.de>
Cc:     Xiubo Li <xiubli@redhat.com>, Jeff Layton <jlayton@kernel.org>,
        ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 29, 2023 at 11:12=E2=80=AFAM Luis Henriques <lhenriques@suse.de=
> wrote:
>
> Before returning, function ceph_fname_to_usr() does a final IS_ERR() chec=
k
> in 'dir':
>
>         if ((dir !=3D fname->dir) && !IS_ERR(dir)) {...}
>
> This check is unnecessary because, if the 'dir' variable has changed to
> something other than 'fname->dir' (it's initial value), that error check =
has
> been performed already and, if there was indeed an error, it would have
> been returned immediately.
>
> Besides, this useless IS_ERR() is also confusing static analysis tools.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202309282202.xZxGdvS3-lkp@intel.com/
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
> ---
>  fs/ceph/crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/crypto.c b/fs/ceph/crypto.c
> index e4d5cd56a80b..e19019209cf0 100644
> --- a/fs/ceph/crypto.c
> +++ b/fs/ceph/crypto.c
> @@ -462,7 +462,7 @@ int ceph_fname_to_usr(const struct ceph_fname *fname,=
 struct fscrypt_str *tname,
>  out:
>         fscrypt_fname_free_buffer(&_tname);
>  out_inode:
> -       if ((dir !=3D fname->dir) && !IS_ERR(dir)) {
> +       if (dir !=3D fname->dir) {
>                 if ((dir->i_state & I_NEW))
>                         discard_new_inode(dir);
>                 else

Applied.

Thanks,

                Ilya