Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <2165e4a3-a717-f715-f7c3-e520d45ec21c@intel.com>
Date:   Mon, 2 Oct 2023 15:52:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next v1] net/xdp: fix zero-size allocation warning in
 xskq_create()
To:     Andrew Kanner <andrew.kanner@gmail.com>
CC:     <bjorn@kernel.org>, <magnus.karlsson@intel.com>,
        <maciej.fijalkowski@intel.com>, <jonathan.lemon@gmail.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <xuanzhuo@linux.alibaba.com>,
        <linux-kernel-mentees@lists.linuxfoundation.org>,
        <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <syzbot+fae676d3cf469331fc89@syzkaller.appspotmail.com>
References: <000000000000c84b4705fb31741e@google.com>
 <20230928204440.543-1-andrew.kanner@gmail.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230928204440.543-1-andrew.kanner@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVVUeXBIY3hrbS9tL3pKdVE1WFl2cCtsc0hNcFVFTzJmZ2ZYQzVLZXR5YThr?=
 =?utf-8?B?MmhQaHlsaHR0bGQrS21iSjQwQTcyRDEzSW8yTnM4L1UrWnEwaG4wS1A1eWhZ?=
 =?utf-8?B?WmpIOENNR0V6UldSL21lQ2ZwckxKL1ZERHY3bDJFcUNWbkNjL2d6RWhyVERi?=
 =?utf-8?B?SEVYbUxjRjRNem1EQ2I4SEhUd0paYU9HM2FhUGZ0Zm0relphbzB4enNxSnY5?=
 =?utf-8?B?YU0xdXRyZFNZcDlGTW8xL1JPMFI0S08rSDRUWGZmb2JIbnRrc2FTVVJaWi9L?=
 =?utf-8?B?cHRnWUZuVWcrMDA5cUdRbnVBdFViVDh1UHdtZzRESFZQWnE5NmNqQzA3R2xW?=
 =?utf-8?B?dktzdHY5SlgreHBIN1pxK2swZXVoSFlxZFBDU0xmWkZOWk1qV0x5M1ZOZDJi?=
 =?utf-8?B?TzZwYXU5U3pkOXFnUkVIWERqZTlHck1aZjMrV2tuSWNsUDVQWVdrSy9JRzgz?=
 =?utf-8?B?aURzQkdMZkFHMjUyU3ZjWndqQVFhS09OL01YVTAvQVh5RDhOZ0dXU1h3dUp2?=
 =?utf-8?B?OUZ0aktPVis4UlVqRWNLRnNJTEtISmR2bDh4azhwZ0hRUWFlU254ajVvRnh5?=
 =?utf-8?B?bnhaZEsyMkY5UEppTXYvSjc5MFNLSGxRbjBMNHNOZkl2MXdITnpweEF6S2pU?=
 =?utf-8?B?a1N2SW5HMXd4YTdFck52Ti82VGd0bEhSTFA1QXFrcGxraU5wdE1INVQwNDhM?=
 =?utf-8?B?Nzc5NkUwQWhhWlFjaG03MGxmZ1BkQ2lBREtxWEh1MGpPbEN5RWpWcGlvRkxq?=
 =?utf-8?B?K09VSjk2eXlRZ0IyNU5odXNCKy8rTlZDQnlEK2IyRlV0R3FnVUhweGhEQUI4?=
 =?utf-8?B?NDRmbWpXN1llcTdkRUtlbzMraytaSmpxbTlHMDhhSWtuNXBpdXQ1Qi9UNjI5?=
 =?utf-8?B?OGt1TndhL0ZCY3VSbklRL3IwbGptSXlRaWdkUFVpdjZ3bFBDWCtkNEpIdExJ?=
 =?utf-8?B?RU9oR3pMd0NIeXp1N1RyakRIZjJIdGpIR1JTVm5jaml6VFZzUU45NnJhdUdp?=
 =?utf-8?B?b3ZMSXFuVHRvTDdVREVadHNSZkZ0WGg1WVNpRjVpaWUwcTdOTUlsS3h5ZEo5?=
 =?utf-8?B?VExZTldhVXJwZ0pCb2ZPa2lZdlZpYmYydTJaa0gydkNDa2I3K25OSk5kV0Nk?=
 =?utf-8?B?YkgzcDBzZWJPL1RzdnBRakpvZjUyWi9vSy9JZG5UVXpwUkZLMWIrUXU2UGlX?=
 =?utf-8?B?cHl3VDZhZmRVU252Vm9Cd0lpd1dhalVLaEs2UDZXeFFmdUw1QitBUGRhTFlx?=
 =?utf-8?B?Q0FTRDh0cFZHMURGWWtxbGdLM1FlZjBiM3B5N0k5aUJJZVhOZWVZaWhTYUlG?=
 =?utf-8?B?QmUzMEc0UVJua25yOTZUN0F0SUU1WG5EcVNhWVlWQml0V3VLRjBIODRXQW1r?=
 =?utf-8?B?ZG03ZHFGSDVhVzYwdThBWkhjNnQ4ckZSTkRia25MTnR1NURqYVBpTHhhSkUw?=
 =?utf-8?B?SjdZcFBQV1FXdXpkSjEvWFZHaWxaWXhvU1Nkc2gvYTZBek9TeDJzNXhoWGVR?=
 =?utf-8?B?dEFVc2orbEF0WTlvZnQxd3RCM25BcnIyeUlqcndpTnZhOW0raUFDR05jMWhP?=
 =?utf-8?B?b1pJUXFSZENLRm0wYmZrcVEyTzNDKzZoYWhIV01zV3E5djBYZGwweXZWNk8y?=
 =?utf-8?B?SDlHa1gvSWVYdjFPWUQ3dGh0ZmUxU25weEk5b2lTUXVyT0hkS3ExVVU0bUc3?=
 =?utf-8?B?cWdiY3dFMVF4VXlyMUt4anROYjFZa1RmanVyT3ZjMnZCVC90cXZJOENFREY4?=
 =?utf-8?B?dHVsL1VVNTEyZGN4NHpaZzRwZkg3dDNRemxLdUxrUXBwS2NQSlVEdzdsTVV3?=
 =?utf-8?B?WGFoQmIyTEJxaTVuYjhxN1NaUk10NW90ajJsNGNFTloxU1hqNnAzbnoxeXV1?=
 =?utf-8?B?dmVhaFNmUU1uWC82cDB2Q2k1MjRacnJ4ZzRIbU5ocVYxSHBPZUFqTkZwRklW?=
 =?utf-8?B?YnlTZGFvM3lINlRpTTZVWEl2Z1dBbndIcmtpdHBqUXpuOTZ1clpTRUhxOWYv?=
 =?utf-8?B?SVdWK2pkdE5wSGh2aS9lM0IwdGpRZkRYbG1tVmpOcGdhb0tyS25XNml0MmVU?=
 =?utf-8?B?NFUzYTNRaFFFbHYyK2pGbDQ0RFlINlBXZTArUFhrVGNvU2NUT21CZjhhNkJI?=
 =?utf-8?B?OXFvdFRoaG5vVHhqZlJnUTdIaWNma0N6dTNFb1o3Nm9CZGVSNjhVRWtldE9x?=
 =?utf-8?B?UWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd4b8e19-3bef-4d45-8657-08dbc34efd3a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 13:53:42.9184
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zJ58jjTf0UhmZqySfojvXY3DmNfPFRHtHH79770Y96c421OUwbmIaMxeNSDSw4POj1V2a4ApDCT39m9gP0MDEzHjupuA+kpz5DXmo6cqeBU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6371
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 06:54:28 -0700 (PDT)

From: Andrew Kanner <andrew.kanner@gmail.com>
Date: Thu, 28 Sep 2023 23:44:40 +0300

> Syzkaller reported the following issue:

[...]

> PS: the initial number of entries is 0x20000000 in syzkaller repro:
> syscall(__NR_setsockopt, (intptr_t)r[0], 0x11b, 3, 0x20000040, 0x20);
> 
> Link: https://syzkaller.appspot.com/text?tag=ReproC&x=10910f18280000
> 
>  net/xdp/xsk_queue.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/xdp/xsk_queue.c b/net/xdp/xsk_queue.c
> index f8905400ee07..1bc7fb1f14ae 100644
> --- a/net/xdp/xsk_queue.c
> +++ b/net/xdp/xsk_queue.c
> @@ -34,6 +34,9 @@ struct xsk_queue *xskq_create(u32 nentries, bool umem_queue)
>  	q->ring_mask = nentries - 1;
>  
>  	size = xskq_get_ring_size(q, umem_queue);
> +	if (size == SIZE_MAX)

unlikely().

> +		return NULL;
> +
>  	size = PAGE_ALIGN(size);
>  
>  	q->ring = vmalloc_user(size);

Thanks,
Olek