Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <tencent_BC7A3D486E923DFD8C99DFCFEA79B82A8205@qq.com>
Date:   Mon, 2 Oct 2023 23:12:13 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
From:   Wen Yang <wenyang.linux@foxmail.com>
Subject: Re: [PATCH] eventfd: move 'eventfd-count' printing out of spinlock
To:     Jens Axboe <axboe@kernel.dk>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>
Cc:     Christoph Hellwig <hch@lst.de>, Dylan Yudaken <dylany@fb.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Matthew Wilcox <willy@infradead.org>,
        Eric Biggers <ebiggers@google.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <tencent_6E80209FC9C7F45EE61E3FB3E7952A226A07@qq.com>
 <ff95e764-9e61-4204-8024-42f15c34f084@kernel.dk>
Content-Language: en-US
In-Reply-To: <ff95e764-9e61-4204-8024-42f15c34f084@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/9/27 15:32, Jens Axboe wrote:
> On 9/26/23 8:05 AM,wenyang.linux@foxmail.com  wrote:
>> From: Wen Yang<wenyang.linux@foxmail.com>
>>
>> It is better to print debug messages outside of the wqh.lock
>> spinlock where possible.
> Does it really matter for fdinfo? Your commit message is a bit
> light, so I'm having to guess whether this is fixing a real issue
> for you, or if it's just a drive-by observation.
>
Thanks for your comments.
There is a business running on our machine that frequently calls 
eventfd_write().
We will resend the V2 and provide a detailed explanation.

--

Best wishes,
Wen