Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <0010108d-baed-14f7-29e7-247d80c9d3b0@intel.com>
Date:   Mon, 2 Oct 2023 08:49:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v4 0/7] selftests/resctrl: Fixes to failing tests
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        LKML <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
References: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com>
 <6a826da8-a94d-261b-cfe8-c494d7237a0@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <6a826da8-a94d-261b-cfe8-c494d7237a0@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWgrNEZXMFgway9tMTRBYTJubktEbjNvbXg0cEpYUERYVFVmVDFCTmMzKzFu?=
 =?utf-8?B?YUM0VjFqWnJhQzczZm1BcjhoaWh1QmpWckJpL2h1SytxZWdCTGZNS09NcEI3?=
 =?utf-8?B?SzkyRUxZV2dMRFBPRDBpOG0vekVtNHgyVHV6VG5URDdSYU9jdmlRR3RhWEdn?=
 =?utf-8?B?SWFjN3FPQnNibkgzSk0rUE5QUWlwQ2UxaElROER5VE8yWTI5aElTUW9DMDJF?=
 =?utf-8?B?andPWjFhSXNUaWVuSUQrQW1IdnFPVmYvQ1hKdzFuSjh4ajVVZElxMVIwbFMr?=
 =?utf-8?B?alhvL3FMeE1aQ3dtV3FVc0ZaUUJWVmNnVmxLbXRNQzZ3bmtOVW0rdkFra2x0?=
 =?utf-8?B?VUgwZndLU1c2c0gzR1Bnd3FtSzh5bjZXQWNwY213dEY2YkNDcmpzS3Z3Rjcy?=
 =?utf-8?B?TjdEekNZbzNOeHFNZzgycUMvYWM2cW04S2NBMVJuQVk4S3FwQWhTYWYwNkJH?=
 =?utf-8?B?dmRsZWZLLzhkUTMxaW40NFdwL3JWYWNib0FNKzZMRHJvcWlhTFFWV1A3UmYx?=
 =?utf-8?B?bUdLV1BxV0oxMzAxd2Y0OTViS2dUVDRWZnRhZmU0VDFLNkUrWnZ1L21mTFhE?=
 =?utf-8?B?NklVdDhoazFhQUVLV1hNZ2JwRXYxaERTQlB1d0tYUzdUeUJYQ2tZR2xSclB5?=
 =?utf-8?B?MjVzSytMTEJ3RGxOQThrUS9sZ1duRU1KdUY5NUJtVjduTlQwdWRBcUpKSG9E?=
 =?utf-8?B?UE5NVWRCaXRBdkFoemVmN2Qwb0xrWHFKZGpWWC8zakt1Q0ZPYlVSWkRqUVFC?=
 =?utf-8?B?dGdQckM4ZkNIMEEzbU1sUE5XaVhQQ0FrbldnVEtkVUI0aXJCd283bFhOaVRI?=
 =?utf-8?B?bUc2eGplR3FGVTJlWWMrZ1dYYUNlcUduenAwQVdJdnRXUXZrRHFYTXRYd285?=
 =?utf-8?B?OXZLd3dsYW1QVTRma3QyMzIrQ1F4VkRXcmlBenNvNEJaUm1JWmxuOHJsSVU2?=
 =?utf-8?B?RU45bjA1eGpYdGNycnRab0lBQnV1aHh4N3FwUWRndFBWWFdmck5FNzAyc1A5?=
 =?utf-8?B?NmNYNlFjNkl5bHE1eTQrUENYMWpmV2RXNm9QaG5GU1FvUnNRWWdCeTczYTZR?=
 =?utf-8?B?NE5qZEROY2lJTXpsdkkwS2FEdTRJUHA3R0pMMndwQlV2Y096dXVPRUxkcmQ5?=
 =?utf-8?B?YVI4VFVUOU5XZWo4K1ZsUG9FNEQyYlBzZ1NvNjNRd2pRVzEzZUpsbW51ZHJW?=
 =?utf-8?B?WkhZMHJTZllFTFRGamh5bnJYSXdGUEkreHJWakw3NG51ai9sWTVEM0JqdWtH?=
 =?utf-8?B?dkYzY1JXcUVKRVhJSGY0V0RwTnJscmNGNm96MUZ2aWl6ZmVDWFRseHdrbWdP?=
 =?utf-8?B?aTFWcjNicUxXZ2puRHJhMTJ5Z1pKWUgvQzhRc2dBek5YQlNKSWR6UkJ0RlIr?=
 =?utf-8?B?WUk1dUZNRUo3b0ZHa3FTMy9jUkxwMnN2bVBiUTFseTNjK0tkQ0FuYWwyVjhp?=
 =?utf-8?B?SjNPWmlSaUtRLzg5ZEQ4NnRocFllMVpqcGw0NjU3QkRLNk0vQWhuMGpZOUIv?=
 =?utf-8?B?TGJKMmlQTWRvN3FHUEtId041bXd3dWJTWGVGZDZWTHBYUHpRalJRL0ROc2NZ?=
 =?utf-8?B?U3JOWWgzRUJEdlJuVTVKRVBSenFxSmZjR1B4WHhFM1ptNDFFdmhZTGNIQnQ2?=
 =?utf-8?B?U05jM1R1SnJsNnRXT0xVV3hzZEZJUnlTb3BQQnR6b2RFaks4TmxoU1o3RUhD?=
 =?utf-8?B?VHp3NGJySnlkeU9MKzhUYWlBMG1VS01odDNnNE9nL2lrOVc3Z1FDUFpFUURs?=
 =?utf-8?B?b1NNd2lGWmF4ZHFmdHB3M0hSZkZQZ1diS0xpSUpUcWh0QjdDSEo1N1dvMUZQ?=
 =?utf-8?B?TFNmTVdRQkdDMXZ4T0hrMG1POGd2c2gwTmFkYzJVa1FzUzdBdHluWWs3MXV2?=
 =?utf-8?B?U3M2Yk1uUWNuVzFBSU9hb2NBTm1ONUJkL3o0NFBaVEVLSDNxbjlLY1RuRUZ1?=
 =?utf-8?B?ZTJHZDJSSkJPTEx3bzVvYmJrQ1FXVHNTL1hOc1U3TVpYSVdrSllZZzZzUURN?=
 =?utf-8?B?K1pnekhKVDBhZzdRZzQ5SVFiQ3o2bHBjY2EzVmMzK0gzSmM3c3IzT0E1eVN1?=
 =?utf-8?B?TVpWWlZheURndXpodHEzdDJSQ2NtY0xNelhEbDJZTEo3RjZkeXc0Z3Y3Y1A1?=
 =?utf-8?B?b0dPdmc1dWN5ZXVZeXk0b0R3a0FuSWlUdzZtUklndno1aFhpTzRON3pqUDhw?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea13b3d5-9f91-4891-4249-08dbc35f22a9
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 15:49:17.4849
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tzGwrHFviggHkBSlcH/J7wgDcRd0+naj6SVPfi4af4/Q3a1PPgYJhHoOpxWfqZtR8T3L46s6L9/LiU9MzK+PItUnyP8RH1MEyEYeHQKZBe8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8082
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 08:49:36 -0700 (PDT)


On 10/2/2023 4:31 AM, Ilpo Järvinen wrote:
> On Mon, 2 Oct 2023, Ilpo Järvinen wrote:
> 
>> Fix four issues with resctrl selftests.
>>
>> The signal handling fix became necessary after the mount/umount fixes
>> and the uninitialized member bug was discovered during the review.
>>
>> The other two came up when I ran resctrl selftests across the server
>> fleet in our lab to validate the upcoming CAT test rewrite (the rewrite
>> is not part of this series).
>>
>> These are developed and should apply cleanly at least on top the
>> benchmark cleanup series (might apply cleanly also w/o the benchmark
>> series, I didn't test).
> 
> LKP seems to no longer happy to apply this cleanly without the benchmark 
> rework series as the signal handling fix got now a bigger footprint 
> (maybe LKP didn't build v3 at all as the changes from v3->v4 were really 
> small and I did not get error out of v3).
> 
> Shuah, would you want me to reorganize this such that it goes in before 
> the benchmark series? In any case, I'll wait until Reinette has had time 
> to look at the first patch if I'm to send the series reordered.

That sounds unnecessary to me because I assume that doing such reorganization
would require a new version of the benchmark series [1] that has been ready for
a while now.

Both series look good to me. I just added my "Reviewed-by" to the first patch of
this series and it (this series) applies cleanly on top of the benchmark series.

Reinette

[1] https://lore.kernel.org/lkml/20230904095339.11321-1-ilpo.jarvinen@linux.intel.com/