Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1532581rdb; Mon, 2 Oct 2023 12:30:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgNWYf+zCp8Rxgdbbyuksrjyr3Xowmwfi8NAXGKMR5UPfFuVftYriYUmfod/mJYqxyQ/MO X-Received: by 2002:a05:6a21:47ca:b0:15d:ad11:748 with SMTP id as10-20020a056a2147ca00b0015dad110748mr11187392pzc.30.1696275004971; Mon, 02 Oct 2023 12:30:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696275004; cv=none; d=google.com; s=arc-20160816; b=R5IpG5jPT8qv8eVWaPtov82XphsACBiRh5g8G13rd8YoJwtz/4mDQzBzpcLLTZFKEI h/jGgqp1p1zfL4pUG4dgSgYdAfMCleJOULZXbyXiNTVRfiHRd6MmoL/wj8agLQWfWiA6 ivLXzfTjmqzLYihcRpQc301k7phFVXzEk+7lgzbdhJk9DZMmfrc1ME0q119e51vGrMOM ezEKY7KZf3waoxCBxvwikbz2F1MZbqmtCos5unVKRd3BhCLgwGn9AIiwjFBDEbTWYlPs plbt9vvw2AeBvacpElYB1tg1/tAniNv90g9Zvnri2U8KNYHAjy8C5JXAr9D5kzYxccQ9 kF4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V6qb0UV8Z2ZKESqm4bQ1W8nZg6JqpnXsb2K3oQSjwYc=; fh=3Wij1Nyq0kk9iFJBGjsMqOGfirL0oXoeYA+XKMkEeWg=; b=BNzW3PPUyV9caZO3PJ+tKy5HXm/wHx2AxJS46/n51evSi9/cTl+iG2CZo3IYnchx8w 09yGm3jULXv2Ex5nfJZzUVJOchQXVBetTfxLBYx5HjeUv7qbJtWSnbs0p6x8ALv99jM2 jG97VrZ3SUdmmSvwotlMEA82bsMMPORbyegS7W1s7wPErw57UttYV63f6xglLBMQteTT 89sBYo1SHjCWqaBTrLadBZk1fPR+Tr6QOdZdVR5p5P8ygNJ7kp1ioBhIGwakKvn+62M6 D5TfpS2KCjs7scNK+5cljvcFcjSRXjAGoCD0vjBfe4a5vgA+7Yx4kIaVJ2fGc1k1dWAu g2Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=RybW5RZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id b22-20020a056a000cd600b0068a68d71b68si13577554pfv.216.2023.10.02.12.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 12:30:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=RybW5RZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id EA7FC8031AE5; Mon, 2 Oct 2023 06:18:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237429AbjJBNSM (ORCPT + 99 others); Mon, 2 Oct 2023 09:18:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237371AbjJBNSA (ORCPT ); Mon, 2 Oct 2023 09:18:00 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE531B0; Mon, 2 Oct 2023 06:17:56 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1B9C41BF212; Mon, 2 Oct 2023 13:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696252675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6qb0UV8Z2ZKESqm4bQ1W8nZg6JqpnXsb2K3oQSjwYc=; b=RybW5RZYQzCY7NtLtfl1deihG3t1AsWq3uXVglpL4oTEmVrv66uF62mj8ofOQ4ei+Tl4jf UqJ8yHfWTm1l44Ipz03M62Ol+nxaaH8S14t1HOemxwgXgaeytay0BiwEYAniM7ZMzeoZdy rAHt6s57HVUOGxzImVDgq+CRsxuOIizesbTjE5eBoPmLnGip0FKVlqvQ2u79wfCyjIZxVO 7JC0Z8tt83lgfAN0nMpBMmW5hWjc9fzEUKZ3jRG8tpVtI+UkThTaxAF62C6HXJJnsbGWbV 2iA1t0I90grWFkUxNngK1ruE14nQvzP1tN8GVCaUiOPCAsnVUnm+q35dGWerbQ== From: =?UTF-8?q?K=C3=B6ry=20Maincent?= To: Cai Huoqing , Manivannan Sadhasivam , Serge Semin , Vinod Koul , Gustavo Pimentel , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Petazzoni , Gustavo Pimentel , Herve Codina , Kory Maincent Subject: [PATCH v2 3/5] dmaengine: dw-edma: Add HDMA remote interrupt configuration Date: Mon, 2 Oct 2023 15:17:47 +0200 Message-Id: <20231002131749.2977952-4-kory.maincent@bootlin.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231002131749.2977952-1-kory.maincent@bootlin.com> References: <20231002131749.2977952-1-kory.maincent@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: kory.maincent@bootlin.com X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 06:18:23 -0700 (PDT) From: Kory Maincent Only the local interruption was configured, remote interrupt was left behind. This patch fix it by setting stop and abort remote interrupts when the DW_EDMA_CHIP_LOCAL flag is not set. Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") Signed-off-by: Kory Maincent Reviewed-by: Serge Semin --- drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c index 0afafc683a9e..0cce1880cfdc 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -236,6 +236,8 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) | HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; + if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + tmp |= HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN); -- 2.25.1