Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Feedback-ID: i36794607:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-958-g1b1b911df8-fm-20230927.002-g1b1b911d
MIME-Version: 1.0
Message-Id: <d5836a46-c614-4270-8473-05c98bbab41f@app.fastmail.com>
In-Reply-To: <CAMuHMdWFCSQgsf_0qwdkkAif3zDXM2N-WEymJBa1eeT4N6Ezcw@mail.gmail.com>
References: <20230925155328.443664-1-arnd@kernel.org>
 <CAMuHMdWFCSQgsf_0qwdkkAif3zDXM2N-WEymJBa1eeT4N6Ezcw@mail.gmail.com>
Date:   Mon, 02 Oct 2023 21:42:18 +0200
From:   "Arnd Bergmann" <arnd@kernel.org>
To:     "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc:     "kernel test robot" <lkp@intel.com>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: asm/io.h: mark mmio read addresses as const
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 2, 2023, at 15:12, Geert Uytterhoeven wrote:
> On Mon, Sep 25, 2023 at 5:53=E2=80=AFPM Arnd Bergmann <arnd@kernel.org=
> wrote:
>>  #define out_8(addr,b) (void)((*(__force volatile u8 *) (unsigned lon=
g)(addr)) =3D (b))
>>  #define out_be16(addr,w) (void)((*(__force volatile u16 *) (unsigned=
 long)(addr)) =3D (w))
>
> Shouldn't a similar change be made to rom_in_{8,be16,le16}()?

Right, these seem to have escaped my regex searches.

> I can do that while applying...

Ok, thanks!

     Arnd