Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1545288rdb; Mon, 2 Oct 2023 13:00:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/h4ih+Dc2/VOvkG6PXwH1qPcRwXtjTCytg9oWbLJgi6/LSgCUzWqJI4BShY6HdqAi/TmE X-Received: by 2002:a05:6808:1527:b0:3ae:1cd9:8e0 with SMTP id u39-20020a056808152700b003ae1cd908e0mr15838308oiw.39.1696276838102; Mon, 02 Oct 2023 13:00:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696276838; cv=none; d=google.com; s=arc-20160816; b=Qt8Y1ENQjcCiowjcTowVG00+TFpVXvLjzOqfgSvu9dpnFwaN4Ko0Lk1M58AZryCo/y ywsRJiicKvu4hfDDDYROPqYJf02xZFklx07lSf98cBsr8JZCNYecBjX/1bImP1qPoKDH FHIOlD2zSZ6hK9fi4NPwRQKhKec9O37n5Bk1yPhsbGB4k0Sl2mq0L8Zc5J5E+FxuGN+4 DZm01Q4rSpJPKKSF2kjYRVrfl0uIB175aaxXdmOIQ44jTUEpMEc1+RkXi1jSkhQg1Pln Hh2lX1xEYJqdOr+AV1Y5ooAd2B4P54z8Mbn0BKUuanSQ4H9pBg0sc+JucS9SSK6XXJw5 yy2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=G0T9PfbNrXniK4beiYc72WRU4MBB7zDa0iGJLKfN7z4=; fh=tHBQXJ3ST4fgjkxFpLTsuSRtoAwxUNEr3Q1XJEpQuXc=; b=qmIjquXX5/nSCFQlQHb/Ij8Hox7vZO0oKL9sZoez4q42aRKB8+XYPTP4HSNJAcT5Qr n11PiS1Hc5GKDaMzFY4XC37Un2545u7hQ4ZlhSmmpFlgzeq/GuwGPXiytxeu8/DVJSUB R7QYuJtoAKoG3y7XrPFTymuoI6YbO/COH1sFV3fEQmiTlmgsJB8LfetVPdUXiK1wocdR 9gVRqgKLNBUMnBllLXz3mBPe8FdU642/sFPHwdmfMqZF1Qqlg9wwj58d/WQkI9sUQr81 ENsDJL1O7ENZ/Y9DGnpN2Bhw3XowzYFjZf8Ut2sXjmuhrQcwVX1iBisXDNL1GZOrs8lv QmmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="ZVI9+b/e"; dkim=neutral (no key) header.i=@linutronix.de header.b=lbtyF4Go; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id c29-20020a63725d000000b00578e2b20624si16359976pgn.72.2023.10.02.13.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 13:00:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="ZVI9+b/e"; dkim=neutral (no key) header.i=@linutronix.de header.b=lbtyF4Go; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 69BA880A13BC; Mon, 2 Oct 2023 09:14:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238432AbjJBQNv (ORCPT + 99 others); Mon, 2 Oct 2023 12:13:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238451AbjJBQNs (ORCPT ); Mon, 2 Oct 2023 12:13:48 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A29D1B2 for ; Mon, 2 Oct 2023 09:13:44 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696263222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G0T9PfbNrXniK4beiYc72WRU4MBB7zDa0iGJLKfN7z4=; b=ZVI9+b/ealErgG3IPoHGhdg/NotJntiVmAyqJoOXEwIT9QlX2f11mnlB6opiJi9h8X6Yqw 9A2GPN0JzuPyrB/8rI/AmLr84W/+aEzDWX+G16pWN9D52snTtppv7arH68AZF2H8S0Nwul QZKS7psBoGrnJxXdhG1BD2IdmY07M9q1nxrWNUiHDk9IxNy/lRyIV0l2oIL2XtAP9NKB9/ n9gqPyXHDzyoGRGSl5Kq2oo1BMrrxWZWBSzUa/31Kf/6CG4HQ6xssIcsbtYRt55JtHWVVT ErJRc1M0CQD81JNKHWKhoBuhdYuaUrPLI6cgsuJizikioMZ41dM7pW1nqDIvIA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696263222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G0T9PfbNrXniK4beiYc72WRU4MBB7zDa0iGJLKfN7z4=; b=lbtyF4Govw8zdoYv4rO5n/Q5OTVPYbrIuIDdf+yCKvUyn8j255Gr09m8Vh1IRWPq6fVXNU uVgutD1q5M4WIXAA== To: Steven Rostedt Cc: Linus Torvalds , Peter Zijlstra , Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, Frederic Weisbecker Subject: Re: [PATCH v2 7/9] sched: define TIF_ALLOW_RESCHED In-Reply-To: <20231002101514.44b9c812@gandalf.local.home> References: <87ttrngmq0.ffs@tglx> <87jzshhexi.ffs@tglx> <20231002101514.44b9c812@gandalf.local.home> Date: Mon, 02 Oct 2023 18:13:41 +0200 Message-ID: <87jzs5c896.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 02 Oct 2023 09:14:24 -0700 (PDT) On Mon, Oct 02 2023 at 10:15, Steven Rostedt wrote: > On Sat, 23 Sep 2023 03:11:05 +0200 > Thomas Gleixner wrote: > >> Though definitely I'm putting a permanent NAK in place for any attempts >> to duct tape the preempt=NONE model any further by sprinkling more >> cond*() and whatever warts around. > > Well, until we have this fix in, we will still need to sprinkle those > around when they are triggering watchdog timeouts. I just had to add one > recently due to a timeout report :-( cond_resched() sure. But not new flavours of it, like the [dis]allow_resched() which sparked this discussion. >> - TRACE_FLAG_NEED_RESCHED = 0x04, >> + TRACE_FLAG_NEED_RESCHED = 0x02, >> + TRACE_FLAG_NEED_RESCHED_LAZY = 0x04, > > Is LAZY only used for PREEMPT_NONE? Or do we use it for CONFIG_PREEMPT? > Because, NEED_RESCHED is known, and moving that to bit 2 will break user > space. Having LAZY replace the IRQS_NOSUPPORT will cause the least > "breakage". Either way works for me. Thanks, tglx