Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <479379a1-110d-4543-89f0-cb584b74ce22@alu.unizg.hr>
Date:   Mon, 2 Oct 2023 21:50:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG: maple_tree: KCSAN: data-race in mas_topiary_replace /
 mtree_range_walk [EXPERIMENTAL PATCH]
To:     "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <9c1549f9-78c2-441b-8617-3ea3c080a5a4@alu.unizg.hr>
 <20230922135155.tqrelea66hcj5cog@revolver>
 <5d908c60-88fb-49c0-a150-bfb468eaa513@alu.unizg.hr>
 <20230928195926.ucp7it3c3c75erzk@revolver>
 <5a30110b-2457-4638-8779-baa33326f6a6@alu.unizg.hr>
 <20231002164310.bi62wfekacfxb3ve@revolver>
Content-Language: en-US
From:   Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
In-Reply-To: <20231002164310.bi62wfekacfxb3ve@revolver>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/2/23 18:43, Liam R. Howlett wrote:
> * Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr> [231001 17:09]:
> 
> ...
> 
>>
>> They say that one patch speaks more than a thousand words.
>>
>> I am just running this little patch that actually silences all of the KCSAN warnings.
>>
>> I cannot tell if these reported data races are the actual bugs, but it is possible that
>> the Ubuntu 22.04 gcc is doing some funny stuff when optimising. In Prof. McKenney's
>> book I've read about the load-tearing and store-tearing. AFAICS, memory barriers should
>> prevent load/store reordering, but not the compiler optimisations.
>>
>> Please find two versions of the patch attached.
>>
>> While mas->index and pivots[offset] in maple_range_walk can change concurrently,
>> I am not smart enough to see whether you expect that in your algorithm or is it a potential
>> bug triggered by GCC optimisations and aggressive Ryzen 9 7950X parallelism.
> 
> None of this is necessary, for sure.

Thanks for your feedback. If KCSAN is giving false positives, there is quite a lot of them.

I tend to believe on the safe side of the Prof. Paul McKenney, but it is your code.

> I will have to look at this when I have more time to investigate.  This
> will likely not be soon, however.

I see. I also have some tough stuff at my day job this month. :-P

Have a nice day.

Best regards,
Mirsad

> Thanks,
> Liam