Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        "Smita.KoralahalliChannabasappa@amd.com" 
        <Smita.KoralahalliChannabasappa@amd.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [PATCH v8 0/3] Handle corrected machine check interrupt storms
Thread-Topic: [PATCH v8 0/3] Handle corrected machine check interrupt storms
Thread-Index: AQHZ8wEYb+mKCqp50kGumaGvWObFUrA2yrPQ
Date:   Mon, 2 Oct 2023 17:57:35 +0000
Message-ID: <SJ1PR11MB6083447BB15B0D0535D77C68FCC5A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230718210813.291190-1-tony.luck@intel.com>
 <20230929181626.210782-1-tony.luck@intel.com>
In-Reply-To: <20230929181626.210782-1-tony.luck@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q9YtRUb+jDqof5O6VY4aC6gIuy9jwU7j7cOXcFMQ4pd9FpLZHE5RIRaIWGAb?=
 =?us-ascii?Q?OriinfJkUi72M9FFqjl+yMUnLcR482Hva8o7Jdgy5U/dZdPlAh8K6hCMyBqi?=
 =?us-ascii?Q?WiIbw93P1Y/eVNRZ4lx384aLgH6kjZZc0FQ0E2etGZgwkMm6p/FhpsoXbMx3?=
 =?us-ascii?Q?dcisZcTkR9cQ26o1Y4zZU/nX6WsLzGJWcbJZIFCYjt68v04ZS/p6YM6v1/Nu?=
 =?us-ascii?Q?Tw8caQ/NqWuSbRnFIhuzKgqUDONGlCim6SiG4j+Ixt/Qyjxd0NIy+Ldq1J3b?=
 =?us-ascii?Q?olHqScRmuDFb8r1Dtk2o5Hqik6pI1qe/8ZgdgZ50Sl/P7k4I/UVXmD5uW8U8?=
 =?us-ascii?Q?Y75NNiNdkxavODgtG0oDuRChOp1FGuOyUVoeIdtqKMXzIw8wbLiJELu4l57X?=
 =?us-ascii?Q?0TZ+VR6c5kqeno9tYzoAkq/fLN79LxTJyCd7E6zEhVFzMggqzzdMTqr5ZVQ+?=
 =?us-ascii?Q?15LhxSoV9WLpY0UuO+QEFR0oq3sKupDnBkAkzZyrkDl7BGJcsUmK4/+WRrJP?=
 =?us-ascii?Q?exVzxn+Xx9dwAacgXkUyxxMFdWHfdjAZPuezljgY3WeY+/rBOhVs1UxbQUdM?=
 =?us-ascii?Q?66UNYAJGTcz6axDDX4wo8NBY24BYRa0v/0KbW1f+lLpQolT5Rf1fhoqMwIBA?=
 =?us-ascii?Q?Zs3hm/hsnWM/A6aVZjlFrYjR+ecsba/5g2TC+vqlDKlUNXYx/lBaTGAjJo/h?=
 =?us-ascii?Q?PXvJnQAR3InwopTjxdteO7QTADfaLwg9e7+wKIM1AHoyVrL+6AYtP9RRt4Ub?=
 =?us-ascii?Q?SG/6qKmZPCHE2NmbmalcLXzI0oasJUDtE3jZQflpaX6jMcz7l5k+I91UnD8f?=
 =?us-ascii?Q?ARXR+yNW++Q8lVg5XVfGNiXxyyRAziiH5S2Xl9nxJg1r3GgM/27q/qI6m6PW?=
 =?us-ascii?Q?2geW8O8/4uCbaJeM/ej7KLs/P6Gi9pPsThyIhbaJ5oN9mkGx0c9QzxZOJQ19?=
 =?us-ascii?Q?xEfE0XTmb8u4eP0p3n2BZwu5pFzLwqx34fU3XJtmmYjaE7Lo8HxeFzvmGdEn?=
 =?us-ascii?Q?d6YGVIs5uS2LamOLHLpmc17qHGBTF6BrciNobMNggulgZjlDWO6ntUwTVZ+5?=
 =?us-ascii?Q?Exeb7hDzArCIHHj5g6nnaMTzqpVtB7PHCZG2Cnp2mxx4VfeHHcGInLHp4T9i?=
 =?us-ascii?Q?6DifXQ1C7cQaCu5AjaG8kM8EcXgkDjx+Cir+pZpDk3fDw9jV6enuj1mGZ7ww?=
 =?us-ascii?Q?3z0V3XZ5LyezjngmjDaYGZX3/o5ZIWeXIsdUdktCv24mwu5SiI+ocOfhZGVX?=
 =?us-ascii?Q?rNvfdqkRVFfrice6WpAeE+fArsFtZmV6rCsqGJWUWFZ8ZMxjdKx4iTacou6F?=
 =?us-ascii?Q?i6VD6Q5z1KNIULZftmHbuVgiKJ5Dz/lNGbMGMtUIAvMQffGqJvzLHBvtTzyJ?=
 =?us-ascii?Q?FYdYrlvrcxaSvEJ6snKej1PuJHc3T0XMxPyTzWKx7nFjUAYH4aF4qx+zjTgA?=
 =?us-ascii?Q?u2q6WwW3j1Zpuql5D322r1MXdVrYP9movEnQ2tO73Bj0+cVf5BCFRS0IehZN?=
 =?us-ascii?Q?t11nqCwjI+OY2tp4mV+pZaZTMQMck+PLdhlREf4uhCPCSM4Xe/YwR7pYgijm?=
 =?us-ascii?Q?w5k3NE2DIpcPmWLQJN0CazoyIN7XjvSmjXW4DZtL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7d3eea8-83e4-4f93-8df9-08dbc3710f05
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 17:57:35.3642
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z1Hzxp2I8ZmjJJghQyF+5j1LN7HhiXWGEc+v8egecJI93U3hnbfjxCFiw1GITmqje1VPazXJ6Wu8cZfrn/kIBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6512
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 12:03:51 -0700 (PDT)

> Including placing most of the storm tracking code into threshold.c
> instead of bloating core.c.

The lkp test robot complains on a randconfig build with:

# CONFIG_X86_MCE_INTEL is not set
# CONFIG_X86_MCE_AMD is not set

about some undefined symbols.=20

>> core.c:(.text+0x1130): undefined reference to `storm_desc'
>> core.c:(.text+0x1634): undefined reference to `mce_track_storm'

Simple fix would be to move definition of storm_desc into core.c
and provide a stub:

static inline void mce_track_storm(struct mce *mce) { }

for the case where neither INTEL nor AMD is configured.

in internal.h

-Tony