Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 2 Oct 2023 12:43:10 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc:     maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: BUG: maple_tree: KCSAN: data-race in mas_topiary_replace /
 mtree_range_walk [EXPERIMENTAL PATCH]
Message-ID: <20231002164310.bi62wfekacfxb3ve@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <9c1549f9-78c2-441b-8617-3ea3c080a5a4@alu.unizg.hr>
 <20230922135155.tqrelea66hcj5cog@revolver>
 <5d908c60-88fb-49c0-a150-bfb468eaa513@alu.unizg.hr>
 <20230928195926.ucp7it3c3c75erzk@revolver>
 <5a30110b-2457-4638-8779-baa33326f6a6@alu.unizg.hr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5a30110b-2457-4638-8779-baa33326f6a6@alu.unizg.hr>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P2f4V0fjJ2hD+w2dCGHjWgpwdQ5f+yQZp/oUImboBt8ih9hNsYHre9AhtD1c?=
 =?us-ascii?Q?hOaMMC2v7lrjW+ALEjj+RWra++01PZ0ABZE1+xeX54DsW5tXgJZ8o3qJ0u3Z?=
 =?us-ascii?Q?Wzi6K/eUmV4clpyBwPxsK+uB2TwSryb84isr15fzoucVv8b2ef3g4/ayEymW?=
 =?us-ascii?Q?2V5Z6z3andjyNcNoulAuOP3C5WQ7U0QGibiEDGlxI88i72WZtuJS0V6OZLZc?=
 =?us-ascii?Q?hT+uhNLMUvB7UIqI+DbmziYsOAzRqp9m4lwK0rTAWUFdc+mi3YO1sVVzUX8A?=
 =?us-ascii?Q?dM7xiAqOBHGTvTGChOHGiQVT4jxbbMExr8JKWcVl/Q/pgaWFvzC3kUPIecrO?=
 =?us-ascii?Q?8nYzZk3mMTWwIqT7Crowfc6B1s8+YDsIUiqCUHkzUw4VL0p1qebKsQcnaaSp?=
 =?us-ascii?Q?xorX547slIWRjevnFsWV6QsjtdkW3SVf0R4Bd9gnaPJ8Pi2BT+0gBqzBLDr/?=
 =?us-ascii?Q?Ulzoh5nDowWmNIIjmHVRvhjDZRfXct8tc9VSP9e/K7BAFf+yF/djCLLHmhTn?=
 =?us-ascii?Q?dMhgpaJhOv9Xu1+q1oV+9i4c0MvC3UmmBMaCNZAiFZZNIdvecFR246cp+l8x?=
 =?us-ascii?Q?wNBJv9jE4FVy+e9y97Rj6Zup466zw/bib+ohFD/XV5iFv8SFKrNBxG4y/LpC?=
 =?us-ascii?Q?sPXJ5hJtLmBKzYDxguE8BIHceV8DQiOm/YRjodZQBTxt1M2zYm2JMZjKHHUq?=
 =?us-ascii?Q?ersVVVyCc2gjMphpBt2gRE7/raSZ3hjqF1xBCmC1kJdJ8kZKE8WUbHeBSxtp?=
 =?us-ascii?Q?76EQt+VposIZqVIUBoI25nXAveEeC+b8Z2usTvOF+O0DFpIWWifL5pY+YAIq?=
 =?us-ascii?Q?mnGyfWHzQsdkQ9GZp0GvKr4q6gWIt5ggIS7MNVljTkw3HTSF5sbTQALebaUB?=
 =?us-ascii?Q?CymtxXqouvmC5Po1dp5x5kFqjJsAB/6P7zE8NjqVPVYYkF4EGQSdMcVrQQuP?=
 =?us-ascii?Q?/GoI7l+31FF+HsnCaibfb27wG4Z6KVmRYtzX36R5mSSqcXAZbxmWysLvrzzY?=
 =?us-ascii?Q?dltWiguNemcqoeR5Bti7cKOkKtw2//lIQEE812Cv6FmbEKBPsfkLUxxsxFr9?=
 =?us-ascii?Q?+n3y9bZlbd2bDgIPGInF3bhB/Z/CoPisQ/nLhyx6TN7XxfByjBdaRiTV9cAi?=
 =?us-ascii?Q?MfR5nbnluvT8jGmSJ2SBXFl/roT+L2CzqU14zpFO5B20DBBuLTIPiNFqsu3O?=
 =?us-ascii?Q?3snU5tMGu6/xf+pKhJGIlShXRXIuhKVAyamnrInAT3k0RIebGCUmY5UohcDF?=
 =?us-ascii?Q?Sd3EYRpznocm4CHw6netzpvDMDhgNN7yRA4I3IfQ7eC2QEC8ZKLhSka/i1ZD?=
 =?us-ascii?Q?KNzhvt2Fi6uzFRD6N3QVTFWlgJRUGKS2Tdef+rcdBhRnZJWoFVzwR+W9+zzD?=
 =?us-ascii?Q?xlQXBt2Y8cmdpIHiBSUZ8FlZf/LLeb0bz4RjdEEkDrL7xvdZ7CBl19GjjxjK?=
 =?us-ascii?Q?FBPxsszt9YlIgJ/MuEDtAxaWdmSaMUmPuZH7WiXMBXhza+wkJTAKFx0A34vh?=
 =?us-ascii?Q?w6HvlxHeItvMRACs3EKM9sd1mxxZIlOeubKU4hpWzC6sCsGN95hW5UakE6PN?=
 =?us-ascii?Q?q/DjpDh2/jBSbzMYJ8ecBT8dlmSoXDdx8z3ZV8oN?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p/A7pmaWYAYZ0KxHa9RnS+5p+bkhjiJ6igp4VVjy4xP2e5W2faod20HUlhw1FEPUYU0cFZ7U516Gp0AuTLiFS/AE2HUCLCXg5I2H7qU8Vkpoi5+px9+AakPcXonscPUbgQqQ7Vtmtm3lNBImOzICyoSIhF8r3hGflZkHWuJYUjKms7jGM8LQ83vBt3Raakz5dx0HrEiSgptWaqsf62QRm8NCWrdfmyF3ylLssH6gWPH6aE0GRKQh9ur6V0yVX9AuQDMmqp/OJ2sE1wj6ub4ldAeWA6CtktX+CgqxPoKSJiReqkqYMQALFZPP475D/dsUDbBdjbAvWJ1OAfvijg/2J7WTZ2d8rGaHiFsFy2yqY4iPdMipXvgjqvWgrrOk5KAoYE7xSR+AFOmwmkb8UAJu4rq1uEP22hJBWCVPsUY2OffGelWnGPU1Fa4Xn6rd2yvHceqsmJfqQb55EK8ux82jhkU28OeMNknUYIeStfC6vR9UPV/DJP6Jf4zBsehZmvJo5R8z8HYlKPuYywbuU+xjgBEZjYM/BAnsd0nGv+IJjrEoOqXI5YnNUyLeA2xxlg9EV0y9yBBtLXgh02tk5oZIAFidteJD1o6XjSi/5okGEkm5W0VywsTdMVw2IuNYV0ZNmeq4aa6fu4IQupEgGwY1JhLu8ldy8ZaTvam7/SjUoI9wh9+VBNFlrqkrUYAMqo7Xkne/OyOws3vFIDB98exOJkQvplFuCSUd3fIW1HGhpIzBPvipaMHr63hNiuN10AVS5AV8mW1inD6kzS2G0EgR4e6pmCXxMsPqMMw6rEoG64wr5Tq5++CosOqAPkYZKFfq+8j4dpEdtBiL8vb/9SjaEjHSZJD8ZSsHuX3qvOmyXkcMVIM90GLfXVhYUfXDef+c
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2a96d82-775b-4327-c36a-08dbc366aaf4
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 16:43:12.8308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ockw3UvBZFv08yLqJWAWB/m/g7sIgAr3AX+kQvx3fmBZEa/yQUGer/MB4ukDCZTKxs93odYwR64srdEhwZohCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6096
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-02_11,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310020128
X-Proofpoint-GUID: _HsWoX3qYTaeZrqAdou0C405Pnxh64j_
X-Proofpoint-ORIG-GUID: _HsWoX3qYTaeZrqAdou0C405Pnxh64j_
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 09:43:45 -0700 (PDT)

* Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr> [231001 17:09]:

...

> 
> They say that one patch speaks more than a thousand words.
> 
> I am just running this little patch that actually silences all of the KCSAN warnings.
> 
> I cannot tell if these reported data races are the actual bugs, but it is possible that
> the Ubuntu 22.04 gcc is doing some funny stuff when optimising. In Prof. McKenney's
> book I've read about the load-tearing and store-tearing. AFAICS, memory barriers should
> prevent load/store reordering, but not the compiler optimisations.
> 
> Please find two versions of the patch attached.
> 
> While mas->index and pivots[offset] in maple_range_walk can change concurrently,
> I am not smart enough to see whether you expect that in your algorithm or is it a potential
> bug triggered by GCC optimisations and aggressive Ryzen 9 7950X parallelism.

None of this is necessary, for sure.

I will have to look at this when I have more time to investigate.  This
will likely not be soon, however.

Thanks,
Liam