Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <daa44585c4a57b8823cb260d9ec9bd3f59f410c6.camel@linux.intel.com>
Subject: Re: [PATCH 2/3] platform/x86: ISST : Check major minor version
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Hans de Goede <hdegoede@redhat.com>, markgross@kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        platform-driver-x86@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Date:   Mon, 02 Oct 2023 06:54:56 -0700
In-Reply-To: <45625e9e-997b-eba1-413a-43a7d835feb@linux.intel.com>
References: <20230925194338.966639-1-srinivas.pandruvada@linux.intel.com>
         <20230925194338.966639-3-srinivas.pandruvada@linux.intel.com>
         <f82fcfc9-eb41-56cb-93e1-abf9cf7413@linux.intel.com>
         <72a2766bc7bb4f9d6b3d5f2ff114f0af1b6646a4.camel@linux.intel.com>
         <45625e9e-997b-eba1-413a-43a7d835feb@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-3.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-10-02 at 16:49 +0300, Ilpo J=C3=A4rvinen wrote:
> On Sat, 30 Sep 2023, srinivas pandruvada wrote:
>=20
> > On Fri, 2023-09-29 at 17:28 +0300, Ilpo J=C3=A4rvinen wrote:
> > > On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:
> > >=20
> > > > Parse major and minor version number from the version field. If
> > > > there
> > > > is a mismatch for major version, exit from further processing
> > > > for
> > > > that
> > > > domain.
> > > >=20
> > > > If there is mismatch in minor version, driver continue to
> > > > process
> > > > with
> > > > an error message.
> > >=20
> > > This sentence sounds odd.
> > What is the suggestion here?
>=20
> These things sound wrong: It should be "continues"
OK

>  but I also find "to=20
> process" odd when lacking what it processes.

Further processing means, whatever this driver is supposed to do. You
don't want to fully explain again what this driver is doing.


>=20