Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Phillip Potter <phil@philpotter.co.uk>
To:     devnull+j.granados.samsung.com@kernel.org
Cc:     Jason@zx2c4.com, airlied@gmail.com, arnd@arndb.de,
        clemens@ladisch.de, daniel@ffwll.ch, davem@davemloft.net,
        decui@microsoft.com, dgilbert@interlog.com,
        dri-devel@lists.freedesktop.org, dsahern@kernel.org,
        edumazet@google.com, gregkh@linuxfoundation.org,
        haiyangz@microsoft.com, intel-gfx@lists.freedesktop.org,
        j.granados@samsung.com, jani.nikula@linux.intel.com,
        jejb@linux.ibm.com, jgg@ziepe.ca, jgross@suse.com,
        jirislaby@kernel.org, joonas.lahtinen@linux.intel.com,
        josh@joshtriplett.org, keescook@chromium.org, kuba@kernel.org,
        kys@microsoft.com, leon@kernel.org, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        martin.petersen@oracle.com, mcgrof@kernel.org, minyard@acm.org,
        netdev@vger.kernel.org, oleksandr_tyshchenko@epam.com,
        openipmi-developer@lists.sourceforge.net, pabeni@redhat.com,
        phil@philpotter.co.uk, rafael@kernel.org, robinmholt@gmail.com,
        rodrigo.vivi@intel.com, russell.h.weight@intel.com,
        song@kernel.org, sstabellini@kernel.org, steve.wahl@hpe.com,
        sudipm.mukherjee@gmail.com, tvrtko.ursulin@linux.intel.com,
        tytso@mit.edu, wei.liu@kernel.org, willy@infradead.org,
        xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array
Date:   Mon,  2 Oct 2023 22:45:28 +0100
Message-ID: <20231002214528.15529-1-phil@philpotter.co.uk>
In-Reply-To: <20231002-jag-sysctl_remove_empty_elem_drivers-v2-1-02dd0d46f71e@samsung.com>
References: <20231002-jag-sysctl_remove_empty_elem_drivers-v2-1-02dd0d46f71e@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> From: Joel Granados <j.granados@samsung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> Remove sentinel element from cdrom_table
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> ---
>  drivers/cdrom/cdrom.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index cc2839805983..a5e07270e0d4 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3655,7 +3655,6 @@ static struct ctl_table cdrom_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= cdrom_sysctl_handler
>  	},
> -	{ }
>  };
>  static struct ctl_table_header *cdrom_sysctl_header;
>
>
> -- 
> 2.30.2


Hi Joel,

Looks good to me, many thanks. I'll send on for inclusion.

Reviewed-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil