Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sun, 1 Oct 2023 13:33:09 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 2/5] mlxsw: core: Annotate struct mlxsw_env with
 __counted_by
Message-ID: <ZRlK5Rtt3PIa7wyr@shredder>
References: <20230929180611.work.870-kees@kernel.org>
 <20230929180746.3005922-2-keescook@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230929180746.3005922-2-keescook@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xtJSA/59FxB2ZGrho8pfnz/vauK3FMVWctjXjG9r3Tj/Wb59R+I8/V34GWW6?=
 =?us-ascii?Q?NT+7FWB3nVcIS1xrYdfBbnoZoAHKRVKW4FsmGAEIuXYFWISnkugjJHaYgIRw?=
 =?us-ascii?Q?mgzUpwG5RJN3Pmwm0YvxUFPeJWPp/OuRW79VvNbosJjQQ19nlAq1XmLtqc7S?=
 =?us-ascii?Q?jj6kZkTri/lPirOiCZjM9v63JhR2YxeatXWq4nLn7n+xspSgQPuaVyAJ8Ppw?=
 =?us-ascii?Q?j1bDtmi7ZQiBfYiOtDUSQnTgrtArmJ68yfnhL9/mi2nYkPWEP9V/ewdNRUNc?=
 =?us-ascii?Q?LkHMsjTcpky9mjvT0ciVW0GBjRWY0LvhmQN8fDtc3hc3+10R57E4oUg990Ro?=
 =?us-ascii?Q?01hizbumcn7b3UKdK9sC4WeDCzbYPN3askNF5nECLnO0ErpyOMN05zsr4iK0?=
 =?us-ascii?Q?SofFoBj4STr+LfJji0JqvBe6HIgZL7Bu/2QG42/iy0wdPMfszTHpnhIzKigf?=
 =?us-ascii?Q?B8iFt8TX/tqdHkLIp/ZOzGgp/0uhWGFyW0qjiMSIBZlNOUgdBozVNfcZzKw2?=
 =?us-ascii?Q?gB/UDPmuGqcT1kbNsc0irY6A5m0l++ZWqkGmN2V+weOwtfDt0LvOSz1h+gJu?=
 =?us-ascii?Q?7oqe+25fCB0WXvkFsawr3itoGZh/6V416Ii1chBDW9PhIcShma3ys47Z2V+7?=
 =?us-ascii?Q?+bJQnxet/IiBVCgwdwvw812fHYkep6b46XVP7gdVuixMLo++iXe5HYdHJeRE?=
 =?us-ascii?Q?c06lg+lnlOujgIILA0i8FqLtmPfxiC03RP1ucHu/3cGsPUN/k7hmJbBaLfhs?=
 =?us-ascii?Q?du8jlhdiz0NbpEnlsPQv8Vx9WrkYDMCDxkEHIcUmH/mvl8KSjpG3swsCVkTR?=
 =?us-ascii?Q?jHpDfKSFYtwnc2OxuLZLjckcNv4zoBvSR2R4fXarPPMa/izdeA6z2Bg4I287?=
 =?us-ascii?Q?Do/NW7HqgATV3JTNRINFsowTntflB1byjcedCY82wEaWPtK8mJ6wiiCkZVsP?=
 =?us-ascii?Q?UFetbLLMX+Q48VPCgPCWkGFtaxT9Wvu3QFVX4zIojr0w9hNKFan72wY6Dup6?=
 =?us-ascii?Q?hJKYvy+1ZWyDAE7HcKqFUZJWeCdg43m16CJX2u5Ptnuk2q/SUJGJg1AeI6Kf?=
 =?us-ascii?Q?+ogJNQjJX7HkxcP8MO1WwDCnvB1tN7k7qHCAulONhMcwsRZ4OibD4P4ORw7z?=
 =?us-ascii?Q?qtxQYTYUS7lWPGKY5RShrb17GSn898y+I7adGUKezACYySXflvkN9t1jjCdG?=
 =?us-ascii?Q?uQ0hWiA0YMOdYHdiGdRGbEjb0b1rVs4bcUX/TsBiR7Yq0Cvdhu0zn1ptV2G0?=
 =?us-ascii?Q?NwSY1k1BG8nC0DOz98L+++WogrHqe7RYbZEOGPi2U1Q4/BSCFShyC6WK46Z7?=
 =?us-ascii?Q?198QRBM6ePcZHByDMgX0vxNK13xho3rIUh0x5KzuM04vWTIP2etRaFGkmpyg?=
 =?us-ascii?Q?XfaPL6IIiDAaBwpGcUEdC1WnSLUrk146cDVBtGJqxMdJJh+fLw1PWWgFr5tL?=
 =?us-ascii?Q?rwvIzhYmwSInSAxMkvQrg/ZQUMid9O6qYrxQYkman1An6+DgmUVXpo5flJYt?=
 =?us-ascii?Q?R2qcsJk26/kcINmdz70Tz2OTv6o1upDnYriEmdTH4GPJlIOyY6DbgVdkolYW?=
 =?us-ascii?Q?nvj3FC2DozkddXSNME0ru1nWKvVw+NRp/GeT6lOI?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e3b4a8-01ba-438b-1cd7-08dbc269d1a0
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 10:33:14.8354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f62ed+QOib0kckEQ8N0k076ndxlzLtU0ZYFiiWOI19EybbARB5y2JwDS0l0+bkDUuW3BeqR/yEclPSsTjLOaBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6266
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 01 Oct 2023 03:33:29 -0700 (PDT)

On Fri, Sep 29, 2023 at 11:07:41AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mlxsw_env.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Ido Schimmel <idosch@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>