Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231001054736.1586001-1-masahiroy@kernel.org>
In-Reply-To: <20231001054736.1586001-1-masahiroy@kernel.org>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 2 Oct 2023 08:55:13 -0700
Message-ID: <CAKwvOd=9vxXWwtDxuAmhBO_-c9vhF1rwYyOo8e9EY2x2B1m-iQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] modpost: refactor check_sec_ref()
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Sep 30, 2023 at 10:47=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.=
org> wrote:
>
> We can replace &elf->sechdrs[i] with &sechdrs[i] to slightly shorten
> the code because we already have the local variable 'sechdrs'.
>
> However, defining 'sechdr' instead shortens the code further.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
>  scripts/mod/modpost.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 2f3b0fe6f68d..15d78fe152ac 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1523,16 +1523,17 @@ static void section_rel(struct module *mod, struc=
t elf_info *elf,
>  static void check_sec_ref(struct module *mod, struct elf_info *elf)
>  {
>         int i;
> -       Elf_Shdr *sechdrs =3D elf->sechdrs;
>
>         /* Walk through all sections */
>         for (i =3D 0; i < elf->num_sections; i++) {
> -               check_section(mod->name, elf, &elf->sechdrs[i]);
> +               Elf_Shdr *sechdr =3D &elf->sechdrs[i];
> +
> +               check_section(mod->name, elf, sechdr);
>                 /* We want to process only relocation sections and not .i=
nit */
> -               if (sechdrs[i].sh_type =3D=3D SHT_RELA)
> -                       section_rela(mod, elf, &elf->sechdrs[i]);
> -               else if (sechdrs[i].sh_type =3D=3D SHT_REL)
> -                       section_rel(mod, elf, &elf->sechdrs[i]);
> +               if (sechdr->sh_type =3D=3D SHT_RELA)
> +                       section_rela(mod, elf, sechdr);
> +               else if (sechdr->sh_type =3D=3D SHT_REL)
> +                       section_rel(mod, elf, sechdr);
>         }
>  }
>
> --
> 2.39.2
>


--=20
Thanks,
~Nick Desaulniers