Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <b9201868-192a-4ddf-b739-9f8d93b49a75@intel.com>
Date:   Mon, 2 Oct 2023 08:46:31 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH v1 1/1] ACPI: NFIT: Switch to use
 acpi_evaluate_dsm_typed()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Michal Wilczynski <michal.wilczynski@intel.com>,
        <nvdimm@lists.linux.dev>, <linux-acpi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>
References: <20231002135458.2603293-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20231002135458.2603293-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djh3U2NleVp3M0ZTQkswNTBuUDFDRUdwRVNTQmU5QVR1K0RodE9FUW9pamxZ?=
 =?utf-8?B?TzhlTmNHZm9hdHdJVVVzQzJHM2M0UGtkZ2lwOHFycFpBbmFQRkM5YzRIYy96?=
 =?utf-8?B?c1NJZWNkVktOTko2TkFWMzhET0tBMFNVUFZEY05QdXdXTXpKMDZZMHBmanJU?=
 =?utf-8?B?WWpVbW9HNEwzLzFSV2NLSGhSdS9tOGR5LzRVZ3R5Q1lHRE9vcjFoQUZVWm1h?=
 =?utf-8?B?RnlFK2hGTGkrTDVDbGorTDVvbCtBUjJkcDFHWDJKTjNUSmlNY0gvRFJtdEZh?=
 =?utf-8?B?amhrNnozV2lyTFNaTEdMWTlFT3NuSzV5ekh6MEZvTDZsVmN4VFdVYzg0d0dL?=
 =?utf-8?B?dHRVbmRPNGtLUnRLR25FWlBvbkg0SWVhaitISk1sODdWNnBiKzQ5cVN6ZkFx?=
 =?utf-8?B?ejR6bitwM3V3WE1ZODhvR1VqRm9OSzJhRDNwQ2tLaEZnQVlsU3lqemdTdTFs?=
 =?utf-8?B?RUZSNWdhTkdrcVhxMWR2VVVhbzEybVFPQkNFRmlsVnFpRGZTYjB6QkhWS3A5?=
 =?utf-8?B?TmFSTXZlOUFkWUR0clNQMFB1Mm9hQmttRllLV2lGemw0MXRibERXdmFuYUJ4?=
 =?utf-8?B?Vk1Rcy83Z2ZaTWErWjl3K3hRWDZnWnBQQ2tLdXdqZVlPOVFLUVdwc3dBMDFY?=
 =?utf-8?B?M0N6R0FGeUNiL1JTcnNmdW5Yam9XWFA0cWxkVEh3ZlFRcTdwNE90cjBYekxE?=
 =?utf-8?B?Z0lzc05QLytCWE9YOUJKeTcwL3pnV2h5bHRoay9MSk9IK015T2YwdUFBUWdI?=
 =?utf-8?B?S1cvN1hHaHBmM0MyQ2tLVmtWbTJKaHl3c1VjUGpTeVErMFAvTzJEejJFU21G?=
 =?utf-8?B?cjZIWlhEZU5BM1VLUk53Mzg2SnN1SU1kVmxlVUhPTTZETE1RdVRtQlFQNmNZ?=
 =?utf-8?B?UFpRSGppTzVmRDJPLzZVcVYvbUM2VDVEZXRSR0I4TEZ6aGNqbm9UK3VwTmY3?=
 =?utf-8?B?dDVVOEpzVGFvSGRyY2k1dC9DWjZEcnRWUi9HdG43cEk4MDQ0RWlSUkM5dGgw?=
 =?utf-8?B?Nkl1VVNvL2xWK1VJTFc1SkJVa0gxc3dCMTZ4T0UrdjBtTVRUTE1Zc0lyenJH?=
 =?utf-8?B?NkhDMXVKcUpMaDF2THZXNzNzZ1hwajcrYnBJRW5xY3Q4YTF2eGFOd3plVnpi?=
 =?utf-8?B?ZWUrQW1HMXFYUHlSTGtlanJXZjQrclRaeHFFNE1BQW4wcjhrTHVibzZ5NjZZ?=
 =?utf-8?B?cTVuQlZ3aGJRY1RxY1ZPajRFU0tHc3J0bzVVSXBidS9nNUc1bldxRE5uNWpZ?=
 =?utf-8?B?bjBMWmR6T3F6TEZONWNOK2xNU2tsNWI1OUNCeFp1Y0QyMTlHcHFDeW5DdkNx?=
 =?utf-8?B?RmpicjNhZjNSRGYvMWNJd2tER016T09EZkhxWS8yWTZpellvU0ZSd2kzT2gy?=
 =?utf-8?B?VE03dVhRaG9vVm5GaTZHaUI2SzdkZlBCUkVmazdodUZYb1NOK2NTaXlsU010?=
 =?utf-8?B?eUJqdy9kSjc5eHpQUW1uS3NpNDEvelYzOFlNZ2NnVy9SUnpaZ2s0TDdqYmcw?=
 =?utf-8?B?UlNRTDRWNzRWb2svckNNc0k5OGJaaWhhbGNBeVo4Vzk5NWN1T3VRZHVNalo0?=
 =?utf-8?B?eklMU3FQQWpNSkxIYTNYd0hlM3orZlU2MkxoeURsdG44S3Q0WVZZVUhDNkVN?=
 =?utf-8?B?a01COXNJNWQweHF4bTBhZ01ZNFA1YjA4ZDQxNEs5MXhRUVAwanBxalNhLzFl?=
 =?utf-8?B?bWlYSXNPVFQzKzJqdFdhNmFFTnVPWHRteEJMZDYvNnlocTl3c2JNaFQ5a1o3?=
 =?utf-8?B?OVd1Skc0dGw4V0kxUXZQRWhoclJLaklQTkZXTkR5VDUvdXhJb2ZwL3JnMnF2?=
 =?utf-8?B?OXhZbDR2L1hDeHJCenhQcWxOUkdJT21Na21QdFlkdlhaSjNYOHNSVGxpaHVz?=
 =?utf-8?B?NVg3ek44SVZQcURoTlZwT3FVckZNTEZEQjRWZEVTcmE1Q1dQdXlYYUllR0N4?=
 =?utf-8?B?aXFBUHBwY1E0MHltS2JQNnh3TWJvVlhOR2p5aUxOa2daUEpSY2dGUUphUGZ1?=
 =?utf-8?B?cG1ycTNBU1NFOUpFMUl0NVhXay9YOEVlYTZudWdNd2tiTDNGVi83dzNDTHRv?=
 =?utf-8?B?SjNWTnJsMDVweG83cXBVZ21nZjFKQlB2NnZGZkpLdzJ4NHFIMWpTSDFCZ0Zz?=
 =?utf-8?Q?K+3iOnZ9gUOUjJB+5gyNk8bDP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a4f4718-5aec-4eea-bdde-08dbc35ec193
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 15:46:34.6728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cv9be5u+plKsd+Y2jTAcHiCipFToC88M2kve80HWh+pxvRHuTmzZDqrTNg/ubWF0wZO7jmKJJi7sHvELC3uCpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4750
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 08:46:49 -0700 (PDT)


On 10/2/23 06:54, Andy Shevchenko wrote:
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/acpi/nfit/core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index f96bf32cd368..280da408c02c 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1737,9 +1737,8 @@ __weak void nfit_intel_shutdown_status(struct nfit_mem *nfit_mem)
>  	if ((nfit_mem->dsm_mask & (1 << func)) == 0)
>  		return;
>  
> -	out_obj = acpi_evaluate_dsm(handle, guid, revid, func, &in_obj);
> -	if (!out_obj || out_obj->type != ACPI_TYPE_BUFFER
> -			|| out_obj->buffer.length < sizeof(smart)) {
> +	out_obj = acpi_evaluate_dsm_typed(handle, guid, revid, func, &in_obj, ACPI_TYPE_BUFFER);
> +	if (!out_obj || out_obj->buffer.length < sizeof(smart)) {
>  		dev_dbg(dev->parent, "%s: failed to retrieve initial health\n",
>  				dev_name(dev));
>  		ACPI_FREE(out_obj);