Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 2 Oct 2023 10:58:32 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     "Huang, Ying" <ying.huang@intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Zi Yan <ziy@nvidia.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] mm: page_alloc: remove pcppage migratetype caching
Message-ID: <20231002145832.GC4414@cmpxchg.org>
References: <20230911195023.247694-1-hannes@cmpxchg.org>
 <20230911195023.247694-2-hannes@cmpxchg.org>
 <87y1gsrx32.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <20230927145115.GA365513@cmpxchg.org>
 <87pm20p9ra.fsf@yhuang6-desk2.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pm20p9ra.fsf@yhuang6-desk2.ccr.corp.intel.com>
Precedence: bulk

On Sat, Sep 30, 2023 at 12:26:01PM +0800, Huang, Ying wrote:
> I have done more test for the series and addon patches.  The test
> results are as follows,
> 
> base
> perf-profile.children.get_pfnblock_flags_mask	     0.15	(+- 32.62%)
> will-it-scale.1.processes			618621.7	(+-  0.18%)
> 
> mm: page_alloc: remove pcppage migratetype caching
> perf-profile.children.get_pfnblock_flags_mask	     0.40	(+- 21.55%)
> will-it-scale.1.processes			616350.3	(+-  0.27%)
> 
> mm: page_alloc: fix up block types when merging compatible blocks
> perf-profile.children.get_pfnblock_flags_mask	     0.36	(+-  8.36%)
> will-it-scale.1.processes			617121.0	(+-  0.17%)
> 
> mm: page_alloc: move free pages when converting block during isolation
> perf-profile.children.get_pfnblock_flags_mask	     0.36	(+- 15.10%)
> will-it-scale.1.processes			615578.0	(+-  0.18%)
> 
> mm: page_alloc: fix move_freepages_block() range error
> perf-profile.children.get_pfnblock_flags_mask	     0.36	(+- 12.78%)
> will-it-scale.1.processes			615364.7	(+-  0.27%)
> 
> mm: page_alloc: fix freelist movement during block conversion
> perf-profile.children.get_pfnblock_flags_mask	     0.36	(+- 10.52%)
> will-it-scale.1.processes			617834.8	(+-  0.52%)
> 
> mm: page_alloc: consolidate free page accounting
> perf-profile.children.get_pfnblock_flags_mask	     0.39	(+-  8.27%)
> will-it-scale.1.processes			621000.0	(+-  0.13%)
> 
> mm: page_alloc: close migratetype race between freeing and stealing
> perf-profile.children.get_pfnblock_flags_mask	     0.37	(+-  5.87%)
> will-it-scale.1.processes			618378.8	(+-  0.17%)
> 
> mm: page_alloc: optimize free_unref_page_list()
> perf-profile.children.get_pfnblock_flags_mask	     0.20	(+- 14.96%)
> will-it-scale.1.processes			618136.3	(+-  0.16%)
> 
> It seems that the will-it-scale score is influenced by some other
> factors too.  But anyway, the series + addon patches restores the score
> of will-it-scale.  And the cycles% of get_pfnblock_flags_mask() is
> almost restored by the final patch (mm: page_alloc: optimize
> free_unref_page_list()).
> 
> Feel free to add my "Tested-by" for these patches.

Thanks, I'll add those!