Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <VI1P193MB07524537938FED1D665FBD6C99C5A@VI1P193MB0752.EURP193.PROD.OUTLOOK.COM>
Date:   Tue, 3 Oct 2023 02:24:08 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] fs/jfs: Add check for negative db_l2nbperpage
To:     "Ricardo B. Marliere" <ricardo@marliere.net>
Cc:     shaggy@kernel.org, wonguk.lee1023@gmail.com, liushixin2@huawei.com,
        andrew.kanner@gmail.com, wuhoipok@gmail.com,
        jfs-discussion@lists.sourceforge.net,
        linux-kernel-mentees@lists.linuxfoundation.org,
        linux-kernel@vger.kernel.org,
        syzbot+debee9ab7ae2b34b0307@syzkaller.appspotmail.com
References: <VI1P193MB0752E63048A98BC70E4CFA9E99C5A@VI1P193MB0752.EURP193.PROD.OUTLOOK.COM>
 <c52zvpisqgy6nvtw3fku342z5aqmz5gucfagaup2tflw5ia5d7@vbeanlsfhgqp>
From:   Juntong Deng <juntong.deng@outlook.com>
In-Reply-To: <c52zvpisqgy6nvtw3fku342z5aqmz5gucfagaup2tflw5ia5d7@vbeanlsfhgqp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VI1P193MB0752:EE_|AM8P193MB1092:EE_
X-MS-Office365-Filtering-Correlation-Id: 0a8dc038-ac05-4bf9-b102-08dbc374c50f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: e7IL1yChg7P0d8dkjpxrpeTbPq270IdAlKeYmO069opl5ToLF9pVRi64WAoy48yjvCCKBm+PFDxc0bBXJ3UCOutttvwhWIHevCTjUG5ED+3S8Q9PsA7fOLtUyrhX8DvR7tpJp8w9nzaUYnpEI2YIXWrNBgQ1DjHtbFJWGP1yVu57hvA78Z0zwRpBrNhBfYUdm32J5+ZX+Ne/wijU4gLvbJoLSAHtzhQgvjNJZKAfwsH3WjtV8L5ZN5f8eY6JwmsJPdyFeOG62EJ6bGgwCT8S+UUUa/cg1Fx/cUwwmKvHaMlvk/cu83sd80BFuBkLdEjy3PVOV7rDCQCH9VijizJ8FUyPH0x2nimmitkQOamxizvexUj4bXTIkbax5Y0Yckwkp7jqDsn7s5HXCQMyA1lQiOvq78dgwEZeRzjQAz8x861+BN65d8b+/e64xc6Qe7Ht1/013bj+Q5mhuwKZSqD3XsDlNZGEAOm0GARhh2Xy4VVe5ohuRJHFQ7GeT4mwkmDO+yLfrkNaWIuTMYLEBg3YjVPygXDzsszzRtlk70uxe9OWAbUJvD/b4Yq1ehgoihG0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmRCREFNN0RQN3ZPbHk4WG1CakZXZ09lckp5cWkxbVNRMGkxYnRhZEJISzVL?=
 =?utf-8?B?ZWlOdHlKd29MNEFpZUsvc3NrajF0Ky9vUHVlS01tYUF1OG5OMndHSC9zbklp?=
 =?utf-8?B?VC9hUjd6VFNqKzdlQXl1VUw1bjgvTlA5OHU5YlZnSVFHSm9sTVc2M2pmSWw3?=
 =?utf-8?B?T0x6bXl2WkZLSnhla3kwUjJDM3pKTGtZSHJFYnhtc2RKb0dPdVZTRE1SVFlR?=
 =?utf-8?B?MzQ0RzBoL0lHSTgrS0RvdUwvNkdyQWJLTnBydFB3cUo0S0prQ25YQjdlS0lZ?=
 =?utf-8?B?WXNpeHpDOXNHd2FzdUU5bG83Y2RudXNTc2psK0dScU1EMFNFenphL1AvZnIv?=
 =?utf-8?B?eDBuWDF5dnh3Zm9UbHdPSnBaZ3Q0L2ExSFB2ajVxbXVVNXFqT0M5M1RmWERE?=
 =?utf-8?B?d0RIQnRDOTlPT0o2a3hoejlrVWFpYU5neDZIM0RtTEtWTUppL2NrZWYzYktw?=
 =?utf-8?B?VVd2STZGeDhVVGRuYUc1aEhpMDFERkg2bk1rNkY5NDZRY3JPT0QwL0hSN2xK?=
 =?utf-8?B?MlZIMm5RVXJiMGM2SFR5bko2VGNhQ3hiNXJMcDRTWWpoTXVObU9xaS95K2to?=
 =?utf-8?B?SnBUT2hmZENVMmdoZnl3d3NrTmZsWmRoN0FXYmc5VmdTNHVJMlpiMVJ3QTcz?=
 =?utf-8?B?L2dLSXNXeXBwcHVsYzhFVFJlVnF5bnROTGZocGZUVzB1b3RMeElFaUhCaXlJ?=
 =?utf-8?B?dFV5cXRHMVMwTG94QStoNytmRkxsczNXYkpUTFlXRWxOTnRsdnV6NTZPTW9G?=
 =?utf-8?B?OHZJbUFOdDZVT2dLTlFaNEhuQ2xNY2FacWk1cUVOMGtFQnlsM2U3SG1oNUVr?=
 =?utf-8?B?Q2F0U2NVNUJtOWVzQzAzZ2hXSGhiRnNnMTdKai9ZbHltbDRwNzRJQXQvRFNF?=
 =?utf-8?B?ZjBFZk9OOVM1RXFENldxMHZlcGtRaTdBSCt2VjhVWmJLc3dYcXd3a0lucGU2?=
 =?utf-8?B?eEdySlY2NEN0NldURGZRdlMxdDBOUGRLSkUrRFZiZGN4dllDQi9SeHhxUWwr?=
 =?utf-8?B?Nmg4MjVVOXJrVmZDMG5BbVJ2NCtqT3JTRDg2V05tWlpRaGNBc0pVU0tmcmVs?=
 =?utf-8?B?NWRNTGZiczhpR0RSeGg1VXBCcDJFOVV2bFhjaUtBTEpyOXJuOEQ0NFJjUEJI?=
 =?utf-8?B?NWkwem5POXU2bExhbGdGSjZKUGJsZGdvbjV5SjBoa3JqcTJWT2JmV0JDOFhR?=
 =?utf-8?B?bWw2SkMwYVgzR0FQUnZEZjVlb2h5QThpSG1ET1QwV1FSano1Tm1wMTUzT0l4?=
 =?utf-8?B?Q0IxRmdUbHJIVnFEcEJQdWpuWU9QSXNOcjRsRmxTaXgxNGxXRGRhaUlvZUgy?=
 =?utf-8?B?RnRSclg3aExRUXk3MzNoR2pOQW1aOGowb3B2TGEvSUpPVTM1VTczWHF3cjcr?=
 =?utf-8?B?eVo3NmhqM2NJb2M2MUVYek5sbnJ6SWNoVXkzYnZKS2hGRUtRSWxmalpRb2dy?=
 =?utf-8?B?OThXU0M2RkdmWWVsVGlYenRoK2ljcEdIcmx3NjhjSzRQamhac1NCdWVVOEdB?=
 =?utf-8?B?M0FJZEMxZmFodmd5eG1WY05vdnErQ3V2Mzk1Ymh1WlJQcElVeHdxSnRkU1Rt?=
 =?utf-8?B?UFZFMWRpNE9EN1lhL0Q2TXdIN01qR0VySTZzbW9HeS8rZi9EdFZVbmc4MjNj?=
 =?utf-8?Q?CWZYb7clrwitVHksgAZSfuRIy6zoK1a5A8s2zhYDYi7o=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a8dc038-ac05-4bf9-b102-08dbc374c50f
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0752.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 18:24:09.5110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P193MB1092
X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_MUA_MOZILLA,
        FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 11:24:38 -0700 (PDT)

On 2023/10/2 23:56, Ricardo B. Marliere wrote:
> On 23/10/02 05:56PM, Juntong Deng wrote:
>> Signed-off-by: Juntong Deng <juntong.deng@outlook.com>
>> ---
>>   fs/jfs/jfs_dmap.c | 3 ++-
> 
> Hey there, looks like you forgot to add a changelog for v1->v2? I see
> you just changed the commit tags ordering but you should have that in
> mind for next time :)
> 
> -	Ricardo

Hi, Ricardo.

I just made a mistake in the order of the tags, I should have
put Signed-off-by last, I did not change any code so I did not
add the changelog.

I am not sure if the changelog should be added if the code of
the patch is not changed.

Thanks.