Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 2 Oct 2023 14:03:41 -0400
From:   Gregory Price <gregory.price@memverge.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc:     Gregory Price <gourry.memverge@gmail.com>,
        owner-linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
        linux-cxl@vger.kernel.org, luto@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, arnd@arndb.de, akpm@linux-foundation.org,
        x86@kernel.org
Subject: Re: [RFC PATCH 2/3] mm/mempolicy: Implement set_mempolicy2 and
 get_mempolicy2 syscalls
Message-ID: <ZRsF/ZoYXH/77XH6@memverge.com>
References: <20230914235457.482710-1-gregory.price@memverge.com>
 <20230914235457.482710-3-gregory.price@memverge.com>
 <20231002143008.000038ac@Huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231002143008.000038ac@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a6jQeJXHkf+s0K8X1ttvlhz0azK9nRhflnDBSCnKm5PsAUcTvyNHTdKKQ6ue?=
 =?us-ascii?Q?bXrhd/KY+2n9QyVO0jXrs31wWrJD+/5KCf5uqo8hGl5F9+Z/r7Rbv154ko+d?=
 =?us-ascii?Q?f5/GE/cXbQ8gHNRI25lhm8wD8JAziM55E9eu85YAnvEk9vADO61jeIxlIv5S?=
 =?us-ascii?Q?gBmCsgrHKP0nrXBG7caTAkgP2yOFd8JSw2kYiD+a/vAd5gLyKgqRkVy8NzEb?=
 =?us-ascii?Q?uioS5clWWA6WKIXuFjFlj0x2j0vPuNDlObGMfXjbu4yzE6wT+3MoA2RsGgnx?=
 =?us-ascii?Q?8oWYfXt5X1HAZ3Slint4+vyO4qCqvnAlht0MQxOEKkQtJzqoRsGbSwsmLsMi?=
 =?us-ascii?Q?ZpkeG10AKTBZ4XQzH0u9Tu+XA3DPELPjYVrgccRUOb7ClZZ5mQHF/HjgDmQt?=
 =?us-ascii?Q?eB/PZq1tLWcQfY0BP/vcqytICjL0jXSLdPmRcxts/sywf0apVzMjZBK3wVR6?=
 =?us-ascii?Q?4hYVVicwjH4ZySECA3g/SPrlRg/o/80OSoO/fZanSAY4vCL2C6RRdG81dM+z?=
 =?us-ascii?Q?VlMHdz/x4lr8N/LrFtGTgrbQgXyiP0LYYVYbGeyTqBQmonm38t0e3sWESkA7?=
 =?us-ascii?Q?Jtew094nNfpkRZBa6f9T/DHvFHowJHUNdCVY+zzg7ffEmx0DEfLH3vXgV7sn?=
 =?us-ascii?Q?0T34OS0N24cx7Kqe+diRsuyTFDNDJ4KHoEvZJmmXj8REO5M27KR3RmhVMTLL?=
 =?us-ascii?Q?7UQYDhSLuAlmi07nv5df3N3klWLnGwpBBtIPIzOK9kzGXZjomRS/ULCgetJw?=
 =?us-ascii?Q?rJ/1i4rKKbRhzYK7a1yMiES0T5Dfyr3UHYP7be5VSMxrNuz47GtUsxOxwjAG?=
 =?us-ascii?Q?7uMfbEWILjkfWUygMRBUIOHZe9HNCxp7MdLGfDxlf+VwjcqsxWF0JBR/qGRH?=
 =?us-ascii?Q?p95o98QkvajU/SstAL4A9y3G8aeMI4iv8BJqO86flXw+AywlPplpyYPndoR4?=
 =?us-ascii?Q?gOuezqDjWdZ8LdNL9rl/RSfureW1bDJjU+dZz4C2J0YGkXRogrh71Duj/7wK?=
 =?us-ascii?Q?6stnf/Sg4N2xfXgMY3IoIpx36pbnFLYtSlxeCLTNxvXolMuE0aXYWdfNO3by?=
 =?us-ascii?Q?YyQe8e4YyFxjXRuKsff0mzZAjQ9tpxO5oaEt2grOSWrPJIGLgFwBqay5XxKZ?=
 =?us-ascii?Q?tDt9ZJ4Y0TCdiWB9FaCyd+DUmaR4z8UZvK8PIOXVBI5pJZ+6KMTO6S2K02nL?=
 =?us-ascii?Q?ORZITkTyKspYLvNQtpSMliMwv6Gw2nixFxkFXkhh13m1YF5UJZsKGCKnCyfa?=
 =?us-ascii?Q?tWLZaAzhg2NPfTJ5AGGvNmoukfB/3HciVOxwTu42dzWqOJqpew9gsL4Eeppa?=
 =?us-ascii?Q?MYskHKJfOmzEfN1XMRSNXIolLgD5829svk5b5VdvoZD2crhgfqVYUBuJahee?=
 =?us-ascii?Q?9mbXbAQGcTgAmEeQX2SEW0VUMHoRO4bPm4zm5nez/32RziUXooI++E/tFoj7?=
 =?us-ascii?Q?lpaWbKUq0Dbci00D6ztrPHb26c9mjwxk5xSntSbDoClNIHMzQpqDfWsGAiNE?=
 =?us-ascii?Q?8SFLuCGO0uuxjYRbUTz1jGq6yHwFgUsqH6F2aY+qtB+OExNR32FQR6mLTk8l?=
 =?us-ascii?Q?Hf1pbNtPffBWteyMMl8x9kYHNioa6s/hm508MTNeRVJ3Q9QHmLc9RZff1sJW?=
 =?us-ascii?Q?nw=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21bb8ff4-894c-4ee1-596e-08dbc371eb6f
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 18:03:45.3978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KHi0IR0gRajb0IVfj/q3UoYDR1KOLmuGS9VDqAW7tF/R4xjHWKxkx3hSEUf5z9XF5Ie8ZtWAbwSUSLgCn7ucwVL94/bygv+9gxsQjeWUkcg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR17MB6599
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 11:03:59 -0700 (PDT)

On Mon, Oct 02, 2023 at 02:30:08PM +0100, Jonathan Cameron wrote:
> On Thu, 14 Sep 2023 19:54:56 -0400
> Gregory Price <gourry.memverge@gmail.com> wrote:
> 
> > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl
> > index 1d6eee30eceb..ec54064de8b3 100644
> > --- a/arch/x86/entry/syscalls/syscall_64.tbl
> > +++ b/arch/x86/entry/syscalls/syscall_64.tbl
> > @@ -375,6 +375,8 @@
> >  451	common	cachestat		sys_cachestat
> >  452	common	fchmodat2		sys_fchmodat2
> >  453	64	map_shadow_stack	sys_map_shadow_stack
> > +454	common	set_mempolicy2		sys_set_mempolicy2
> > +455	common	get_mempolicy2		sys_get_mempolicy2
> >  

^^ this is the discrepency.  map_shadow_stack is at 453, so NR_syscalls
should already be 454, but map_shadow_stack has not be plumbed through
the rest of the kernel.

This needs to be addressed, but not in this RFC.

> >  #undef __NR_syscalls
> > -#define __NR_syscalls 453
> > +#define __NR_syscalls 456
> +3 for 2 additions?
> 

see above