Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 2 Oct 2023 16:36:09 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev,
        baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/7] iommu: Switch __iommu_domain_alloc() to device ops
Message-ID: <20231002193609.GB650762@nvidia.com>
References: <cover.1696253096.git.robin.murphy@arm.com>
 <458dd0ed839541693a49da33239b33cf4c48b8ec.1696253096.git.robin.murphy@arm.com>
 <20231002141615.GA650249@nvidia.com>
 <a4078085-4061-2b52-daba-1cd642f0cf9d@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a4078085-4061-2b52-daba-1cd642f0cf9d@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MqCvCscCkf35hOTEMg20AWbBwz48AoopM4aATq3dH+RtkQhtNj6Ak3y1VA/D?=
 =?us-ascii?Q?heXGj063aXD5e7u3NyqpmTcLywHq4LNvzELIZnD0m1cDdVirkm9SrA18latd?=
 =?us-ascii?Q?sXZZTK9ADQtm4vCCrVE4YvH85KJ18s8ycxDgY39mxdsf08ZVh49Sj58qTt7M?=
 =?us-ascii?Q?39ElfVtOYq8nC8NbsuNetqpKw0O95QhpXFc8fHBTjMT5RkE6exX1mdE6ICwB?=
 =?us-ascii?Q?wwDUYP3HLRbNORU4PR93aznfvMU4vE86JU8ta2AYjQ4cZMaX55fdz0Ih62tq?=
 =?us-ascii?Q?u/qhr0EKKknzp7NiQZlpnEclaXHwMGj8FSwpfrZd92VjoJ8BwwPgEiZbXeRB?=
 =?us-ascii?Q?PcXasEW2aPdp3hqBmtFP9p2sX8ifRzlAIZKjErUnEUxhS2JvJEZ4BealHi45?=
 =?us-ascii?Q?gR6titAatoc7e0fWazodZ2dxQqp0SVwunBdkDSZgSVXTN40pxfEWBdstP9qN?=
 =?us-ascii?Q?gE+6/T56qMg06EZAPaZQ2Wrr4kYpOPedBxTR2IH0J4Z4p4wNyOeOHOgL34Yy?=
 =?us-ascii?Q?Q6w8DsRbT7AFusoFQ7U4jal6fG9ljKxln42cb/y/p/8jNPJlSOCh1wYVUo/f?=
 =?us-ascii?Q?yezGAuOJhZQirO7ANMY6TgZ2Np2otnfywugPqTUCQ+X2UWDz0rZHz/TXzXA0?=
 =?us-ascii?Q?h8FufPin1paWGM1vQrFLh3InmomUPt8Zx5DcifRyeR9czfrxjigC3624+/v3?=
 =?us-ascii?Q?MNTzTFJWqT0+W28Qqoa8A2VR+OE/bGhnFf5c+CPfueweKN5ijb5b+PiswpAB?=
 =?us-ascii?Q?35gR2q/FuhL4QAr9BD2kAgl4jUhwMnkN0CNhE2IsqRMgWhXEzfMgvJDjfSZf?=
 =?us-ascii?Q?F28rzzag9XVxbnPP17Ta3DdIWrxnDOQc/VsRWNhYWid4GqfC1k/YtvTIYB9Q?=
 =?us-ascii?Q?7vCKRAiYixYvX7DX151RIj1vA9Oy1pxraBGdqfzEu0v64MZwp5u5Z/PxouTe?=
 =?us-ascii?Q?ksB9oGVZWmjCvRaWies87dSoNTAl8Kt26KfndpiyPYtfehIlzAD9XaxpUTN4?=
 =?us-ascii?Q?LU/9rKQQGKifI7GVFUGuHYy0WFvZWIvwKpV57OdVsKIz1Rio8cEUTujOrKDr?=
 =?us-ascii?Q?GDwDzSwSAFx1pyDpANg8d/MR01PyoRiALVTYk0kzhRks6omlSk4itlytfPip?=
 =?us-ascii?Q?SQPemGbJYndSBk1b/C4Gb6GaXFVs1SqLmB5prpPk0TOZQoJ+UEnAtwrYhiIs?=
 =?us-ascii?Q?Z4vXSAdOkoyhEVH9bPeP4SqhhOwIjZhZ1XKmoYmbXRxQyIrix2s8Cn54k8BR?=
 =?us-ascii?Q?HXFMYd7JuPbxWbMNrnTXPD4YB3MKIgUwXtaALSk1jE5Ho1+5e6v5qCRe9VlP?=
 =?us-ascii?Q?17AY0e7fpjEzGxUH9FCY2PsodotNLAsy4/Nw2yStVUofhm2lwJRms2UeBKEl?=
 =?us-ascii?Q?OWRQ5s3diSVukAeEJkZ7CuoWqAxpGuUID1/Clvy1ZeL5Ni3NlN+AXNuhMdxy?=
 =?us-ascii?Q?20HtHJcCs2UjQkslJXqdFZN2vSLyyZa5BBa4HM4UeZ4ovbjX8tOO5pZwq/M7?=
 =?us-ascii?Q?/Lc5ZVOPPbxPfeo1MGQy3yZuCJID26nNhwGd9hWr/PoVpK8vvPu/HXcKRdSM?=
 =?us-ascii?Q?GJZBYaqIejGG9SS6J0p46wKay6knqewe0vRX/8WV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d7bf02-f2c9-4741-ef33-08dbc37ed6f0
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 19:36:14.4693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: taDoxQbX5iooRjChItFpkH7kr9mWwk8LK06bv00cHe3U1MfrhiN+o61OOQsgAjim
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5845
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 12:36:39 -0700 (PDT)

On Mon, Oct 02, 2023 at 08:02:23PM +0100, Robin Murphy wrote:
> On 02/10/2023 3:16 pm, Jason Gunthorpe wrote:
> > On Mon, Oct 02, 2023 at 02:49:12PM +0100, Robin Murphy wrote:
> > > @@ -2120,20 +2120,30 @@ static struct iommu_domain *__iommu_domain_alloc(const struct iommu_ops *ops,
> > >   	return domain;
> > >   }
> > > -static struct iommu_domain *
> > > -__iommu_group_domain_alloc(struct iommu_group *group, unsigned int type)
> > > +static int __iommu_domain_alloc_dev(struct device *dev, void *data)
> > >   {
> > 
> > Why?
> 
> Because out of 3 callsites, two were in a context which now needed to
> make the iommu_group_first_dev() call itself anyway,

I don't see it. Why not just do this?

static int __iommu_domain_alloc_dev(struct device *dev, void *data)
{
	/* FIXME: This is not correctly locked */
	struct iommu_group *group = iommu_group_get(dev);
	struct group **alloc_group = data;

	if (!group)
		return 0;

	mutex_lock(&group->mutex);
	/* Theoretically we could have raced against release */
	if (list_empty(&group->devices)) {
		mutex_unlock(&group->mutex);
		iommu_group_put(group);
		return 0;
	}

	*alloc_group = group;
	return 1;
}

struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus)
{
	struct iommu_group *alloc_group;
	struct iommu_domain *dom;

	/* Only one driver is supported with this interface */
	if (WARN_ON(iommu_num_drivers > 1))
		return NULL;

	bus_for_each_dev(bus, NULL, &alloc_group, __iommu_domain_alloc_dev);
	if (!alloc_group)
		return NULL;
	dom = __iommu_group_domain_alloc(alloc_group, IOMMU_DOMAIN_UNMANAGED);
	mutex_unlock(&alloc_group->mutex);
	iommu_group_put(alloc_group);
	return dom;
}
EXPORT_SYMBOL_GPL(iommu_domain_alloc);

(and ++/-- iommu_num_drivers in iommu_device_register)

One patch, it's pretty easy???

> Um... Good? I mean in 3/4 cases it's literally the exact same code just
> factored out again, while the one I've added picks some arbitrary device
> in a different way.

Sure, but the whole point was to make it obvious that there was no
direct linkage from the various dev parameters we have in places and
what dev will be passed by the driver. Everything passes through
__iommu_group_domain_alloc() and at the end of the day that should be
the only allocation API.

Jason