Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1616933rdb; Mon, 2 Oct 2023 15:45:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXN3gDRK2EIqVwAwNf2k33lywPS+9UQkjA9pZteIx9X8HyDWdsgIrto5WR23JoevSbbq3l X-Received: by 2002:a17:903:456:b0:1bf:1367:b7fb with SMTP id iw22-20020a170903045600b001bf1367b7fbmr13063715plb.46.1696286737805; Mon, 02 Oct 2023 15:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696286737; cv=none; d=google.com; s=arc-20160816; b=GmLIquBcIvhYD1KHuCAgnXAMQXZTL3hRABjZZzC2rGn7fYBvDyapQ6qhGrGjtDnVHL RRsyUy+zPEfZJwE4T+1h7JIMfG4PELQGe2q77IpTQd8Y5J4awyNo8GVSDHRnosxlsR5o TimTt19HPzydvguAAMYaiyt9XfGvRX92jDl9wwA/QIipMxsu7tzsWkioaVAoQO38ST+f tb8LkMAofzXKJMC+7H78m271LpPOEjjCkB/wmgY9/emAvD4xk50F1wdQiuNszdCAprGI GMVriLpC3tS+5SueAoHr27HKFV6V50u1sq6petA+HM8SHK08hhBfrDwXVrdCPMUXrpZi p13g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=V2/riLchQZtPTs/BC596zGkjlTIrNRPztVzIEa24L10=; fh=B7X/F/MaptIqWOHdsySuWt+MIGGygkZRRRvHfdWP4Ww=; b=HkPRMvqt4h0A2NZlKCGwhGUi/DBMlzfE2x1A7zpIOXVOV88hKZTWTrTdqMsSkMi7CS HPIyWvGrXCDg6IwDENMnSoKsO2cR6n0c99p/Kv5FZ44qodwt4UsTCNhLBKYiM/M584T/ Mg4bYtkd1oIwv6DOYWlhPUbLk5wY971djcXHobclKKS0ODz20HfujDvpJKQlNDmpIrlt FQXe2SZ9QbZ4hk4c1Yq+XZAu0kknPDVaapUImrYkWQk6lpX2rO1Ztma8JLsS0vkW6ghM 86AyBVRzdT1Dh7TlDTSD5KQ4UAfaiqNsvLaEf5I7mYv7bF3DGiTk4P4LtOTsZZZe+4sH iB3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=i4sYvwRv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id f3-20020a170902ce8300b001c610ae885bsi23687217plg.59.2023.10.02.15.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 15:45:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=i4sYvwRv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 01503801D4AC; Mon, 2 Oct 2023 07:00:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237629AbjJBOAY (ORCPT + 99 others); Mon, 2 Oct 2023 10:00:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237618AbjJBOAV (ORCPT ); Mon, 2 Oct 2023 10:00:21 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F57DC9 for ; Mon, 2 Oct 2023 07:00:18 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50305abe5f0so25238039e87.2 for ; Mon, 02 Oct 2023 07:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1696255216; x=1696860016; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V2/riLchQZtPTs/BC596zGkjlTIrNRPztVzIEa24L10=; b=i4sYvwRvLnl2fno42q3AI9/S19leUfadmvKoHdGuwzX6j34KYZXQqXXbn627a26scC bv6hILU4ebmYE6vrRDC9+UxIkcSOZqUE60NHGRBNUSXQhJIUcYRafUa5+rg8MT6kbPsW UiAbo4dEqCgnaAteu6F2H+fWWCHABXV+9M5EFLUHDqmwYcOhB6kY/8UfnqvLXb3+BxB4 c+uerfuYPQRAqZBr40qdw6F1hJBdBG3zKr+x/0cctJiEzo7mkI5OCXnYWOn2YcQQX2j+ AT9TGk3rNNMIQihCH+zJu7E0lAEqhkfUcTrchpcsP+q5k9ZIHDk94l7pj0NbUy9xKI06 yuJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696255216; x=1696860016; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V2/riLchQZtPTs/BC596zGkjlTIrNRPztVzIEa24L10=; b=DnMersAiIbL/pg0AyZYjUYjksR+8G8Ob5bKg9C8wLwoVmH4dv+zEryfGk//4GX3tty C0cMtxLhSVZg3KeO498agYqACmwJ5v3MpGfq+xPHWrdsFdhfDSA7f/NqmNXh2O9xHhM9 M1uPmW1NLRf1obYSxhsDZz66UbWHAJBoE4dMCGocvCS5KjzB6CHagxCaSoSvawynDG+P cVugTZlecUx/JltvDRqdwpQLufAWowhYvUU7+cMvy8mkE4wqHp1Tz5ZSiZ4rjOs0yABq S7FGyIv3RqoQv/LfxoBCqCrVPC+N9dKcuWP52z1kGc06Y9edUDtNNowLEHgZpEQpFz3I xR+g== X-Gm-Message-State: AOJu0Yxi7umG8RkS8mPhYwre0RvCrS/Y5OIGDOG7suGYKDIvUPUurv2S H23VKoCnjxydgxi6Nm3KHWidEQ== X-Received: by 2002:a05:6512:617:b0:503:19d9:4b6f with SMTP id b23-20020a056512061700b0050319d94b6fmr8505095lfe.0.1696255216212; Mon, 02 Oct 2023 07:00:16 -0700 (PDT) Received: from otso.luca.vpn.lucaweiss.eu (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id q13-20020a056402518d00b005346925a474sm9350377edd.43.2023.10.02.07.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 07:00:15 -0700 (PDT) From: Luca Weiss Date: Mon, 02 Oct 2023 16:00:12 +0200 Subject: [PATCH v2 2/2] ASoC: codecs: aw88261: Remove non-existing reset gpio MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231002-aw88261-reset-v2-2-837cb1e7b95c@fairphone.com> References: <20231002-aw88261-reset-v2-0-837cb1e7b95c@fairphone.com> In-Reply-To: <20231002-aw88261-reset-v2-0-837cb1e7b95c@fairphone.com> To: Weidong Wang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 07:00:27 -0700 (PDT) According to the AW88261 datasheet (V1.1) and device schematics I have access to, there is no reset gpio present on the AW88261. Remove it. Signed-off-by: Luca Weiss --- sound/soc/codecs/aw88261.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c index 45eaf931a69c..e7683f70c2ef 100644 --- a/sound/soc/codecs/aw88261.c +++ b/sound/soc/codecs/aw88261.c @@ -10,7 +10,6 @@ #include #include -#include #include #include #include "aw88261.h" @@ -1175,14 +1174,6 @@ static const struct snd_soc_component_driver soc_codec_dev_aw88261 = { .remove = aw88261_codec_remove, }; -static void aw88261_hw_reset(struct aw88261 *aw88261) -{ - gpiod_set_value_cansleep(aw88261->reset_gpio, 0); - usleep_range(AW88261_1000_US, AW88261_1000_US + 10); - gpiod_set_value_cansleep(aw88261->reset_gpio, 1); - usleep_range(AW88261_1000_US, AW88261_1000_US + 10); -} - static void aw88261_parse_channel_dt(struct aw88261 *aw88261) { struct aw_device *aw_dev = aw88261->aw_pa; @@ -1254,12 +1245,6 @@ static int aw88261_i2c_probe(struct i2c_client *i2c) i2c_set_clientdata(i2c, aw88261); - aw88261->reset_gpio = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(aw88261->reset_gpio)) - dev_info(&i2c->dev, "reset gpio not defined\n"); - else - aw88261_hw_reset(aw88261); - aw88261->regmap = devm_regmap_init_i2c(i2c, &aw88261_remap_config); if (IS_ERR(aw88261->regmap)) { ret = PTR_ERR(aw88261->regmap); -- 2.42.0