Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <402ba5fd-c773-f352-5f57-2dc8703a7b72@intel.com>
Date:   Mon, 2 Oct 2023 08:40:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v4 1/7] selftests/resctrl: Fix uninitialized .sa_flags
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
References: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com>
 <20231002094813.6633-2-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231002094813.6633-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEVsYk5QT0NqQlJEWXFRcEJzc1ZkWTlGVmdoS0phcm5tYWVpbTBUOUtDRys1?=
 =?utf-8?B?bEJLV0oveTUraXJuUHQrMlZ0Sk5CeEEwa2o1KzRrbUtjUm5NaXNWaVNXb0lN?=
 =?utf-8?B?MmNyV2paWjM0QWl2aXhpSUxCaWUxcGFlaTJWRUo3WkxaTlQ2dkQ1ZWJEMTRw?=
 =?utf-8?B?LzVwNlErNWhDZFFkNlZmbkRZTDNkNW9ZeGxxWTJNaVN6QkFmSnZ3OXFwMEpz?=
 =?utf-8?B?VWljUG1wWjNwRzNybU0wQXRybDkyUXhqNWNiUzM4azNLcGJXaGZjd1c1TFRE?=
 =?utf-8?B?akJKTlNWa0c4OFRYYnBDVUNBZHlYTndDMUtCQVVNV1dmYy9OUnR6ZmdNNmpm?=
 =?utf-8?B?RU84elBycGE5ZGN4SGt5aEowTHNaQjg0b2FZMXNITDc0Q2hQYndFbzY2N0pr?=
 =?utf-8?B?YU9mWG02aWZYT2dYMXhXWnJvczg3VXVnRUNMRGx3UldFRjM3akhXWGhYOUdz?=
 =?utf-8?B?MkN2dVFHOUhiWE9jaG5aZEI2bDdVcTF0UFBIWHFFMjlFQ2FPUDFIUlNwMzhh?=
 =?utf-8?B?Z3JBeldFQVMxUnZXSlBIWTcvL0xXd09zOUZVM3BoZkkrUndLTTBNWVNMTjB0?=
 =?utf-8?B?emdtbTkxdUY3NEtMS3hrQnlTUXkzQ0xZbis5WVI4VUc3SDEyTkFWTVc2UTVS?=
 =?utf-8?B?S1V2YkRFdjVPR25UK2x1eWxic0ttR1JGbEFreVhpc2t4N1A2U0tiZXhOTHZZ?=
 =?utf-8?B?cTNHS2hlMGZpN29MUTcyWis4OVVua1dzL0FTOXVEVXhCNlJDcnJqZnlqMnlv?=
 =?utf-8?B?NHdpVmptOTl2TTNXYlhmZ0ZZSjBVVFQ4ZkV4NDZycEY3VFAwWDhkbFZDSUxV?=
 =?utf-8?B?dlNhUE5UVnVza0l5UFlTSTBBZ0VtYzdFYUM0c3M3MkJhN0poa2craGQ5elhM?=
 =?utf-8?B?ZldQcm5CeGN5N29QTERuQTdYc1J1cVJ6d05NTnZ4bmpSbXdiZ0VBOFBFcEpO?=
 =?utf-8?B?NEJQbE5MNlpWbFhqdWp5OFZiV2U5ZGovN2Mrd3lGQ21IVWxMZlRlTVZNRnVq?=
 =?utf-8?B?YUovLzJ6M1VmWlNwcUFzNU1Mb1Y2ZHNlTTROY0lkREJTR2RxWXFBcklweTJU?=
 =?utf-8?B?b1FPUHVwcUo0MEppWDk0M1Z4UDYxTWh2azJPRkRyQlZkYkEyelFZOGdiZVAr?=
 =?utf-8?B?N0R0VHljbnBadWlWbjRIZHJrdldGM1RydmFqNFFFR3VqR3lORHRNanBlQW9L?=
 =?utf-8?B?aDQxL2xlY2s4T1RLc1B0NjN0Wk9EZVRXZy9RM01pTnNySWJVbzdMcUxVOCtC?=
 =?utf-8?B?SXE4VEtBNFU5Mzc1N1FyWmZRb1ZYNndpZVR4NzhDYkdrajFBNDd5MzJOSEd5?=
 =?utf-8?B?YUdVRWRGbmdtaU93bFhVcWJWcHVwNUc3bytqVWl2ZE95ZnRQQllXT21sSnU2?=
 =?utf-8?B?aXBmV0xoZDA0aEtrS1dDL0p5eVpxY21hSWZmYjFwZVdsc09zQzJWaWVxeFlY?=
 =?utf-8?B?MFQ0VG1kZkZ0dmc4K0NXakQ1STRobWM1cXBLV2RPRW0yQXdrZzZPOGhKR0FB?=
 =?utf-8?B?ZlY5VlRuY3k1UUtIbmIwRzRsNkZYSXFRNFZkV3A0d2JvQTFnUVp4YXpXcnZI?=
 =?utf-8?B?dE1Wb0dpcmxZSERoeW5vdktJQkFpR2xvREVrUjhIY3RFc2dkUWU3TlNFNDY4?=
 =?utf-8?B?TlJZK2FzZkZTN1ZETDFvaXN1QXphbU9YaTB3VGVObTB4OWJOdzlYNWpRSDVk?=
 =?utf-8?B?ai9lN1o0dzRJMWtic3JMZWZFS2NwRlRha1k2VmhvZG40bUdhUlF5VERXR00v?=
 =?utf-8?B?cngzOURkamRBYktZK0Q5OWExdXpNc3EwL0hpRnU2MGFCeExuU1ltb1F5cUtu?=
 =?utf-8?B?WGZmdkhoeFUrQ1RrQlhkcU0rQ3hURGlCSzlGQlRXdnBaU0pWRjJFMUhFeENa?=
 =?utf-8?B?Kzh3TE5oVUE3eXUrc0d0LzRtb1IwVWRKT0taWUFFQmVVT3lSQWdQejJNekln?=
 =?utf-8?B?MCtWb0V2cXNLR05KMEJkT3IrWmdseStxdERlN1ZROS93RlVOZkJlU2tpN25W?=
 =?utf-8?B?YUI5eGx4eG4rUUV5NUV3K0FuQkVZdWt4ZW5XZjliKzFDdWxxOGZsYjNjSFl2?=
 =?utf-8?B?cXZnU1NVdGM2ZHJPb0w2ckFZZUt5MWh0a1M3WDIxQ0IxNE9LMkVIaTlrL2pj?=
 =?utf-8?B?WWppa3BPQ1Y4U1JMNEI2RGh3ZWozckhUWmxLNXl4anFCak0rcGIwSitUYkJH?=
 =?utf-8?B?bkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fcd01501-dad5-4aea-8e7a-08dbc35dd98e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 15:40:05.4264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ucVlTSJEk63Ebmn5r1y565gkATd5KqVJjM9Lee1CrRZgB6MGDFGowDXYXsEXPudYjUiI6BBskRPKT/0JSXlJRKJxv/cshO6QmlYoE7pNGEQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6411
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 08:40:16 -0700 (PDT)

Hi Ilpo,

On 10/2/2023 2:48 AM, Ilpo Järvinen wrote:
> signal_handler_unregister() calls sigaction() with uninitializing
> sa_flags in the struct sigaction.
> 
> Make sure sa_flags is always initialized in signal_handler_unregister()
> by initializing the struct sigaction when declaring it. Also add the
> initialization to signal_handler_register() even if there are no know
> bugs in there because correctness is then obvious from the code itself.
> 
> Fixes: 73c55fa5ab55 ("selftests/resctrl: Commonize the signal handler register/unregister for all tests")
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette