Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To:     Conor Dooley <conor@kernel.org>
CC:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: hwmon: ltc2991: add bindings
Thread-Topic: [PATCH v2 1/2] dt-bindings: hwmon: ltc2991: add bindings
Thread-Index: AQHZ9RneaXApFz9wS0W13c9REV1TnrA2dqyAgAALTVA=
Date:   Mon, 2 Oct 2023 13:46:53 +0000
Message-ID: <CY4PR03MB33990FB22E1BB8686AC0CF509BC5A@CY4PR03MB3399.namprd03.prod.outlook.com>
References: <20231002101835.39624-1-antoniu.miclaus@analog.com>
 <20231002-babbling-justice-73d3601a71aa@spud>
In-Reply-To: <20231002-babbling-justice-73d3601a71aa@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?BMWbaU77BOg2IXgD17ZwBLIHmMnVdiPbDTT/wm0JmixKq9jmhmEjy//hgI?=
 =?iso-8859-2?Q?q9r3yb/qmY1PetBJqfpS7P21c3ZHp2Ksjld2h9oiXnzxA47KuQuByFUZaK?=
 =?iso-8859-2?Q?8V2Ysxx1rz/sRw8GjVrD6STYSnwvWQBOWGxq3JMXFiKvcwdFCxdI8A4u/C?=
 =?iso-8859-2?Q?AcbXQvQvmkUkjGPnK85Fx7dn8jhnyv2PEyyW02BfBNUXHZW6AKc28yw59P?=
 =?iso-8859-2?Q?alE3qo7LVmDwQeggS0ATni3Y7PpiW7lY8HxNwRQdpoB9+KLxLgt2DMzRhm?=
 =?iso-8859-2?Q?f44bxx7ziyxU+MIN4b7irgA8dujPheAcTOy+r1DpIzd7fQJC4hj2asT2Ia?=
 =?iso-8859-2?Q?GDlOlq373sp1f/MB+vacdYwMAUWB3zmxJu9y+htca78tJu94KzV4RWxAbI?=
 =?iso-8859-2?Q?BqLaJdu9+XhHPIwGg9cDRu+7wqUrEqPQlEr2zs/Ik2yeTvdhTEpsIfr3ET?=
 =?iso-8859-2?Q?ZYawHWsf6v3sF0fQkZilYRIYVitMbclwH4QBdOxMpemEMRREJCsyjDs6gf?=
 =?iso-8859-2?Q?me9CHw8elkpIKCj+6AqEB5FR8O/DtLi1b1vJrQMLIe2I44p4IXJqRmd9XR?=
 =?iso-8859-2?Q?8RXv6c0X6zSBWzQ4YxEt+4eHrZuUWb/esEBpBfmdHjK4NgUxVnoERBqjzy?=
 =?iso-8859-2?Q?yFayYsNzndbIj6OuE+mb8bcN+zC8sF7TNOufHRKADTejHLJgbn7YcevsyK?=
 =?iso-8859-2?Q?lxclaHeR9G3800JRPU2/nbU6MPSwTAl4jxXj2ZKhhoEtsJ8GoE52cdzUnH?=
 =?iso-8859-2?Q?BfiR77SJ0m4Uo4kbPjgOYgyYyjGM65BU8HoLLLxU5bC0TtKHpD7Oeqvv4T?=
 =?iso-8859-2?Q?QMx5/ZT/MLjXd9/8EoU5YvgcSH+gSgRaaDBnAIbI3FqkfU6MQMEYxZw4u2?=
 =?iso-8859-2?Q?P4K5YGAa4L9ZmKEz9nEm89jLrBtDJ67OPBp9cgfJlIOLyuwaKC9m8GHXud?=
 =?iso-8859-2?Q?nQrqWoPShqPo0rOEH3DQcrPqMT3RKf8v2wfXoTIHr0NZ2hduMjVI2e+JXV?=
 =?iso-8859-2?Q?Jukg+yyRTbeNBfjcC9YmOhfw/Nlsjj9XCGPrroHQQlTtcXAvGx9fTsSIE9?=
 =?iso-8859-2?Q?lqYZlXSDiKl6dpcbFl4Uhqv+3lIXGtdzdb8HKWfOx5zspWKOZEpX871kLB?=
 =?iso-8859-2?Q?El5fz/nxF89SjQmdNy3HsJNHF/46lAzKSSpdyvgbI5MZsChGY9QuCD1YWe?=
 =?iso-8859-2?Q?BYvwu4Vg0aCvflNMd6GpA1Xi5NW5wc2ykUoyMQLLBsmts/r1G5eAs24Ln0?=
 =?iso-8859-2?Q?Ipp8U9XicRDGcgZWu+mmckeitCsS86P4OJjWGcqxPFf1Zt9AilWXNsJGEf?=
 =?iso-8859-2?Q?9QsDK3IBhXRA2Je02DPePzn+A7IBQU6dyafqYEk/mgck6vTWIo0Ya+7PiO?=
 =?iso-8859-2?Q?CNUMWJKfLgSm0ic02yiqiNwEXByxZHuIwMcJlRM+LPib7XMjvgT+2TFiNS?=
 =?iso-8859-2?Q?4oO8aB9btlL0pzD4Q7ZoEU/FL5LnPalXvy557VvPy5/86pNfSDxwGw1x1V?=
 =?iso-8859-2?Q?ZyPmQ1AE9HdAB8lHGKtu59hAOVIedxc2my+C5LiOGwTshTjbQM2+ITJzQP?=
 =?iso-8859-2?Q?1BYOTAhRf3ovXEomtax653WBmwIZ4moTZju23rDDxxDxpok5adJpgQ7xLo?=
 =?iso-8859-2?Q?h+a2FxIu4yBRMIzbhB55/EW2ZXMdJIait4OqexNuckjQPIP32iadoyKw?=
 =?iso-8859-2?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3399.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6704a007-650b-4005-a7c3-08dbc34e0999
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 13:46:53.8503
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FfiuSn2C9kGq55A1mrGnn8kviW0vtnxsWG6vbr0TnL+uvY85DL56amXZ5yrdZf+z+twkyo63bGfJ/rMHKatBhAbRu/Uqsv7pyJAXdj9LXMU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5206
X-Proofpoint-GUID: JdjIp7aeAMsiqjV7Yht-YOCeq86yFVUB
X-Proofpoint-ORIG-GUID: JdjIp7aeAMsiqjV7Yht-YOCeq86yFVUB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-02_08,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0
 clxscore=1011 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999
 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2309180000 definitions=main-2310020104
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 06:47:54 -0700 (PDT)


--
Antoniu Micl=E3u=BA

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Monday, October 2, 2023 4:01 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: Jean Delvare <jdelvare@suse.com>; Guenter Roeck <linux@roeck-
> us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>; linux-
> hwmon@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: ltc2991: add bindings
>=20
> [External]
>=20
> Hey,
>=20
> On Mon, Oct 02, 2023 at 01:18:14PM +0300, Antoniu Miclaus wrote:
> > Add dt-bindings for ltc2991 octal i2c voltage, current and temperature
> > monitor.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> > changes in v2:
> >  - make compatible const type
> >  - remove `|` where not necessary
> >  - switch to micro-ohms for the shunt resistor property
> >  - add vendor prefix for temperature-enable
>=20
> Thanks for the updates...
>=20
> >  .../bindings/hwmon/adi,ltc2991.yaml           | 114 ++++++++++++++++++
> >  1 file changed, 114 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/hwmon/adi,ltc2991.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2991.yaml
> b/Documentation/devicetree/bindings/hwmon/adi,ltc2991.yaml
> > new file mode 100644
> > index 000000000000..3811ea07a04f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2991.yaml
> > @@ -0,0 +1,114 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +$id: http://devicetree.org/schemas/hwmon/adi,ltc2991.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices LTC2991 Octal I2C Voltage, Current and Temperatu=
re
> Monitor
> > +
> > +maintainers:
> > +  - Antoniu Miclaus <antoniu.miclaus@analog.com>
> > +
> > +description: |
> > +  The LTC2991 is used to monitor system temperatures, voltages and
> currents.
> > +  Through the I2C serial interface, the eight monitors can individuall=
y
> measure
> > +  supply voltages and can be paired for differential measurements of
> current
> > +  sense resistors or temperature sensing transistors.
> > +
> > +  Datasheet:
> > +    https://www.analog.com/en/products/ltc2991.html
> > +
> > +properties:
> > +  compatible:
> > +    const: adi,ltc2991
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 0
> > +
> > +  vcc-supply: true
> > +
> > +patternProperties:
> > +  "^channel@[0-3]$":
> > +    type: object
> > +    description:
> > +      Represents the differential/temperature channels.
> > +
> > +    properties:
> > +      reg:
> > +        description:
> > +          The channel number. LTC2991 can monitor 4 currents/temperatu=
res.
> > +        items:
> > +          minimum: 0
> > +          maximum: 3
> > +
> > +      shunt-resistor-micro-ohms:
> > +        description:
> > +          The value of curent sense resistor in miliohms. Enables diff=
erential
> > +          input pair.
> > +
> > +      adi,temperature-enable:
> > +        description:
> > +          Enables temperature readings for a input pair.
> > +        type: boolean
>=20
> ...but I did not see an answer to my question on v1:
> 	TBH, this seems like it is used just to control software behaviour.
> 	Why would you want to actually disable this in DT?
> In other words, is there something in that hardware that precludes
> measuring temperature for channels that do not contain this property?
>=20
> Thanks,
> Conor.
>=20
Sorry for missing that. I took in consideration this approach based on the =
pin functions
described in the datasheet (page 8 of 32). For example the V1 pin of the pa=
rt can support
3 different configurations: "V1 (Pin 1): First Monitor Input. This pin can =
be configured
as a single-ended input (0V to 4.9V) or the positive inputfor a differentia=
l or remote diode
temperature measurement (in combination with V2)."
Moreover, looking at the multiple typical applications examples at the end =
of the datasheet
there is a specific adjacent hardware circuit connected to this part for th=
e temperature
measurements configurations.

Thank you,
Antoniu
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - vcc-supply
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        hwmon@48 {
> > +            compatible =3D "adi,ltc2991";
> > +            reg =3D <0x48>;
> > +            vcc-supply =3D <&vcc>;
> > +        };
> > +    };
> > +  - |
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        hwmon@48 {
> > +            #address-cells =3D <1>;
> > +            #size-cells =3D <0>;
> > +
> > +            compatible =3D "adi,ltc2991";
> > +            reg =3D <0x48>;
> > +            vcc-supply =3D <&vcc>;
> > +
> > +            channel@0 {
> > +                    reg =3D <0x0>;
> > +                    shunt-resistor-micro-ohms =3D <100000>;
> > +            };
> > +
> > +            channel@1 {
> > +                    reg =3D <0x1>;
> > +                    shunt-resistor-micro-ohms =3D <100000>;
> > +            };
> > +
> > +            channel@2 {
> > +                    reg =3D <0x2>;
> > +                    temperature-enable;
> > +            };
> > +
> > +            channel@3 {
> > +                    reg =3D <0x3>;
> > +                    temperature-enable;
> > +            };
> > +        };
> > +    };
> > +...
> > --
> > 2.42.0
> >