Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <008e7532-1650-15ca-8b31-5acb88a7305b@collabora.com>
Date:   Mon, 2 Oct 2023 14:39:48 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     Emma Anholt <emma@anholt.net>, Rob Clark <robdclark@chromium.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>
References: <20231002164715.157298-1-robdclark@gmail.com>
Content-Language: en-US
From:   Helen Koike <helen.koike@collabora.com>
In-Reply-To: <20231002164715.157298-1-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02/10/2023 13:47, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> Dependency for CONFIG_DRM_PANEL_EDP.  Missing this was causing the drm
> driver to not probe on devices that use panel-edp.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Thank you a lot!

Now sc7180, apq8096 and sdm845 are probing!

Tested-by: Helen Koike <helen.koike@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>

> ---
>   drivers/gpu/drm/ci/arm.config   | 1 +
>   drivers/gpu/drm/ci/arm64.config | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ci/arm.config b/drivers/gpu/drm/ci/arm.config
> index 871f4de063ad..411e814819a8 100644
> --- a/drivers/gpu/drm/ci/arm.config
> +++ b/drivers/gpu/drm/ci/arm.config
> @@ -24,6 +24,7 @@ CONFIG_DRM_LIMA=y
>   CONFIG_DRM_PANEL_SIMPLE=y
>   CONFIG_PWM_CROS_EC=y
>   CONFIG_BACKLIGHT_PWM=y
> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
>   
>   CONFIG_ROCKCHIP_CDN_DP=n
>   
> diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
> index 817e18ddfd4f..45f9deb7c4f6 100644
> --- a/drivers/gpu/drm/ci/arm64.config
> +++ b/drivers/gpu/drm/ci/arm64.config
> @@ -26,6 +26,7 @@ CONFIG_DRM_ETNAVIV=y
>   CONFIG_DRM_I2C_ADV7511=y
>   CONFIG_PWM_CROS_EC=y
>   CONFIG_BACKLIGHT_PWM=y
> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
>   
>   CONFIG_ROCKCHIP_CDN_DP=n
>