Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <62fc008d-ac84-8df8-e379-a6fc9b992d2e@intel.com>
Date:   Mon, 2 Oct 2023 15:56:59 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3 5/9] platform/x86/intel/ifs: Validate image size
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230922232606.1928026-1-jithu.joseph@intel.com>
 <20230929202436.2850388-1-jithu.joseph@intel.com>
 <20230929202436.2850388-6-jithu.joseph@intel.com>
 <f5a560b6-3410-f4bd-479c-c9ebec7fdc63@linux.intel.com>
 <b3ae7831-9634-ee63-c0a9-baad59b6fabf@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <b3ae7831-9634-ee63-c0a9-baad59b6fabf@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGYvcW9QUmNldHB2TjFVWUFuVUZsTFMwQi9QN1o2dXUxMzY3OTZyQ2lXMzBk?=
 =?utf-8?B?VFI2SW5Vbms5YXdlaHhqWmZpUWZCZ1JqOWEzdUVkMjhhQjlqNlZsTEVRcHE1?=
 =?utf-8?B?b2lnNkxwTnNwalBBQW1mYnRBZXFTaDUvZHVRL2VSQ0lrdC9xL09kaVRPMlZm?=
 =?utf-8?B?cGs0ZHpKbENmalovT3Z5RDhWbDJOd3BTV2xBNHl6ZG1ONHJNVXRIcEVXVkxR?=
 =?utf-8?B?NEtYbnhuMVgzODRKYU5BaEZrWE9ad3U4QnBhYXdaOWtBZHBZR0pIbXJJS2FS?=
 =?utf-8?B?cTFFUm9IWG93STJpSUVxRzZTVDhtR25VR1NKSy8rSDZ4ZjVqcStFWW80UUtw?=
 =?utf-8?B?NllDVm5WcVMxUkt1YVU1Y0NodHZBQXhqSW9SZ0txTCt1dGt3LzA3bndrQmxK?=
 =?utf-8?B?NkxQSzg3WTRkU0FrS3ZRVUl3U3h0b09ocG5NOVJZeThVL0pySnRqZzNqLy9E?=
 =?utf-8?B?a0NrbXpQOFVkcWNEbTBqZzdXL1JPdnd2UVJUVm9IQnFFRWtzMlJONXREeTdt?=
 =?utf-8?B?THRVUlVZaENRSlh2U0M5QS9BNGxkdFJPb1dPUGE3bFVZZ3JWUEExR0hFQ3lT?=
 =?utf-8?B?eGcrbzhPZ045NEd0NGE0S2hDc0VkQ2piY0FvMHpMMkw5aDdjUThQREFTb0ox?=
 =?utf-8?B?M3Bwb21GNFdKLy81UVVNaWV2RjBpYmtRWVo0KzdEZ2FyRGVrdkZZVDd5NDVu?=
 =?utf-8?B?V0N3T1BhK05iZ1VqSHRwUXl4MWk0WTdrb2thRWxTaW1NRS9sNUhKK0Y5L1pu?=
 =?utf-8?B?NERKU3VTVXhJeWw2RWM0TmJEaHlWNnJmcEZ6WUVuOGFIbmpYSUg2dTBmbVFT?=
 =?utf-8?B?UE1ZOWt1Ulgwby94SVBaaWo3K0VFN2J6RTFHK1VRT05QWmNKQnBMZFFYTjFF?=
 =?utf-8?B?UnlnSnNpZmgyT2cxMEUybC84Q25ETEFXU09RZDdUc3ZLdEZvelBRbHY4Q3px?=
 =?utf-8?B?SGZGK2l5VUJrTzdBZnY0L3JhbHlBN0YyOWdjMjFicUNzTUdkWVNUYmdEc3Fw?=
 =?utf-8?B?Rk02ckVWWHREV3dyaDUxQXVPYXc2YVJpT3owVW1pUU9uTldLYjZ1VXFrQ3Ax?=
 =?utf-8?B?ckoybFNRT0dmNmpsOWw0eFlRT1M5eU02dkNtVUVwVWJxT1N2bVBmT3FmQWts?=
 =?utf-8?B?Um5Fd0laaURWYVRBMDNSY1dsMVF2c2NtNzJicGRiYWRzOUhEakhQWlV2OXFV?=
 =?utf-8?B?bVpFN251MzFabWw2OThCUE55bEhUYUp6NmtnZlEySTNQaDR4anVlYzc5ZE93?=
 =?utf-8?B?UmZyTWRhODlnSDg0K2ZyTGdrWVZrRmNtWVZJWmlwSUZweTduOXhsdm5uVEF0?=
 =?utf-8?B?YVhxV0NLUDdOczVHWERjQVBBS09IM0NYdVVvbHMxcitkKzVHMmV3Y2RneDR6?=
 =?utf-8?B?RnlXWU4wN1ZBRGZ5ZXd3cWx6cGtEYnhjTXh0Q0RnZjhHT2ZldmNRNDMvOWVs?=
 =?utf-8?B?eHJiR2VrL1VONTFsL1llZWUrLzNiOThVQWNNWlpPRW5mWHJSWm5OQWRuT0or?=
 =?utf-8?B?N0R6YUFITjg1eFFTOFpYSE1nQjZBVXpWaHlsaXMweEk1Qmk5M3hZSW1UME9o?=
 =?utf-8?B?SXVrYm1DMmxlTCtlRWVjUlpwd25QUENMWWZiUkJZRGI3OW9VN2ErZVNQdWU4?=
 =?utf-8?B?VkZneDlDaWxEMnVIbHFDN2orRVhrREtwUnZEUU00UzRVZm54UmhHVktscnVO?=
 =?utf-8?B?N29EK0s4UGxPbkxGd3ZHK2N6YTFVWnc4ekl2MzJ6Uit6K0hZWW0rcXFZdERo?=
 =?utf-8?B?L3Q0M25GUndjeEE5WFBFZ2VXaXdGdDZwR3Y0dFc5d3Y2WkxTbUpZYWpSeTk4?=
 =?utf-8?B?V1FrKzY2SXRnNmFxckx3dGdSMEZ3TFo0MXhYRFhTR09yazZRWkdWMGkwRFA1?=
 =?utf-8?B?OFp0WHp5OVJkUkRzUTZDU1FGeGFacU42UmNocFVHQ1RMNmJiM1p2N21KTGhS?=
 =?utf-8?B?MXYrcExRSUNxbUNQd2xnWkI1bXRRZkdoQWkxVUJBSEljQ2s4Q1RvcjkzY1Rj?=
 =?utf-8?B?QmZBRHdhWm5GRVEwekFlcnhrRFQ5c0hOc1NzSWdLa3JhWkROMlhnUHhLN08v?=
 =?utf-8?B?SCtnbGk4R2VFU3BJcmxBOVdwQVROSHBOVVVNYlJWMVdib0swSnM2VzZ4V2U3?=
 =?utf-8?B?VVpMc1lUdmpOOE5KMWoxemJNNGo3YWZQNWp0T0xwNFJvQXhzUmhqRDhRck1W?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b370cf7-4487-4677-7493-08dbc39ae4ef
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 22:57:03.8477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MVcE+S1uaXsj+5jskt90wjoWmIrPRNSrs/KKxA3U7RsxF22zTrCk+MmKGgnn2TS6/mvEuzsLKgGbGsAji/rlAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5592
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 15:57:17 -0700 (PDT)


On 10/2/2023 4:50 AM, Ilpo Järvinen wrote:
> On Mon, 2 Oct 2023, Ilpo Järvinen wrote:

>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> Just after sending the rev-by, I realized this also has %d vs unsigned int
> problem, and %ld should be using %zu as fw->size of size_t.
> 
> Feel free to add my rev-by after those two problems have been fixed.
> 

Thanks for the review. I will make this change

Jithu