Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <9074ab58-7528-ddb4-7445-e4b4ccd66dea@intel.com>
Date:   Mon, 2 Oct 2023 15:58:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3 6/9] platform/x86/intel/ifs: Metadata validation for
 start_chunk
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230922232606.1928026-1-jithu.joseph@intel.com>
 <20230929202436.2850388-1-jithu.joseph@intel.com>
 <20230929202436.2850388-7-jithu.joseph@intel.com>
 <e8bcbdcc-8cba-57ec-b0fc-4d66305d5aed@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <e8bcbdcc-8cba-57ec-b0fc-4d66305d5aed@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkhXbnRGY2V4NCtPNmtlSVRCSUlrdmx1azVMWlpkWWRsb1BqQ1ZQWTltMUQ4?=
 =?utf-8?B?a2VVU1JQazBUeWhyQzVPR3RHV2lJZHI1dDdSdHJ3bE9sQ3Y4cG0vOVo5aU85?=
 =?utf-8?B?WlRIcFhmVzJFN2VFYmwwZDR6UkJjdlFpUlVoRWo3ekJjMDZqc2hqMXBaeFZV?=
 =?utf-8?B?TGR0cXlmN21xVmpHQ1lVUFQrNEp1VEFrWnZaWlcwVWJqNVgrSWdDVVRsT2dI?=
 =?utf-8?B?Y0lHcy9YNEdoOU00Q3NyMW9iakNNbGJlb0kxeFNKS1Qvd2h5WUdVRXZPalZ2?=
 =?utf-8?B?R0c4RTI5dFRSaG5EZHJNcXZLSlUrRzRPdURHQll5QW5jaDdRWGc4M25BQ3k2?=
 =?utf-8?B?QURpVWEyZTZjZkQ0b01EdDBZVktXdUpvR2tTa2RjUTFwRDM5WVJDQ0MxYWFh?=
 =?utf-8?B?K1NmY1FPNEtyYVo5OHdOMEE0aEdFRTVWSGN4ZkNNK1ExVEsyc1RSVGlucHVW?=
 =?utf-8?B?dDdzbUJITEFlczdDTjdQRXZOVk9VWEJKNGg3b2ZDd0wzemRaMEUyQjBoa0p6?=
 =?utf-8?B?NWFJWWczdWxvRXpBMWpJNy9oWTB3bmlLa1dKZlg5V085dnZFMStFT3YrZTZ0?=
 =?utf-8?B?ay9paEpNdHVxSUFyeXBHNnpRUHpVbGRhUGVVSExXckxvak0vR3NpbFQwdG1a?=
 =?utf-8?B?SmM5UUM3M2xsNVZCWE91U1V2eVhDc1RxTEEzNnVJSGdhbXNzcHcvL09FNmI1?=
 =?utf-8?B?Tlk1dDB5T0hZNUkwRDJQb2hMZjBnYm1nSXVKLzY2VHNqWjZDRTlMMm5qRjVH?=
 =?utf-8?B?Ykc5cko1bXRKK2NiQ1BtVEdSMEpTQWJBSERzS1RDbjY0cUYxbVBtYWNkdXVk?=
 =?utf-8?B?cGU1Qm9CSDY4Y0RUWEcwNkh1TTdEV21vVU5kZzlHelQvRUlXeGplUG1oVXAr?=
 =?utf-8?B?dnJtaWZHVHNsQ01DV2x3Y2pBZ0YwRTc3WFhuODNKeDc4Nkt3OGZoOUVrWEZU?=
 =?utf-8?B?Sm5UOXF3ZFRZRDdrb0hzTTQxWk9nVVMwZFN2bFZNR1lSTHU0blJZN0Z0anJk?=
 =?utf-8?B?NFU3WEdaWDFZTGhHY3YvTFkyWVVtTXFCWmx2L1p0QzNKNFNPNnYyQU92c1Jn?=
 =?utf-8?B?RlF1QnhRQUNRVWhjTDdTa0VlVFhBZHRMRjloTlZicHl1cjlFTmlpeWdyNjhE?=
 =?utf-8?B?UHozYmNjbFBSbkMyNklUc0dVbVIyaFRuaHNkS09Rb1Z2eFhTSkE5eWJWMjNo?=
 =?utf-8?B?Z1pwSVB3RStHL1hVakRUREZrK2kra2VYRlNQOUtIYVVISlQycU1MTCtoemM5?=
 =?utf-8?B?N3ZTYUN3RXFJZzRhSlBVUVV5bzNlMVdTWHNOV3pQZ2NUZG9vZ05yWWgvOTlx?=
 =?utf-8?B?V051alNQeDQ5cXhkem1YQW1xMVV4eWE5OGc3bWJTK2VRVjNVdUw0UVhpc2RV?=
 =?utf-8?B?Ky9ORXhsNE1SY0YzZVYzNWtacVBqemE3MTkrOWNIRlhDbDJGcnl0d05VZld1?=
 =?utf-8?B?S0Mzc3duZFRKcjFZMzF2VkJCb2VEYk1uOXRGMmVJeEVyN0wrQXdkVHB1cEN4?=
 =?utf-8?B?OU1NNkY3WFIxMVVlRjdFUnVQVmhKTjdwdXJ1US96NmkxTUpGaHFvSjNIS2Jh?=
 =?utf-8?B?WU1FV0FJU0NVUW9MUHJGQU52emNnbzBvekd3NnlMZFk4L3JVS3VKZHlOY0tY?=
 =?utf-8?B?N3NLZVovaytTMVdtZWtuS24yYkdRRWpaTlBkY0E2MXVTZE9UczBJdTBoaHVa?=
 =?utf-8?B?Y2dVWHZ1VHlCbUczYmV5WjZSMVc3N1NmckZCZmlZcUQzdGJrTTk4RUlObnk5?=
 =?utf-8?B?bms0QXp2eml1SjBkbUdwS2MvU2FhRWc1MW9RWEtTZVBzWUswbHZ6SVBOMFVk?=
 =?utf-8?B?UlA4elhoTHEvUEpIYm42ZmlzTjlsSDlmdnZxNGNESk41YkcxdFo3RjlLZU84?=
 =?utf-8?B?SW1odkFWMGx5Yk8yUmJnYSszdlZmemtEcWNNdUptTURVSlE5aVFkT0FzMnlL?=
 =?utf-8?B?RzdXTC9kS05aSXdHbWlmc0g4ZEE1NEpxY1h3WVpvakZKUVFrQ0lGN0UvcXds?=
 =?utf-8?B?L0EzdHRxZkdYSEI1MkJDaGlrbVJ6bGNvN1h2Q3lTWWdkTWxCcS9UNzZJM2p5?=
 =?utf-8?B?ZkY5bEJaU2RURkNKdTZaa1BHaFl0ZmZCb0NVNXBUWWpuMHFpRU1nZWJyZm9F?=
 =?utf-8?B?TkNRdWFjaEg1SFk2SlBNanRSK1VWYmN2Q0IzSVJSd2RrV3ZwN1ZvWWxlRDlv?=
 =?utf-8?B?N2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82aae871-6a56-4baf-bb5d-08dbc39b14e2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 22:58:24.2663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I22096YtYFuRiHxKY4wEYuoVlJWlEh3gcmOz6OSL37a1CYMEx8Xo57M0bVpiemtamJrbj1AOlSiJ82lWpM4kqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5592
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 15:58:43 -0700 (PDT)


On 10/2/2023 4:47 AM, Ilpo Järvinen wrote:
> On Fri, 29 Sep 2023, Jithu Joseph wrote:
> 
>> Add an additional check to validate IFS image metadata field prior to
>> loading the test image.
>>
>> If start_chunk is not a multiple of chunks_per_stride error out.
>>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
>> ---
>>  drivers/platform/x86/intel/ifs/load.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
>> index da54fd060878..6f8abb4729e9 100644
>> --- a/drivers/platform/x86/intel/ifs/load.c
>> +++ b/drivers/platform/x86/intel/ifs/load.c
>> @@ -291,6 +291,13 @@ static int validate_ifs_metadata(struct device *dev)
>>  		return ret;
>>  	}
>>  
>> +	if (ifs_meta->chunks_per_stride &&
>> +	    (ifs_meta->starting_chunk % ifs_meta->chunks_per_stride != 0)) {
>> +		dev_warn(dev, "Starting chunk num %d not a multiple of chunks_per_stride %d\n",
>> +			 ifs_meta->starting_chunk, ifs_meta->chunks_per_stride);
> 
> Please use %u as both are u32s.
> 

Thanks for the review... I will make this change


Jithu