Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <5e354fef-555f-f461-c847-3ee694152d06@intel.com>
Date:   Mon, 2 Oct 2023 16:01:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3 9/9] platform/x86/intel/ifs: ARRAY BIST for Sierra
 Forest
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230922232606.1928026-1-jithu.joseph@intel.com>
 <20230929202436.2850388-1-jithu.joseph@intel.com>
 <20230929202436.2850388-10-jithu.joseph@intel.com>
 <b92b44ed-19a7-aec2-615b-1b1755dafdac@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <b92b44ed-19a7-aec2-615b-1b1755dafdac@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1pDQVF3WGRwRzE3aTd2bk15WW00L084SUphckIrbHI5dVpBa3hHU3pZYmxW?=
 =?utf-8?B?NWR5eFN2amZJM3oyY2g2Wk0rd0M5Vk5mV0dlTHlJTHhKWElLVkd2SEZGWGp4?=
 =?utf-8?B?UFlWQy8rUUpGSXFGdHJjRG44ZGsveWZINDMyV2hhbDVHVSsyUUhmaC83SHVI?=
 =?utf-8?B?Vm9uNEZpV3VMdThtek1KOWQxTHdCQS9ENEc5R0dEbkNuUzVJMm1pWG00QktE?=
 =?utf-8?B?eE1IU0lwVWt1ZStKcXBseDNJTk9WSkU5RGdQYldtS29peThISXVzZWliMFJX?=
 =?utf-8?B?Q05vcFovY3ZHa1NnemRVUXAxYkk3YkVNcm8ralcyY09rZFdQdmFJMkVFaEtS?=
 =?utf-8?B?aHBDM3dwVHdOL2tXcUh3Q2h5Q3hiUjg1OEdyTnZtcCtwTVBDQ3V1bzZTLzZF?=
 =?utf-8?B?WUFRbk43U2svLzVmdWt3STNXMmRtMnc1ZGlwQkp5U0Fsa016N0ZveVNyU1FM?=
 =?utf-8?B?cEdObStjZTdFUmNaTGZtc093N1RjZURMRGpWL2hUeUFaNTBJdVNLRzRXZ3hF?=
 =?utf-8?B?cCtGcHdiNktDUjZRT3VGTWtKRytGVnhhczM4cXJ1QVYzZGpIR0U1YitUSTRr?=
 =?utf-8?B?cWYwQ1R2a2d0c1hTdlc4WnRHcUY3ZzFmMkR2d1N3QnYxdkQvUzRXQ2NDL1lK?=
 =?utf-8?B?YXdLeDFwZkU3UE1rTWRDQkpuSFQ4cXVZR1JFWTVyUDd0Y3ZKbG4vT1hteXZQ?=
 =?utf-8?B?YXB4MFZKVWRGSnU3N2VaekJyZkxCN25ZNWo2dGpONUxqTTFRS2VodmY1Q0lM?=
 =?utf-8?B?RHBNVVFRZmgwQi9Hd3EyaUxIRExUamU1Nm5iT1pLck1Yd2xwYi9GWi9SNGFZ?=
 =?utf-8?B?K3VRMis4c2plbFU0Uy8rVlVtQTZKTGVoYlF6VjdHblVBcHR1b0JUV2VWZ1JM?=
 =?utf-8?B?YjVLMVB6UkZCWTEyRXcxczcxdElHSFlEcDljVTMwQ1NTWG8zZGd2TkRhUm1l?=
 =?utf-8?B?Wmx1aUhWalFKK2dGdktQWW5pVmthMTNRbGJXdlJDSWRGY0M5clYxSkp2aGtW?=
 =?utf-8?B?Y0cxQUMwWDNNNE5BZXBETWhrYTh1c1ErRmZkK3dHUGFNVFM4N0N3MCtpbDA0?=
 =?utf-8?B?NkZFejhWZEF3Y1FuM0hpWE4yTWp0eTYyTWdSODl5V2VCc1JSRVlkYzFSU01H?=
 =?utf-8?B?S2p2THk1YzB6KzdlY3FXZmpzU1IwamxZeG5oSlVvVWxLTDRvTVA5cFBYRE1m?=
 =?utf-8?B?Vm42ZEZaUkVPMGE3cW9hdE5HQmhYcjRuTVgyaUtIZ0owUUdaVzJZSGRRZDBD?=
 =?utf-8?B?bUQwdkNaaUNaNTJhYlg4THE3eTR4RkoxcmphQlBkY0ExZDdUaXBGOGhlSFNs?=
 =?utf-8?B?a2dad3A5bWRYQ1dka0lnZWNkTW9ZOUhnRHdQUkNtWmptL3ZqZ0dIRUNOQXVW?=
 =?utf-8?B?RWlhbW1VbXg2ZktIUHdVdlgxZEZSWkx2a0dwOXNGeFh0OXpoRWV4cFBmSjJr?=
 =?utf-8?B?cVp5OWNZQkZLNmw0VTJadTAxY1hVSjlFTzl1RFA4U3gyOXlva0RkU1llblA3?=
 =?utf-8?B?RTNaWFpMRGNYdDBnQ2NwV1pJMXVpeFQ1Z2tSYUJ5bHZHVC9Vdm1waW1meS95?=
 =?utf-8?B?d2YvcUNEcHNiaTZMdTdNbjFqQ2k3YTVIeklvdisvTzFycS9maVVTNkJ0dytq?=
 =?utf-8?B?dzNRelF0Ujd5TWZBVWRxVGpiRmxXZ1k5MjUrWEtCcnBHeUZsTHhCM2M4enRx?=
 =?utf-8?B?ZGZtcGlJRzdWcFBiM0pscGN3azVTeFphTEQwMjdObnBiQUQxQlhhUGpxUzRv?=
 =?utf-8?B?M05BWW45Tkk1N2pjRVIrWnRlY0MrMXB6NDN5K0V1cElyNm9qQnV0RmJvN1BX?=
 =?utf-8?B?WDlpcWVkVC9kaEpFMXdHRUgremo5SllSaGRZOHB3cUFNTzZ3QjVLRHBCOVp4?=
 =?utf-8?B?OVhOZnlUcFFGVWl2NXFLR0ZNa2xiNkpZWVBZVEN4aXhZVC9FRFFUL29UTDhN?=
 =?utf-8?B?ZEhRaXdZMGlUd0lmdUlxRnJxY2xzU3BXNkp4enVGVDluOXRqaGdPZWgyVnNv?=
 =?utf-8?B?RndBV1pKZExjQVBiYnZWR1g4VmpxSWs1TUhINnNtVXpUZmk3ODZUK1dhUzRq?=
 =?utf-8?B?eTIzK2MxQUREQ2E1K0crcmVucUlMUWdybFRmNGltSmt6eDRtSGNPM0M0NGJS?=
 =?utf-8?B?YkNCNUVMNWZWTTREcW1JVDdPaGFlamNhWDd2T0t2SFFxQm1vM01hNTlSZ3Ri?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ad1d783f-3254-4543-02d2-08dbc39b77dc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 23:01:10.3094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ikS4Fa1lVxhTdQ8vU26YIy1BXFVuXBBG+hOn5I2gzZcnSMyTF6G03rurd43k8Ij9GqchISGclXv+ahXQ4HtpIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8440
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 02 Oct 2023 16:01:31 -0700 (PDT)


On 10/2/2023 4:59 AM, Ilpo Järvinen wrote:

> 
> Just a suggestion that would IMO make these easier to understand, you 
> could name these array generations with defines so that one does not need 
> to look what's defined in X86_MATCH() to understand the purpose of the 
> second parameter. But it's up to you.
> 

I can make this change ... Thanks for the review

Jithu