Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1629173rdb; Mon, 2 Oct 2023 16:15:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxYhnWKJroAY1KFbP8H9WjnqOkWZ2G2YMKMsTYUIcDswVaEgw/ZGong4EiZQBKNfqtrHXA X-Received: by 2002:a05:6358:5e0f:b0:141:8c:75ad with SMTP id q15-20020a0563585e0f00b00141008c75admr14314588rwn.28.1696288545234; Mon, 02 Oct 2023 16:15:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696288545; cv=none; d=google.com; s=arc-20160816; b=AujBHu2VM7vT9X/MKxSIX5YhfvnQOO0VIO/YxFVi5Q9tho7sh+K0N9YNT9B9KeAA3l b6PjoHYtsDromc0gD0gb7sJtehW2hp0h+K5a1PUD/XE7ixI7XW0ELlxOUtDQurTqwzm3 PcOCP6ywLjqVMUFO2lX/YajgtydTqq6e7fqu0xy5IJ7gDpv/5b22vMxKPye4dohj34L1 sozJSJ7R+Sd53W1NinpPJClCbHfJCloWaIL7tANQtJflTzQ2FYjmrcS8tZDz4lMm+aYS 5sRdMj2sID/LZ6/Qi7/ixd8euFZ94XwdqTnkOReFbt7+2Gg1/oxMfrVIxSNBVUx+pXtY 4Xqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mOt3XSQtUEUA5CNWLdkquGCY/Lz/78GBxWkDuifhphU=; fh=mNvOpR73OaUnRrr53gRvslddDUjaIrpQi7RNpkp0Veo=; b=YcPVsO4DcMgQ2dZ16Iq2Bv4gpmPCZNUCsijakAagEm4fFZ3SiCJQSDjQRur9uuhuqY GAZCzCcN+znHwuP6xEfIGHf+UvtjTgTcmXmWMiI6qW7Y6/KeiLSFZBlTzau7RBssaoov navMzGG47SAy5Lc2/LzDHilU4gTwcIXWIJuaurTEbpZy25+Y02YIwUOPhNBITnjoulYH HLgjizJoutcb+bM16HuA5jOAGr3vZ5OSF1dePzxDka3K1FxAeuX4v4oXtjmhwnSWX8Yb /ABfagVyAMu19Jjmof4cfIAzcXYXxIa3Vk9ds0gLJNLo6YSQpEqAS9lhJ8hfG6H4U17H rqiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Cs/VF1UE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a3-20020a056a000c8300b00690b8b03454si65058pfv.234.2023.10.02.16.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 16:15:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Cs/VF1UE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 518FC8088696; Mon, 2 Oct 2023 16:15:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236552AbjJBXPF (ORCPT + 99 others); Mon, 2 Oct 2023 19:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbjJBXPE (ORCPT ); Mon, 2 Oct 2023 19:15:04 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55CEDAC for ; Mon, 2 Oct 2023 16:15:01 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-307d20548adso338480f8f.0 for ; Mon, 02 Oct 2023 16:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696288500; x=1696893300; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mOt3XSQtUEUA5CNWLdkquGCY/Lz/78GBxWkDuifhphU=; b=Cs/VF1UEb1eZ3HPJdTFHHgU/FAjfgeM0Xfg4eMRk74bAg4qW1ZE+5iMy6ptlrjRH84 p+ifDZp0OGBCI7c+h7rVpJ+Ie/Am9fn9PP7qy7bdKtfBUr43htDHGuFoqO1HDyKpVYcc +FiD0Xj1TkVj1S8VoKu/En54uTXqgC/at1jwOetTGFaF6OF32dgCrYQaxbIYQpoQuKpT Y0eMOyi6t9OPoxzoVwfBGEmXeYzMDPkdGxVixDi9n1rVfau1cd0a/NhumESK8OL2Oer/ kQ608/fm/xTaLfs+1jVLDa10mSDEKrJgMTO4JzkElkp1j3A6c9xA8xGoxlFj+k0XDAZB om3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696288500; x=1696893300; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mOt3XSQtUEUA5CNWLdkquGCY/Lz/78GBxWkDuifhphU=; b=HYcn7ArS1S5nAlXrUoIyGSoy8QtLWS5qBCqTHPlmNhIvzzsW/bTztEGOASRF8tOrAG h8ZA6sgfFksqAPURPMFEa3oQX7CFujbWJvjYX8wmv0vqL3LRboLnRwkimGW5U/XEcP8g FD2+aRS/mJ29MHCZ5gDEHP0k++X64Nv6oT/eC/lCmcvhT90JGuz6X/8P822RZhDQJnhc swzQPkoNkm5GAcHZi/kQ7B3SNNmZN0TmV7yYKoCGEWd6NLKCFmzTqRfnanQ41Xx5HEvm T1s0VKvREkx8eAHUC+RkpQOOHZ5bYfr5VDv0p2X7xf7MZqJYx9uwdqxGACMkkt3C0790 /GHA== X-Gm-Message-State: AOJu0YyzGBDqk1VFTv4kv2mhTeIgBxI+kH9CJYqLdE9yD5eMHuuw3+dL 0kIuPAQI0sFLLw6SKbpi204= X-Received: by 2002:a5d:5550:0:b0:309:1532:8287 with SMTP id g16-20020a5d5550000000b0030915328287mr11155438wrw.19.1696288499527; Mon, 02 Oct 2023 16:14:59 -0700 (PDT) Received: from lucifer.home ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.googlemail.com with ESMTPSA id e31-20020a5d595f000000b0031fbbe347e1sm63860wri.65.2023.10.02.16.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 16:14:58 -0700 (PDT) From: Lorenzo Stoakes To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann , Lorenzo Stoakes Subject: [PATCH v2 0/4] various improvements to the GUP interface Date: Tue, 3 Oct 2023 00:14:50 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 16:15:16 -0700 (PDT) A series of fixes to simplify and improve the GUP interface with an eye to providing groundwork to future improvements:- * __access_remote_vm() and access_remote_vm() are functionally identical, so make the former static such that in future we can potentially change the external-facing implementation details of this function. * Extend is_valid_gup_args() to cover the missing FOLL_TOUCH case, and simplify things by defining INTERNAL_GUP_FLAGS to check against. * Adjust __get_user_pages_locked() to explicitly treat a failure to pin any pages as an error in all circumstances other than FOLL_NOWAIT being specified, bringing it in line with the nommu implementation of this function. * (With many thanks to Arnd who suggested this in the first instance) Update get_user_page_vma_remote() to explicitly only return a page or an error, simplifying the interface and avoiding the questionable IS_ERR_OR_NULL() pattern. v2: * Corrected spelling mistakes in patches 1 and 2 (thanks PeterZ). * Made things WARN_ON_ONCE() where appropriate and dropped unnecessary checks (thanks David). v1: https://lore.kernel.org/all/cover.1696174961.git.lstoakes@gmail.com/ Lorenzo Stoakes (4): mm: make __access_remote_vm() static mm/gup: explicitly define and check internal GUP flags, disallow FOLL_TOUCH mm/gup: make failure to pin an error if FOLL_NOWAIT not specified mm/gup: adapt get_user_page_vma_remote() to never return NULL arch/arm64/kernel/mte.c | 4 ++-- include/linux/mm.h | 14 +++++++++----- kernel/events/uprobes.c | 4 ++-- kernel/ptrace.c | 2 +- mm/gup.c | 16 +++++++++++++--- mm/internal.h | 3 +++ mm/memory.c | 7 +++---- mm/nommu.c | 4 ++-- 8 files changed, 35 insertions(+), 19 deletions(-) -- 2.42.0