Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 2 Oct 2023 16:15:51 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH] kbuild: make binrpm-pkg always produce kernel-devel
 package
Message-ID: <20231002231551.GB1269812@dev-arch.thelio-3990X>
References: <20231001123822.1659773-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231001123822.1659773-1-masahiroy@kernel.org>
Precedence: bulk

On Sun, Oct 01, 2023 at 09:38:22PM +0900, Masahiro Yamada wrote:
> The generation of the kernel-devel package is disabled for binrpm-pkg
> presumably because it was quite big (>= 200MB) and took a long time to
> package.
> 
> Commit fe66b5d2ae72 ("kbuild: refactor kernel-devel RPM package and
> linux-headers Deb package") reduced the package size to 12MB, and now
> it is quick to build. It won't hurt to have binrpm-pkg generate it by
> default.
> 
> If you want to skip the kernel-devel package generation, you can pass
> RPMOPTS='--without devel':
> 
>   $ make binrpm-pkg RPMOPTS='--without devel'
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>

> ---
> 
>  scripts/Makefile.package | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index 05b8c3e29aac..3addd1c0b989 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -94,8 +94,6 @@ rpm-pkg srcrpm-pkg binrpm-pkg: rpmbuild/SPECS/kernel.spec
>  	$(if $(filter a b, $(build-type)), \
>  		--target $(UTS_MACHINE)-linux --build-in-place --noprep --define='_smp_mflags %{nil}' \
>  		$$(rpm -q rpm >/dev/null 2>&1 || echo --nodeps)) \
> -	$(if $(filter b, $(build-type)), \
> -		--without devel) \
>  	$(RPMOPTS))
>  
>  # deb-pkg srcdeb-pkg bindeb-pkg
> -- 
> 2.39.2
>