Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <6917dfcb-651b-45a0-9dc7-c42f765dea02@amd.com>
Date:   Tue, 3 Oct 2023 12:45:48 +1100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH kernel v2] x86/compressed/64: reduce #VC nesting for
 intercepted CPUID for SEV-SNP guest
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <20230926040526.957240-1-aik@amd.com>
 <20230930071759.GAZRfLpz38AAITSZzW@fat_crate.local>
 <e009f70e-32fc-404a-8560-f059b8999895@amd.com>
 <20231001095322.GAZRlBkle6JC2rfM6u@fat_crate.local>
From:   Alexey Kardashevskiy <aik@amd.com>
In-Reply-To: <20231001095322.GAZRlBkle6JC2rfM6u@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2xkOWlkMEtrNEM0OHk4OVpJbWo1ejNuV0drMnkveFpSZmszVHB5djJ0VWFZ?=
 =?utf-8?B?am5uWGJQZ2poUzNVYnZiVHZsTUp4Kzd6cVhHNG1wYThZcVBVQjdmLy9KS2d1?=
 =?utf-8?B?enNGaFNNK2pmUkFYVzl1U1RNR1N5UGVGb3RVTG9mWmw4dzJ3U0Qwd1NySjAz?=
 =?utf-8?B?dmFJcTZqYnkvYWNVRVVkN1EzWWQzbnRud0Q4eFRMOWcxVzk3a0tvS2gxRkpq?=
 =?utf-8?B?cjlVdG4ydktPNGtoc3cwcmxscmxkTkh5OHhqZC9LcGJrMThyL2RVbmgzYzE4?=
 =?utf-8?B?c21QNTRieFNmdEJVY3Y5bW1HNFdpWElRUzIrWnBOV2JENVZwY1hjMVA4Uk8z?=
 =?utf-8?B?N1hsNmhSUWRkSEZWVGRLU0pOcms5U2lXdFphZ3RIb25SeWIwcEh6c0dweWZD?=
 =?utf-8?B?dEhJMHdjTHBha3k2YnRrLytJYWVQMlNWeVc0RkVxRG5QbkFna0ZOM2Vpc1dj?=
 =?utf-8?B?RXJIL1VYdjFYMGpqUXNtcFlpOXpSaWdOeHkyV0ZwVVVBajJjYkFtRHlaQUNl?=
 =?utf-8?B?VThTSTY5cXFWSU13ampacitrSFN5aElpT08zMVMrdlBuY0VKM0RGU2Q0Z0dE?=
 =?utf-8?B?RHFpM2d3SUxNWFVoWWt6MStNN3Q0MUx3Q0xUSWI2b1lNejFUUGdJOG05TGFJ?=
 =?utf-8?B?cDdCemRveDdicUlqdVFJL0pseEVYazJJcHRUMjJCSUJHZHBUQ3ZxOXluMFdT?=
 =?utf-8?B?ZXJzVTlOYmx0MGhSUFNDamFycExPK0pDY2xIZVYvWXBWU0VkSWZibElBYTZu?=
 =?utf-8?B?WS9DbjVVemVGOXlidHdxckdER3ltUGdSd1VJdm8xaEtBSUdrek41TXZSMmNB?=
 =?utf-8?B?TVpheWVid1dlM3picXd3dTk4OTBxQXkzS2JSQUxUOTFsMVlEc2xrUTRIcXMr?=
 =?utf-8?B?QWw3L3lNUVRZcGdCc3A0Nm5xdDJHUkl0UVhQSjVmR0c4azZWRVJpdGhCZnFh?=
 =?utf-8?B?N2ZTZDZCK2RIak1VNDh1cjdFM1BrU0d3aThGdEdUVWRXNFkzNU5LWEoxT2g5?=
 =?utf-8?B?RVUyeWhxUElMVzJRUGYydzk3Vi9RazBDUlVFUDl5dFhVMkhOZVo1MmlNbFYv?=
 =?utf-8?B?eTQwMWNFQnFoWSt3Zlpwbkg2TnI1Z0hGR1Y0VHVrTmpOeHA3VnlvTmFHMW5y?=
 =?utf-8?B?Z01aM3YybTFsZlBqR0pUUm1VRm9Da093K2NTcHJST1FQZmQyQlUvenliZzh2?=
 =?utf-8?B?ZkphLzZncGxMbE1FeUNodHFCendCbHUwVjhkcDB3ZTNZaFgrNC9Fc0FIblYv?=
 =?utf-8?B?TjRNMzM5Y2xLMkQrdnBaNU9iMmNhRksySG9mRlVzeVREOHFDaGZWNmI2QTdv?=
 =?utf-8?B?UjZUNnYrL2FFSUlOYVJrTUhHajRDY2lyV25KU3pFMGhibjFnZnVzUmEzRDlO?=
 =?utf-8?B?SVZPci93djl0TlFvei9vSXRsMXU4RUgrZ1ppZmx2Wll2c0NSVkRJZVEzVFBu?=
 =?utf-8?B?aFVYQWlCWWpsYkJyTzJxVDZUVnlYUW1HSGZjMG1RY21WUndSY3BGZjhlWnZ0?=
 =?utf-8?B?MDB4RlRaOSt4dDlVaFA4dEZSOERsaTVORHl3OWw3MEN1blY2TVozTWMrOWlH?=
 =?utf-8?B?c2tPQjV1eDlDdllYOHVKWWpxTzFxUW9oVDZLRGdnWkFwQ3ZGVDZkS0ZUZFFh?=
 =?utf-8?B?K1daNXdCSDN2VFhqSjE4UUM4TzBraVBsd1ZBenY5MjBMN3RUNjRDbUV6WDIv?=
 =?utf-8?B?Tlg5dlVuTGZSNDVPcE1KTlhsc08vejU4c0k1Y0Z3SGx4OVdSUDl0RlhBaUtU?=
 =?utf-8?B?eSswMi9uR2xTTit4VUhvT3F6NXh2L3Y4cElRUVhLZHdOa1pvNVNneGNwVzBS?=
 =?utf-8?B?bndlNXk3WVh2WjNScVY2TEwxTHNTT3NwN3cva0pNL1RnbjZMN0gzSE16SjQx?=
 =?utf-8?B?YVEzekp3eTB0QkF4UGhDKzBib2YzL2JTWVVGMGkrbnMrLzM4ZXhOWWZQYjlZ?=
 =?utf-8?B?eUs1V2ZIS2ZXSGFvSWgrbW9wZlFFNU1RRWFYNWFBVmJ4cjlrUURuV2xhOUov?=
 =?utf-8?B?NUEza3loZSsweEZSakFIVDMwYUt1Um5WZGYxaFQ2NFhPb3hUMGxSUmZGYUda?=
 =?utf-8?B?d1ZPSTUrdDNRL3lpeStTRG9KZnhtUk44eU02K2dTTEhmQlRnTnBZNk9sQmlv?=
 =?utf-8?Q?zxVyMHbrgzb+QxuHMK8NQSHOf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f179d81-a959-4403-a037-08dbc3b27c56
X-MS-Exchange-CrossTenant-AuthSource: LV3PR12MB9213.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 01:45:56.2148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +R/BB2VIpHvy7VyzQTRA0ASMo6AeOXWWivD5ezdJivbVA8PM0KqUB5kytGLFlu8ieaEUYjtrVgShBzVybYPqqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8582
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 18:46:20 -0700 (PDT)


On 1/10/23 20:53, Borislav Petkov wrote:
> On Sun, Oct 01, 2023 at 08:40:30PM +1100, Alexey Kardashevskiy wrote:
>> Ingo says different, who wins? :)
> 
> I do: a function gives you type checking - a macro doesn't.

The macro is a wrapper for the sev_es_ghcb_hv_call() function with type 
checking.

>>> Then, it should be defined only in sev-shared.c for now.
>>
>> sev-shared.c makes me sad. Including .c is not ... nice,
> 
> There's a point in doing things this way.
> 
>> I would avoid adding stuff to it at any cost.
> 
> Care to give a technical argument why or is it just general sadness?
> Because I don't care about non-technical sentiments.

No it is not technical, it is my ignorance :)

For example why inat.c/insn.c are included and not linked? Cannot linux 
compile arch/x86/lib/ files twice into two different .o, for compressed 
and running kernels? Is not more logical place for sev-shared.c in 
arch/x86/lib/sev.c?

>>> Furthermore, it should not be called "rdmsr" or so but something like
>>>
>>> ghcb_prot_read_msr()
>>>
>>> or so to denote that it is using the GHCB protocol to read the MSR. I'm
>>> sure it'll gain more users with time.
>>
>> What is "prot" going to signify?
> 
> "... or so to denote that it is using the GHCB protocol..."
> 					       ^^^^^^^^
> 
> it is right there.

Ah right. I am used (after some grepping - not just me) to "prot" == 
"protected", "protocol" would be "proto". imho not needed here but alright.


>> And what about Tom's "x86/sev: Fix SNP CPUID requests to the hypervisor",
>> are you taking that one or I have to repost this one and the Tom's patch?
> 
> Yes, use this branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=tip-x86-urgent


Oh cool, thanks!


> Thx.
> 

-- 
Alexey