Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231001131047.15176-1-april@acab.dev>
In-Reply-To: <20231001131047.15176-1-april@acab.dev>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 2 Oct 2023 21:16:08 -0700
Message-ID: <CAM9d7cgB6GfJSQhWJwmi=FodKwsYdVy_FnRJ+jzt1DpmO-J3cg@mail.gmail.com>
Subject: Re: [PATCH] /bin/dmesg to dmesg Path
To:     April John <april@acab.dev>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-perf-users@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

On Sun, Oct 1, 2023 at 6:10 AM April John <april@acab.dev> wrote:
>
> Dmesg is not in every distro at /bin/dmesg, in NixOS for example, this fails,
> but the path should in most cases contain dmesg.
> This follows the example of replacing /bin/bash with bash Path in the codebase.
>
> ---
> tools/perf/util/evsel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a8a5ff87c..aa602aae6 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -3053,7 +3053,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
>
> return scnprintf(msg, size,
> "The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
> - "/bin/dmesg | grep -i perf may provide additional information.\n",
> + "dmesg | grep -i perf may provide additional information.\n",
> err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
> }
>
> --
> 2.42.0
>
> Signed-off-by: April John <april@acab.dev>

It is usual to put a tag after the patch, it should be at the end of the
commit message.  With that,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung