Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1776877rdb; Mon, 2 Oct 2023 23:56:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGWb4Q6c1DSozxaHwPTH/nnc9Qi6xx+JSTw2fMHmQrxKQLRMk1ggetPPm1i1yrdxJucyum X-Received: by 2002:a17:90a:f185:b0:269:25a8:66c with SMTP id bv5-20020a17090af18500b0026925a8066cmr11455758pjb.45.1696316205825; Mon, 02 Oct 2023 23:56:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696316205; cv=none; d=google.com; s=arc-20160816; b=DE4/anM6/pOQF1KTNDe0GdegpdOdwlFt9r3/9x5w8f+xMFzhrMmysHi1U5fyL+WBiN juNYHk7rRKkA3ObVtBe0wMGiWTKTk9NH2mkWiapSMR6sxQWX/zgJpwGD289HRSUVfWL6 G2Pfiul2rgLhb0dHGwgc+8gUqrfWrhZDn2snES3dRPdZ7TN2RWPGK24AnNnP8Q8iywMq 3TwjA3Awq7xFBrHF/Ur2aFQY6QpcgKpVinI1z7Ep2YgnSfvll2RFwOHb2CspUU+txcY1 eOCCMv96xHUwh0Ric3e81Qu1RvSKjyk64QVWdxQvkZS7AbQOzJSdgWvLmLUDmYj4ER08 2hEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LCRDflOv8BGvouMz/P/NOgPdmMAO4XsG/D55UB1KVew=; fh=Tb1p8S3iOxe/kX/WSNC3xEJzSVgGJ5DaxSrKb+pzH+4=; b=E7gZMUexbmjooBOoPA/2bKNPam80xVmk0ZtQjesuEJp45QZ51PIZzhuXvTeGLki/ln vquWPM64VFttzyDaAIv/NtxFzfHDY+7tEjDdfKxpg3UefD0my1dANwQkfQ2ztsBzOXOW SpwMiz0to9QIozqVrxIv42ETnqJYZz/G7xc6B7a2z2i6Env3AL1kgTzam/i/W1rNQlfF xPhyiXaGxXhxWyBldMI5sPyNQ5RYXjXpMHclDlP91UU8SKh1iCtqvGgGey56CoPr/wi0 Pzzh3ybEZ8AkZ5pbE8WuMfCt6chFXBdB+/q31dz0Hno02pb4SoHSlL8+o4eP5wnwf1Hp n1qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nDnCUFQx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z3-20020a1709027e8300b001b7ea20dbf2si733776pla.224.2023.10.02.23.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 23:56:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nDnCUFQx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0E045809ABC8; Mon, 2 Oct 2023 23:56:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239355AbjJCGz6 (ORCPT + 99 others); Tue, 3 Oct 2023 02:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239309AbjJCGzG (ORCPT ); Tue, 3 Oct 2023 02:55:06 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8B81B6; Mon, 2 Oct 2023 23:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696316095; x=1727852095; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=daicXFK30tmpTUp95RTD2ZQAe5K9xY8zuW1WSEbSaqA=; b=nDnCUFQxZgerOfIkCgM34Px/AXBYzixLOj6nwRha90OvxWgqdBHj/cUw u0YkxfTgcGbxQKVH9xExFNSuVQimlAd7VMpPIJVqXp6m29SscCKI4hNfD 5b7/pGyiL2EsAxE2tRJbmWgadN+lgcFDp3J16Eyq2E82AK2HBLtWMnSTT LTPy0bDAC1kxC4cv00HGmtab2kFk5mfhlcMV463FVoQNilIiRP4aei6yf ZGCepMZ9osq3XAsLe3+42IT0BeaI6gTsMcCWb7o47H0NY0YZQ5ffZdKZZ Ucc0Ig1qNe2uz3njWE/DNQ+JfpQiC89PyfKYiRJqTTLCmClWNgrXdWmcQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="367858154" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="367858154" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 23:54:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="1081900963" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="1081900963" Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2023 23:54:45 -0700 From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, pbonzini@redhat.com, seanjc@google.com, peterz@infradead.org, jgross@suse.com, ravi.v.shankar@intel.com, mhiramat@kernel.org, andrew.cooper3@citrix.com, jiangshanlai@gmail.com, nik.borisov@suse.com Subject: [PATCH v12 21/37] x86/fred: No ESPFIX needed when FRED is enabled Date: Mon, 2 Oct 2023 23:24:42 -0700 Message-Id: <20231003062458.23552-22-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231003062458.23552-1-xin3.li@intel.com> References: <20231003062458.23552-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 23:56:02 -0700 (PDT) From: "H. Peter Anvin (Intel)" Because FRED always restores the full value of %rsp, ESPFIX is no longer needed when it's enabled. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/kernel/espfix_64.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/kernel/espfix_64.c b/arch/x86/kernel/espfix_64.c index 16f9814c9be0..6726e0473d0b 100644 --- a/arch/x86/kernel/espfix_64.c +++ b/arch/x86/kernel/espfix_64.c @@ -106,6 +106,10 @@ void __init init_espfix_bsp(void) pgd_t *pgd; p4d_t *p4d; + /* FRED systems always restore the full value of %rsp */ + if (cpu_feature_enabled(X86_FEATURE_FRED)) + return; + /* Install the espfix pud into the kernel page directory */ pgd = &init_top_pgt[pgd_index(ESPFIX_BASE_ADDR)]; p4d = p4d_alloc(&init_mm, pgd, ESPFIX_BASE_ADDR); @@ -129,6 +133,10 @@ void init_espfix_ap(int cpu) void *stack_page; pteval_t ptemask; + /* FRED systems always restore the full value of %rsp */ + if (cpu_feature_enabled(X86_FEATURE_FRED)) + return; + /* We only have to do this once... */ if (likely(per_cpu(espfix_stack, cpu))) return; /* Already initialized */ -- 2.34.1